Skip to contentSkip to conversation

bnx2x: remove dead code and make local funcs static

PATCH Applied Stephen Hemminger 3 participants 3 messages Feb 22, 2013 – Feb 25, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bnx2x: remove dead code and make local funcs static

Sparse warned about several functions that were unnecessarily global. After making them static, discovered that several functions were actually never used.

Compile tested only.

drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c +2 -2
@@ -98,7 +98,7 @@ static inline int bnx2x_pfvf_status_code
 	}
 }
 
-int bnx2x_send_msg2pf(struct bnx2x *bp, u8 *done, dma_addr_t msg_mapping)
+static int bnx2x_send_msg2pf(struct bnx2x *bp, u8 *done, dma_addr_t msg_mapping)
 {
 	struct cstorm_vf_zone_data __iomem *zone_data =
 		REG_ADDR(bp, PXP_VF_ADDR_CSDM_GLOBAL_START);
@@ -141,7 +141,7 @@ int bnx2x_send_msg2pf(struct bnx2x *bp,
 	return 0;
 }
 
-int bnx2x_get_vf_id(struct bnx2x *bp, u32 *vf_id)
+static int bnx2x_get_vf_id(struct bnx2x *bp, u32 *vf_id)
 {
 	u32 me_reg;
 	int tout = 10, interval = 100; /* Wait for 1 sec */
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c +0 -58

64 lines not on this page · raw message

Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Stephen Hemminger

Sparse warned about several functions that were unnecessarily global. After making them static, discovered that several functions were actually never used.

Compile tested only.

Hi Stephen,

Thanks for this patch. The "dead code" part is actually a missing call in case of PHY FW upgrade for the 84833 PHY - without it, a server reboot is required for the new PHY FW to take affect - but this reboot saving enhancement should wait until net-next is open, so I'm acking this patch and we will add the code back with the proper call once the net-next is open again.

maintainer Applied
#2 lore raw

From: "Eilon Greenstein" <[email protected]>
Date: Sun, 24 Feb 2013 22:25:20 +0200

Quoted 11 lines · Stephen Hemminger
Quoted 7 lines

Sparse warned about several functions that were unnecessarily global. After making them static, discovered that several functions were actually never used.

Compile tested only.

Hi Stephen,

Quoted 8 lines

Thanks for this patch. The "dead code" part is actually a missing call in case of PHY FW upgrade for the 84833 PHY - without it, a server reboot is required for the new PHY FW to take affect - but this reboot saving enhancement should wait until net-next is open, so I'm acking this patch and we will add the code back with the proper call once the net-next is open again.

Applied.