compress: Change compress_write() to take buffer as const void *
PATCH 2/14 compress: Change compress_write() to take buffer as const void *
The input buffer to compress_write() should be const, and is better defined as void * so the caller doesn't have to cast.
compress.c +4 -3
@@ -299,11 +299,12 @@ int compress_get_tstamp(struct compress *compress,return 0 ; } -int compress_write (struct compress *compress,char *buf,unsigned int size) +int compress_write (struct compress *compress,const void *buf,unsigned int size) {struct snd_compr_avail avail;struct pollfd fds;int to_write, written, total =0 , ret; +const char * cbuf = buf;if (!(compress->flags &COMPRESS_IN ))return oops (compress, -EINVAL ,"Invalid flag set" );
@@ -343,12 +344,12 @@ int compress_write(struct compress *compress, char *buf, unsigned int size) to_write = avail.avail; else to_write = size; - written =write (compress->fd, buf, to_write); + written =write (compress->fd, cbuf, to_write);if (written <0 )return oops (compress, errno,"write failed!\n" ); size -= written; - buf += written; + cbuf += written; total += written; }return total;
include/tinycompress/tinycompress.h +1 -1
@@ -125,7 +125,7 @@ int compress_get_tstamp(struct compress *compress,* @buf: pointer to data * @size: number of bytes to be written */ -int compress_write (struct compress *compress,char *buf,unsigned int size); +int compress_write (struct compress *compress,const void *buf,unsigned int size);/* * compress_read: read data from the compress stream
Signature · 1 line
1.7.2.5
The input buffer to compress_write() should be const, and is better defined as void * so the caller doesn't have to cast.
--- compress.c | 7 ++++--- include/tinycompress/tinycompress.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-)
compress.c +4 -3
@@ -312,11 +312,12 @@ int compress_get_tstamp(struct compress *compress,return 0 ; } -int compress_write (struct compress *compress,char *buf,unsigned int size) +int compress_write (struct compress *compress,const void *buf,unsigned int size) {struct snd_compr_avail avail;struct pollfd fds;int to_write, written, total =0 , ret; +const char * cbuf = buf;if (!(compress->flags &COMPRESS_IN ))return oops (compress, -EINVAL ,"Invalid flag set" );
@@ -355,12 +356,12 @@ int compress_write(struct compress *compress, char *buf, unsigned int size) to_write = avail.avail; else to_write = size; - written =write (compress->fd, buf, to_write); + written =write (compress->fd, cbuf, to_write);if (written <0 )return oops (compress, errno,"write failed!" ); size -= written; - buf += written; + cbuf += written; total += written; }return total;
include/tinycompress/tinycompress.h +1 -1
@@ -126,7 +126,7 @@ int compress_get_tstamp(struct compress *compress,* @buf: pointer to data * @size: number of bytes to be written */ -int compress_write (struct compress *compress,char *buf,unsigned int size); +int compress_write (struct compress *compress,const void *buf,unsigned int size);/* * compress_read: read data from the compress stream
Signature · 1 line
1.7.2.5