Skip to contentSkip to conversation

Put git commit 51ac8893a7a51b196501164e645583bf78138699 on the stable tree please

DISCUSSION Konrad Rzeszutek Wilk 5 participants 8 messages Feb 22, 2013 – Mar 2, 2013 Stable branch

lore
Share & tools
lore
#0 lore raw

Hey Greg,

Please put git commit 51ac8893a7a51b196501164e645583bf78138699 commit 51ac8893a7a51b196501164e645583bf78138699

Author: Jan Beulich <[email protected]>
Date:   Wed Feb 6 10:30:38 2013 -0500

xen-pciback: rate limit error messages from xen_pcibk_enable_msi{,x}()

on the stable tree please. It is an security errata fix and should have had the CC: [email protected] but did not.

maintainer
#1 lore raw
Quoted 11 lines · Konrad Rzeszutek Wilk

Hey Greg,

Please put git commit 51ac8893a7a51b196501164e645583bf78138699 commit 51ac8893a7a51b196501164e645583bf78138699

Author: Jan Beulich <[email protected]>
Date:   Wed Feb 6 10:30:38 2013 -0500

xen-pciback: rate limit error messages from xen_pcibk_enable_msi{,x}()

on the stable tree please. It is an security errata fix and should have had the CC: [email protected] but did not.

Thanks, what stable kernel releases should it be queued up for?

And, in the future, always send this to [email protected], not to me and lkml, the other stable kernel maintainers will want to know this.

greg k-h

#2 lore raw
Quoted 9 lines
Quoted 1 line
Quoted 1 line · Greg KH
Quoted 7 lines · Konrad Rzeszutek Wilk

Hey Greg,

Please put git commit 51ac8893a7a51b196501164e645583bf78138699 commit 51ac8893a7a51b196501164e645583bf78138699

Author: Jan Beulich <[email protected]>
Date:   Wed Feb 6 10:30:38 2013 -0500
Quoted 6 lines
Quoted 4 lines

xen-pciback: rate limit error messages from xen_pcibk_enable_msi{,x}()

on the stable tree please. It is an security errata fix and should have had the CC: [email protected] but did not.

Thanks, what stable kernel releases should it be queued up for?

Anyone from 3.1 onwards that is still being maintained.

Jan

#3 lore raw
Quoted 9 lines · Jan Beulich
Quoted 9 lines
Quoted 1 line
Quoted 1 line · Greg KH
Quoted 7 lines · Konrad Rzeszutek Wilk

Hey Greg,

Please put git commit 51ac8893a7a51b196501164e645583bf78138699 commit 51ac8893a7a51b196501164e645583bf78138699

Author: Jan Beulich <[email protected]>
Date:   Wed Feb 6 10:30:38 2013 -0500
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

xen-pciback: rate limit error messages from xen_pcibk_enable_msi{,x}()

on the stable tree please. It is an security errata fix and should have had the CC: [email protected] but did not.

Thanks, what stable kernel releases should it be queued up for?

Anyone from 3.1 onwards that is still being maintained.

What Jan said please.

Quoted 3 lines

Jan

#4 lore raw
In reply to Jan Beulich
Quoted 17 lines · Konrad Rzeszutek Wilk
Quoted 8 lines · Greg KH
Quoted 7 lines · Konrad Rzeszutek Wilk

Hey Greg,

Please put git commit 51ac8893a7a51b196501164e645583bf78138699 commit 51ac8893a7a51b196501164e645583bf78138699

Author: Jan Beulich <[email protected]>
Date:   Wed Feb 6 10:30:38 2013 -0500
Quoted 6 lines
Quoted 4 lines

xen-pciback: rate limit error messages from xen_pcibk_enable_msi{,x}()

on the stable tree please. It is an security errata fix and should have had the CC: [email protected] but did not.

Thanks, what stable kernel releases should it be queued up for?

3.4 and later please.

Quoted 1 line · Jan Beulich

Anyone from 3.1 onwards that is still being maintained.

Hm, who should I believe here... :)

It doesn't matter for me, but for the 3.2 tree, it does.

thanks,

greg k-h

#5 lore raw
Quoted 15 lines · Greg KH
Quoted 14 lines · Konrad Rzeszutek Wilk
Quoted 13 lines · Greg KH
Quoted 11 lines · Konrad Rzeszutek Wilk

Hey Greg,

Please put git commit 51ac8893a7a51b196501164e645583bf78138699 commit 51ac8893a7a51b196501164e645583bf78138699

Author: Jan Beulich <[email protected]>
Date:   Wed Feb 6 10:30:38 2013 -0500

xen-pciback: rate limit error messages from xen_pcibk_enable_msi{,x}()

on the stable tree please. It is an security errata fix and should have had the CC: [email protected] but did not.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Thanks, what stable kernel releases should it be queued up for?

3.4 and later please.

Quoted 1 line · Jan Beulich

Anyone from 3.1 onwards that is still being maintained.

Hm, who should I believe here... :)

Just in case my previous email crossed paths or got deleted.

Quoted 2 lines

It doesn't matter for me, but for the 3.2 tree, it does.

3.1 and later please.

#6 lore raw
Quoted 23 lines · Konrad Rzeszutek Wilk
Quoted 22 lines · Greg KH
Quoted 17 lines · Konrad Rzeszutek Wilk
Quoted 8 lines · Greg KH
Quoted 7 lines · Konrad Rzeszutek Wilk

Hey Greg,

Please put git commit 51ac8893a7a51b196501164e645583bf78138699 commit 51ac8893a7a51b196501164e645583bf78138699

Author: Jan Beulich <[email protected]>
Date:   Wed Feb 6 10:30:38 2013 -0500
Quoted 6 lines
Quoted 4 lines

xen-pciback: rate limit error messages from xen_pcibk_enable_msi{,x}()

on the stable tree please. It is an security errata fix and should have had the CC: [email protected] but did not.

Thanks, what stable kernel releases should it be queued up for?

3.4 and later please.

Quoted 1 line · Jan Beulich

Anyone from 3.1 onwards that is still being maintained.

Quoted 7 lines
Quoted 1 line

Hm, who should I believe here... :)

Just in case my previous email crossed paths or got deleted.

Quoted 2 lines

It doesn't matter for me, but for the 3.2 tree, it does.

3.1 and later please.

Queued up for 3.2.

I had to add '#include <linux/ratelimit.h>' in drivers/xen/xen-pciback/xen-pciback.c, as printk_ratelimited() uses DEFINE_RATELIMIT_STATE() which is defined in <linux/ratelimit.h>. (In mainline this is inclued in <linux/device.h>, but really it ought to be included in <linux/kernel.h> as well.)

Ben.

Signature · 2 lines
Ben Hutchings
Computers are not intelligent.	They only think they are.
#7 lore raw
In reply to Greg KH
Quoted 8 lines · Greg KH
Quoted 7 lines · Konrad Rzeszutek Wilk

Hey Greg,

Please put git commit 51ac8893a7a51b196501164e645583bf78138699 commit 51ac8893a7a51b196501164e645583bf78138699

Author: Jan Beulich <[email protected]>
Date:   Wed Feb 6 10:30:38 2013 -0500
Quoted 6 lines
Quoted 4 lines

xen-pciback: rate limit error messages from xen_pcibk_enable_msi{,x}()

on the stable tree please. It is an security errata fix and should have had the CC: [email protected] but did not.

Thanks, what stable kernel releases should it be queued up for?

3.4 and later please.

Quoted 3 lines

And, in the future, always send this to [email protected], not to me and lkml, the other stable kernel maintainers will want to know this.

Yes of course. Sorry about that - put the CC here now..

Quoted 2 lines

greg k-h