Skip to contentSkip to conversation

RDMA/amso1100: Add driver for Ammasso 1100 RNIC

DISCUSSION Dan Carpenter 1 participant 1 message Feb 23, 2013 InfiniBand

lore
Share & tools
lore
#0 lore raw

Hello Tom Tucker,

The patch f94b533d091a: "RDMA/amso1100: Add driver for Ammasso 1100 RNIC" from Sep 22, 2006, leads to the following warning:
"drivers/infiniband/hw/amso1100/c2_provider.c:272 c2_create_qp()
error: passing non neg 255 to ERR_PTR"

drivers/infiniband/hw/amso1100/c2_qp.c
496 reply = (struct c2wr_qp_create_rep *) (unsigned long) (vq_req->reply_msg);
497 if (!reply) {
498 err = -ENOMEM;
499 goto bail3;
500 }
501

   502          if ((err = c2_wr_get_result(reply)) != 0) {
                           ^^^^^^^^^^^^^^^^^^^^^^^

This returns an unsigned char and not a negative error code.

503 goto bail4;
504 }
505
506 /* Fill in the kernel QP struct */

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html