new package: adns
PATCH 1/1 new package: adns
GNU adns
Advanced, easy to use, asynchronous-capable DNS client library and utilities.
adns is a resolver library for C (and C++) programs, and a collection of useful DNS resolver utilities.
--- package/Config.in | 1 + package/adns/Config.in | 7 + package/adns/adns-1.4-cnamechain.patch | 1275 +++++++++++++++ package/adns/adns-1.4-destdir.patch | 54 + package/adns/adns-1.4-ipv6.patch | 2725 ++++++++++++++++++++++++++++++++ package/adns/adns-1.4-rh514838.patch | 26 + package/adns/adns.mk | 15 + 7 files changed, 4103 insertions(+), 0 deletions(-) create mode 100644 package/adns/Config.in create mode 100644 package/adns/adns-1.4-cnamechain.patch create mode 100644 package/adns/adns-1.4-destdir.patch create mode 100644 package/adns/adns-1.4-ipv6.patch create mode 100644 package/adns/adns-1.4-rh514838.patch create mode 100644 package/adns/adns.mk
package/Config.in +1 -0
@@ -612,6 +612,7 @@ source "package/sound-theme-freedesktop/Config.in" endmenu menu "Networking applications" +source "package/adns/Config.in" source "package/argus/Config.in" source "package/arptables/Config.in" source "package/avahi/Config.in"
package/adns/Config.in new file +7 -0
@@ -0,0 +1,7 @@ +config BR2_PACKAGE_ADNS + bool "adns" + help + Advanced, easy to use, asynchronous-capable DNS client + library and utilities. + + http://www.chiark.greenend.org.uk/~ian/adns
package/adns/adns-1.4-cnamechain.patch new file +1275 -0
1,275 lines not on this page · raw message
package/adns/adns-1.4-destdir.patch new file +54 -0
54 lines not on this page · raw message
package/adns/adns-1.4-ipv6.patch new file +2725 -0
1,657 lines not on this page · raw message
package/adns/adns-1.4-rh514838.patch new file +26 -0
Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Signature · 1 line
1.7.7.6
Part of the diff is not shown here. View the raw message.
PATCH 1/1 new package: adns
Dear Stefan Fr?berg,
Thanks for this package, definitely something useful to have.
Quoted 7 lines · Stefan Fr?berg
GNU adns
Advanced, easy to use, asynchronous-capable DNS client library and utilities.
adns is a resolver library for C (and C++) programs, and a collection of useful DNS resolver utilities.
Quoted 8 lines
Signed-off-by Stefan Fr?berg <[email protected]>--- package/Config.in | 1 + package/adns/Config.in | 7 + package/adns/adns-1.4-cnamechain.patch | 1275 +++++++++++++++ package/adns/adns-1.4-destdir.patch | 54 + package/adns/adns-1.4-ipv6.patch | 2725 ++++++++++++++++++++++++++++++++ package/adns/adns-1.4-rh514838.patch | 26 +
If possible, I think I would prefer to have the adns package download those patches rather than have them in the Buildroot source tree directly.
ADNS_PATCHES = http://somewhere.com/foobar.patch \
http://somewhereelse.com/barfoo.patch
I am not sure if the patch that allows that has already been merged upstream, but it has been floating on the list for some time, and I think it's a good thing to have.
package/adns/adns.mk line 12
Quoted 6 lines
package/adns/adns.mk new file +6
-0+ADNS_VERSION = 1.4 +ADNS_SOURCE = adns-$(ADNS_VERSION).tar.gz +ADNS_SITE = http://www.chiark.greenend.org.uk/~ian/adns/ftp/ +ADNS_AUTORECONF = YES +ADNS_INSTALL_STAGING = YES +ADNS_CONF_OPT += --enable-dynamic=elf
You should add ADNS_LICENSE and ADNS_LICENSE_FILES.
Also, did you test build this adns thing with a minimal uClibc? No specific toolchain feature needed (largefile, IPv6, etc.) ?
Thanks!
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 new package: adns
Hello Thomas
16.2.2013 4:06, Thomas Petazzoni kirjoitti:
Quoted 24 lines
Dear Stefan Fr?berg,
Thanks for this package, definitely something useful to have.
Quoted 7 lines · Stefan Fr?berg
GNU adns
Advanced, easy to use, asynchronous-capable DNS client library and utilities.
adns is a resolver library for C (and C++) programs, and a collection of useful DNS resolver utilities.
Quoted 8 lines
Signed-off-by Stefan Fr?berg <[email protected]>--- package/Config.in | 1 + package/adns/Config.in | 7 + package/adns/adns-1.4-cnamechain.patch | 1275 +++++++++++++++ package/adns/adns-1.4-destdir.patch | 54 + package/adns/adns-1.4-ipv6.patch | 2725 ++++++++++++++++++++++++++++++++ package/adns/adns-1.4-rh514838.patch | 26 +If possible, I think I would prefer to have the adns package download those patches rather than have them in the Buildroot source tree directly.
Quoted 6 lines
ADNS_PATCHES= http://somewhere.com/foobar.patch \
http://somewhereelse.com/barfoo.patchI am not sure if the patch that allows that has already been merged upstream, but it has been floating on the list for some time, and I think it's a good thing to have.
It's a little bit difficult because almost all those patches were extracted either from Fedora src.rpm package,
from mailing list or from Suse website and not easily available as downloadable files.
Maybe I could upload them to my server for keeping.
Quoted 7 lines
package/adns/adns.mk line 12
Quoted 6 lines
package/adns/adns.mk new file +6
-0+ADNS_VERSION = 1.4 +ADNS_SOURCE = adns-$(ADNS_VERSION).tar.gz +ADNS_SITE = http://www.chiark.greenend.org.uk/~ian/adns/ftp/ +ADNS_AUTORECONF = YES +ADNS_INSTALL_STAGING = YES +ADNS_CONF_OPT += --enable-dynamic=elfYou should add
ADNS_LICENSEandADNS_LICENSE_FILES.
Okay
Quoted 2 lines
Also, did you test build this adns thing with a minimal uClibc? No specific toolchain feature needed (largefile, IPv6, etc.) ?
Well, not very minimal yet. I did this package to test with wireshark that Baruch is now working
on.
But I will do a separate buildroot build with minimal uClibc conf and see what happens.
Quoted 3 lines
Thanks!
Thomas
Thank you!
Stefan
PATCH 1/1 new package: adns
In reply to Thomas PetazzoniHi Thomas
16.2.2013 4:06, Thomas Petazzoni kirjoitti:
Quoted 24 lines
Dear Stefan Fr?berg,
Thanks for this package, definitely something useful to have.
Quoted 7 lines · Stefan Fr?berg
GNU adns
Advanced, easy to use, asynchronous-capable DNS client library and utilities.
adns is a resolver library for C (and C++) programs, and a collection of useful DNS resolver utilities.
Quoted 8 lines
Signed-off-by Stefan Fr?berg <[email protected]>--- package/Config.in | 1 + package/adns/Config.in | 7 + package/adns/adns-1.4-cnamechain.patch | 1275 +++++++++++++++ package/adns/adns-1.4-destdir.patch | 54 + package/adns/adns-1.4-ipv6.patch | 2725 ++++++++++++++++++++++++++++++++ package/adns/adns-1.4-rh514838.patch | 26 +If possible, I think I would prefer to have the adns package download those patches rather than have them in the Buildroot source tree directly.
Quoted 6 lines
ADNS_PATCHES= http://somewhere.com/foobar.patch \
http://somewhereelse.com/barfoo.patchI am not sure if the patch that allows that has already been merged upstream, but it has been floating on the list for some time, and I think it's a good thing to have.
I tried to contact upstream about these patches but got no response.
So is it's ok to include them in buildroot or should I try to search home for them ?
(currently they are on my server but I don't know how long I can keep them there,
keeping enterprise ready Internet connection is not exactly cheap here)
Those adns patches can be grabbed from here:
http://www.micro-os.com/
Regards
Stefan
PATCH 1/1 new package: adns
Quoted 30 lines · Stefan Fr?berg
Hi Thomas
16.2.2013 4:06, Thomas Petazzoni kirjoitti:
Quoted 27 lines
Dear Stefan Fr?berg,
Thanks for this package, definitely something useful to have.
Quoted 7 lines · Stefan Fr?berg
GNU adns
Advanced, easy to use, asynchronous-capable DNS client library and utilities.
adns is a resolver library for C (and C++) programs, and a collection of useful DNS resolver utilities.
Quoted 8 lines
Signed-off-by Stefan Fr?berg <[email protected]>--- package/Config.in | 1 + package/adns/Config.in | 7 + package/adns/adns-1.4-cnamechain.patch | 1275 +++++++++++++++ package/adns/adns-1.4-destdir.patch | 54 + package/adns/adns-1.4-ipv6.patch | 2725 ++++++++++++++++++++++++++++++++ package/adns/adns-1.4-rh514838.patch | 26 +If possible, I think I would prefer to have the adns package download those patches rather than have them in the Buildroot source tree directly.
ADNS_PATCHES= http://somewhere.com/foobar.patch \
http://somewhereelse.com/barfoo.patch
Quoted 8 lines
Quoted 3 lines
I am not sure if the patch that allows that has already been merged upstream, but it has been floating on the list for some time, and I think it's a good thing to have.
I tried to contact upstream about these patches but got no response.
So is it's ok to include them in buildroot or should I try to search home for them ?
What Thomas means is this:
It looks like you directly fetched these patches from some mailing list archive. Then it would be cleaner to let buildroot download them from there, rather than copying the patch in the buildroot tree.
If for whatever reason it is difficult to retrieve from the 'net, then
it would be nice if you could clean up the patches a little. Some of them even create a .orig file...
Quoted 6 lines
(currently they are on my server but I don't know how long I can keep them there,
keeping enterprise ready Internet connection is not exactly cheap here)Those adns patches can be grabbed from here:
http://www.micro-os.com/
No, we don't want to ask you to host those patches - then it's better
to keep them in the buildroot tree.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 new package: adns
23.2.2013 14:48, Arnout Vandecappelle kirjoitti:
Quoted 40 lines · Stefan Fr?berg
Quoted 39 lines
Hi Thomas
16.2.2013 4:06, Thomas Petazzoni kirjoitti:
Quoted 27 lines
Dear Stefan Fr?berg,
Thanks for this package, definitely something useful to have.
Quoted 10 lines · Stefan Fr?berg
GNU adns
Advanced, easy to use, asynchronous-capable DNS client library and utilities.
adns is a resolver library for C (and C++) programs, and a collection of
useful DNS resolver utilities.Signed-off-by Stefan Fr?berg <[email protected]>Quoted 8 lines
--- package/Config.in | 1 + package/adns/Config.in | 7 + package/adns/adns-1.4-cnamechain.patch | 1275 +++++++++++++++ package/adns/adns-1.4-destdir.patch | 54 + package/adns/adns-1.4-ipv6.patch | 2725 ++++++++++++++++++++++++++++++++ package/adns/adns-1.4-rh514838.patch | 26 +If possible, I think I would prefer to have the adns package download those patches rather than have them in the Buildroot source tree directly.
Quoted 6 lines
ADNS_PATCHES= http://somewhere.com/foobar.patch \
http://somewhereelse.com/barfoo.patchI am not sure if the patch that allows that has already been merged upstream, but it has been floating on the list for some time, and I think it's a good thing to have.
I tried to contact upstream about these patches but got no response.
Quoted 9 lines
Quoted 2 lines
So is it's ok to include them in buildroot or should I try to search home for them ?
What Thomas means is this:
It looks like you directly fetched these patches from some mailing list archive. Then it would be cleaner to let buildroot download them from there, rather than copying the patch in the buildroot tree.
Yes, that adns-1.4-cnamechain.patch is originally from their mailing list but Gentoo hosts it too:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-libs/adns/files/adns-1.4-cnamechain.patch
However, here's the problem:
As you can see that cnamechain patch is patch level -p0 But those others patches are not.
Even worse, that adns-1.4-rh514838.patch (patch level -p1) is extracted from Fedora src.rpm file.
And that adns-1.4-destdir.patch, AFAIK, can only be located from here (and is also patch level -p0)
https://build.opensuse.org/package/view_file?file=adns-1.4-destdir.patch&package=adns&project=devel%3Alibraries%3Ac_c%2B%2B
So it's a mess and I don't think using direct download method will ever work for this complete patch set.
Quoted 10 lines
If for whatever reason it is difficult to retrieve from the 'net,
then it would be nice if you could clean up the patches a little. Some of them even create a .orig file...Quoted 4 lines
(currently they are on my server but I don't know how long I can keep them there,
keeping enterprise ready Internet connection is not exactly cheap here)
Quoted 6 lines
Quoted 2 lines
Those adns patches can be grabbed from here:
http://www.micro-os.com/No, we don't want to ask you to host those patches - then it's better
to keep them in the buildroot tree.
That would be great!
Quoted 4 lines
Regards,
Arnout
Regards
Stefan
PATCH 1/1 new package: adns
Quoted 11 lines · Stefan Fr?berg
Yes, that adns-1.4-cnamechain.patch is originally from their mailing list but Gentoo hosts it too:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-libs/adns/files/adns-1.4-cnamechain.patchHowever, here's the problem:
As you can see that cnamechain patch is patch level -p0 But those others patches are not.Even worse, that adns-1.4-rh514838.patch (patch level -p1) is extracted from Fedora src.rpm file.
Quoted 6 lines
And that adns-1.4-destdir.patch, AFAIK, can only be located from here (and is also patch level -p0)
https://build.opensuse.org/package/view_file?file=adns-1.4-destdir.patch&package=adns&project=devel%3Alibraries%3Ac_c%2B%2BSo it's a mess and I don't think using direct download method will ever work for this complete patch set.
In that case, keep it in the buildroot tree but clean up the redundant
stuff -- I'll flag in the original commit where the redundant stuff is.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 new package: adns
In reply to Stefan FröbergQuoted 3 lines · Stefan Fr?berg
GNU adns
Advanced, easy to use, asynchronous-capable DNS client library and utilities.
It's not really necessary to repeat the help text in the commit message.
Quoted 3 lines
adns is a resolver library for C (and C++) programs, and a collection of useful DNS resolver utilities.
Isn't this just repeating the above?
Quoted 2 lines
Signed-off-by Stefan Fr?berg <[email protected]>
[snip]
package/adns/adns-1.4-cnamechain.patch line 1
Quoted 7 lines
package/adns/adns-1.4-cnamechain.patch new file +1
-0@@ -0,0 +1,1275 @@ +[ADNS] Re: CNAME chains
Could you start the patch with a link to the place where you found it,
and your Signed-off-by?
Quoted 2 lines
package/adns/adns-1.4-cnamechain.patch new file +2
-0+Brad Spencer spencer at infointeractive.com +Mon, 28 Aug 2006 14:43:00 -0300
[snip]
Quoted 6 lines
package/adns/adns-1.4-cnamechain.patch new file +6
-0+diff -Naur adns-1.4.org/src/internal.h adns-1.4/src/internal.h +--- adns-1.4.org/src/internal.h 2013-01-02 19:55:38.935194976 +0200 ++++ adns-1.4/src/internal.h 2013-01-02 19:55:47.129330386 +0200 +@@ -231,6 +231,9 @@ + int cname_dglen, cname_begin; + /* If non-0, has been allocated using . */
package/adns/adns-1.4-cnamechain.patch line 86
Quoted 10 lines
package/adns/adns-1.4-cnamechain.patch new file +10
-0+ ++ int cname_alias_hops_left; ++ /* The number of cname alias hops we will allow */ ++ + vbuf search_vb; + int search_origlen, search_pos, search_doneabs; + /* Used by the searching algorithm. The query domain in textual form +diff -Naur adns-1.4.org/src/internal.h.orig adns-1.4/src/internal.h.orig +--- adns-1.4.org/src/internal.h.orig 1970-01-01 02:00:00.000000000 +0200 ++++ adns-1.4/src/internal.h.orig 2006-04-08 17:36:57.000000000 +0300
This file is redundant.
[snip]
Quoted 25 lines
package/adns/adns-1.4-cnamechain.patch new file +25
-0+diff -Naur adns-1.4.org/src/query.c adns-1.4/src/query.c +--- adns-1.4.org/src/query.c 2013-01-02 19:55:38.931192468 +0200 ++++ adns-1.4/src/query.c 2013-01-02 19:55:47.131331642 +0200 +@@ -63,6 +63,8 @@ + + qu->cname_dgram= 0; + qu->cname_dglen= qu->cname_begin= 0; ++ /* Allow CNAME chains up to some sane limit */ ++ qu->cname_alias_hops_left = 10; + + adns__vbuf_init(&qu->search_vb); + qu->search_origlen= qu->search_pos= qu->search_doneabs= 0; +diff -Naur adns-1.4.org/src/reply.c adns-1.4/src/reply.c +--- adns-1.4.org/src/reply.c 2013-01-02 19:55:38.936195603 +0200 ++++ adns-1.4/src/reply.c 2013-01-02 19:55:47.134333524 +0200 +@@ -190,12 +190,13 @@ + if (qu->flags & adns_qf_cname_forbid) { + adns__query_fail(qu,adns_s_prohibitedcname); + return; +- } else if (qu->cname_dgram) { /* Ignore second and subsequent CNAME(s) */ ++ } else if (qu->cname_dgram && --(qu->cname_alias_hops_left) <= 0) { /* Don't follow "too long" CNAME chains */ + adns__debug(ads,serv,qu,"allegedly canonical name %s" +- " is actually alias for %s", qu->answer->cname, ++ " is actually alias for %s and aliases too deep", ++ qu->answer->cname,
package/adns/adns-1.4-cnamechain.patch line 882
Quoted 10 lines
package/adns/adns-1.4-cnamechain.patch new file +10
-0+ adns__diag_domain(ads,serv,qu, &qu->vb, + dgram,dglen,rdstart)); +- adns__query_fail(qu,adns_s_prohibitedcname); ++ adns__query_fail(qu,adns_s_norecurse); + return; + } else if (wantedrrs) { /* Ignore CNAME(s) after RR(s). */ + adns__debug(ads,serv,qu,"ignoring CNAME (to %s) coexisting with RR", +diff -Naur adns-1.4.org/src/reply.c.orig adns-1.4/src/reply.c.orig +--- adns-1.4.org/src/reply.c.orig 1970-01-01 02:00:00.000000000 +0200 ++++ adns-1.4/src/reply.c.orig 2006-04-08 17:36:57.000000000 +0300
This file is redundant.
[snip]
package/adns/adns-1.4-destdir.patch line 2
Quoted 8 lines
package/adns/adns-1.4-destdir.patch new file +2
-0@@ -0,0 +1,54 @@ +Fix installation directory +Upstream-Status: Pending
Is this a patch you wrote yourself or a patch from somewhere else? In
either case, it requires your Signed-off-by.
[snip]
package/adns/adns-1.4-ipv6.patch line 2
Quoted 8 lines
package/adns/adns-1.4-ipv6.patch new file +2
-0@@ -0,0 +1,2725 @@ +Add IPv6 support +Upstream-Status: Pending
Ditto.
Also, this looks like a feature patch, not a cross-build patch, so we
normally would not include it in buildroot...
Quoted 4 lines
package/adns/adns-1.4-ipv6.patch new file +4
-0+ +diff --git a/Makefile b/Makefile +index 5ba3e19..a87bc87 100644 +--- a/Makefile
package/adns/adns-1.4-ipv6.patch line 16
Quoted 10 lines
package/adns/adns-1.4-ipv6.patch new file +10
-0++++ b/Makefile +@@ -56,9 +56,9 @@ dist_tmp=dist_tmp/adns-$(DISTVERSION) + dist: distprep + rm -rf dist_tmp* + mkdir dist_tmp $(dist_tmp) +- find \( -name CVS -o -name dist_tmp* \) -prune -o -type d -print | \ ++ find . \( -name CVS -o -name dist_tmp* \) -prune -o -type d -print | \ + sed -e 's#.*#mkdir -p $(dist_tmp)/&#' | sh +- find \( -name CVS -o -name dist_tmp* \) -prune -o -type f -print | \ ++ find . \( -name CVS -o -name dist_tmp* \) -prune -o -type f -print | \
These have nothing to do with IPv6, and anyway pointless.
Quoted 6 lines
package/adns/adns-1.4-ipv6.patch new file +6
-0+ sed -e 's#.*#ln & $(dist_tmp)/&#' | sh + $(MAKE) -C dist_tmp/adns-$(DISTVERSION) distclean + cd dist_tmp && tar cf ../$(dist_tmp).tar `basename $(dist_tmp)` +diff --git a/Makefile.in b/Makefile.in +index 6e2e449..0babf0e 100644 +--- a/Makefile.in
package/adns/adns-1.4-ipv6.patch line 32
Quoted 10 lines
package/adns/adns-1.4-ipv6.patch new file +10
-0++++ b/Makefile.in +@@ -56,9 +56,9 @@ dist_tmp=dist_tmp/adns-$(DISTVERSION) + dist: distprep + rm -rf dist_tmp* + mkdir dist_tmp $(dist_tmp) +- find \( -name CVS -o -name dist_tmp* \) -prune -o -type d -print | \ ++ find . \( -name CVS -o -name dist_tmp* \) -prune -o -type d -print | \ + sed -e 's#.*#mkdir -p $(dist_tmp)/&#' | sh +- find \( -name CVS -o -name dist_tmp* \) -prune -o -type f -print | \ ++ find . \( -name CVS -o -name dist_tmp* \) -prune -o -type f -print | \
Ditto.
Quoted 61 lines
package/adns/adns-1.4-ipv6.patch new file +61
-0+ sed -e 's#.*#ln & $(dist_tmp)/&#' | sh + $(MAKE) -C dist_tmp/adns-$(DISTVERSION) distclean + cd dist_tmp && tar cf ../$(dist_tmp).tar `basename $(dist_tmp)` +diff --git a/client/adh-main.c b/client/adh-main.c +index b6f3bd4..f2032ec 100644 +--- a/client/adh-main.c ++++ b/client/adh-main.c +@@ -91,6 +91,7 @@ void of_type(const struct optioninfo *oi, const char *arg, const char *arg2) { + { adns_r_rp, "rp" }, + { adns_r_srv, "srv" }, + { adns_r_addr, "addr" }, ++ { adns_r_srv, "srv" }, + + /* types with only one version */ + { adns_r_cname, "cname" }, +@@ -99,6 +100,7 @@ void of_type(const struct optioninfo *oi, const char *arg, const char *arg2) { + + /* raw versions */ + { adns_r_a, "a" }, ++ { adns_r_aaaa, "aaaa" }, + { adns_r_ns_raw, "ns-" }, + { adns_r_soa_raw, "soa-" }, + { adns_r_ptr_raw, "ptr-" }, +diff --git a/client/adh-opts.c b/client/adh-opts.c +index 08310e0..7b17c89 100644 +--- a/client/adh-opts.c ++++ b/client/adh-opts.c +@@ -32,6 +32,8 @@ int ov_verbose= 0; + adns_rrtype ov_type= adns_r_none; + int ov_search=0, ov_qc_query=0, ov_qc_anshost=0, ov_qc_cname=1; + int ov_tcp=0, ov_cname=0, ov_format=fmt_default; ++int ov_ipflags=0; ++int ov_ip6mapped=0; + char *ov_id= 0; + struct perqueryflags_remember ov_pqfr = { 1,1,1, tm_none }; + +@@ -114,6 +116,16 @@ static const struct optioninfo perquery_options[]= { + { ot_value, "CNAME ok for query domain, but not in RRs (default)", + "Cs", "cname-ok", &ov_cname, 0 }, + ++ { ot_desconly, "per-query IPv6 mode:" }, ++ { ot_value, "Ask only for IPv6 addresses", ++ "I6", "ip6-only", &ov_ipflags, adns_qf_ip6 }, ++ { ot_value, "Ask only for IPv4 addresses", ++ "I4", "ip4-only", &ov_ipflags, adns_qf_ip4 }, ++ { ot_value, "Ask for both IPv4 and IPv6 addresses (default)", ++ "IX", "ipv6-mixed", &ov_ipflags, adns_qf_ip4|adns_qf_ip6 }, ++ { ot_value, "Ask for both IPv4 and IPv6 addresses, using IPv4-mapped IPv6 addresses", ++ "IM", "ipv6-mapped", &ov_ip6mapped, adns_qf_ip6mapped }, ++ + { ot_desconly, "asynchronous/pipe mode options:" }, + { ot_funcarg, "Set <id>, default is decimal sequence starting 0", + 0, "asynch-id", 0,0, &of_asynch_id, "id" }, +diff --git a/client/adh-query.c b/client/adh-query.c +index 125bb33..2186004 100644 +--- a/client/adh-query.c ++++ b/client/adh-query.c +@@ -92,24 +92,37 @@ static void prep_query(struct query_node **qun_r, int *quflags_r) { + (ov_qc_query ? adns_qf_quoteok_query : 0) | + (ov_qc_anshost ? adns_qf_quoteok_anshost : 0) | + (ov_qc_cname ? 0 : adns_qf_quoteok_cname) |
package/adns/adns-1.4-ipv6.patch line 103
Quoted 10 lines
package/adns/adns-1.4-ipv6.patch new file +10
-0++ ov_ipflags | ov_ip6mapped | + ov_cname, + + *qun_r= qun; + } + ++static int a2addr(adns_rr_addr *rr, const char *addr) { ++ char *p; ++ if (strchr(addr, ':')) { ++ memset(&rr->addr.inet6, 0, sizeof(rr->addr.inet6));
Is addr.inet6 defined if the toolchain doesn't have IPv6 support? Same
for AF_INET6.
Quoted 79 lines
package/adns/adns-1.4-ipv6.patch new file +79
-0++ rr->addr.sa.sa_family = AF_INET6; ++ p = (char *) &rr->addr.inet6.sin6_addr; ++ } ++ else { ++ memset(&rr->addr.inet, 0, sizeof(rr->addr.inet)); ++ rr->addr.sa.sa_family = AF_INET; ++ p = (char *) &rr->addr.inet.sin_addr; ++ } ++ return inet_pton(rr->addr.sa.sa_family, addr, p) > 0; ++} ++ + void of_ptr(const struct optioninfo *oi, const char *arg, const char *arg2) { + struct query_node *qun; + int quflags, r; +- struct sockaddr_in sa; +- +- memset(&sa,0,sizeof(sa)); +- sa.sin_family= AF_INET; +- if (!inet_aton(arg,&sa.sin_addr)) usageerr("invalid IP address %s",arg); ++ adns_rr_addr rr; + ++ if (!a2addr(&rr, arg)) usageerr("invalid IP address %s",arg); + prep_query(&qun,&quflags); + qun->owner= xstrsave(arg); + r= adns_submit_reverse(ads, +- (struct sockaddr*)&sa, ++ &rr.addr.sa, + ov_type == adns_r_none ? adns_r_ptr : ov_type, + quflags, + qun, +@@ -122,17 +135,14 @@ void of_ptr(const struct optioninfo *oi, const char *arg, const char *arg2) { + void of_reverse(const struct optioninfo *oi, const char *arg, const char *arg2) { + struct query_node *qun; + int quflags, r; +- struct sockaddr_in sa; +- +- memset(&sa,0,sizeof(sa)); +- sa.sin_family= AF_INET; +- if (!inet_aton(arg,&sa.sin_addr)) usageerr("invalid IP address %s",arg); ++ adns_rr_addr rr; + ++ if (!a2addr(&rr, arg)) usageerr("invalid IP address %s",arg); + prep_query(&qun,&quflags); + qun->owner= xmalloc(strlen(arg) + strlen(arg2) + 2); + sprintf(qun->owner, "%s %s", arg,arg2); + r= adns_submit_reverse_any(ads, +- (struct sockaddr*)&sa, arg2, ++ &rr.addr.sa, arg2, + ov_type == adns_r_none ? adns_r_txt : ov_type, + quflags, + qun, +diff --git a/client/adnshost.h b/client/adnshost.h +index fcc96a3..7e2341a 100644 +--- a/client/adnshost.h ++++ b/client/adnshost.h +@@ -81,6 +81,8 @@ extern int ov_verbose; + extern adns_rrtype ov_type; + extern int ov_search, ov_qc_query, ov_qc_anshost, ov_qc_cname; + extern int ov_tcp, ov_cname, ov_format; ++extern int ov_ipflags; ++extern int ov_ip6mapped; + extern char *ov_id; + extern struct perqueryflags_remember ov_pqfr; + +diff --git a/client/adnstest.c b/client/adnstest.c +index 550cf27..ae70285 100644 +--- a/client/adnstest.c ++++ b/client/adnstest.c +@@ -119,13 +119,16 @@ static const adns_rrtype defaulttypes[]= { + adns_r_ptr_raw, + adns_r_hinfo, + adns_r_mx_raw, ++ adns_r_srv_raw, + adns_r_txt, + adns_r_rp_raw, ++ adns_r_aaaa, /* Does the order matter? */ + + adns_r_addr, + adns_r_ns,
package/adns/adns-1.4-ipv6.patch line 192
Quoted 10 lines
package/adns/adns-1.4-ipv6.patch new file +10
-0+ adns_r_ptr, + adns_r_mx, ++ adns_r_srv, + + adns_r_soa, + adns_r_rp, +diff --git a/regress/case-connfail.sys b/regress/case-connfail.sys +index b62923b..2064368 100644 +--- a/regress/case-connfail.sys ++++ b/regress/case-connfail.sys
If we keep this patch in buildroot, I wouldn't include the regression
test changes. We anyway don't run the tests.
[snip]
Quoted 1 line
package/adns/adns-1.4-ipv6.patch new file +1
-0+diff --git a/regress/case-flags10.sys b/regress/case-flags10.sys
[snip]
Quoted 1 line
+diff --git a/regress/case-longdom1.sys b/regress/case-longdom1.sys
[snip]
Quoted 1 line
+diff --git a/regress/case-longdomsrch0.sys b/regress/case-longdomsrch0.sys
[snip]
Quoted 1 line
+diff --git a/regress/case-longlab1.sys b/regress/case-longlab1.sys
[snip]
Quoted 1 line
+diff --git a/regress/case-tcpmultipart.sys b/regress/case-tcpmultipart.sys
[snip]
Quoted 1 line
+diff --git a/regress/case-timeout.sys b/regress/case-timeout.sys
[snip]
Quoted 1 line
+diff --git a/regress/case-unknownq.sys b/regress/case-unknownq.sys
[snip]
Quoted 1 line
+diff --git
a/regress/hcommon.cb/regress/hcommon.c
[snip]
Quoted 1 line
+diff --git a/regress/hcommon.c.m4 b/regress/hcommon.c.m4
[snip]
Quoted 1 line
+diff --git
a/regress/hplayback.cb/regress/hplayback.c
[snip]
Quoted 1 line
+diff --git a/regress/hplayback.c.m4 b/regress/hplayback.c.m4
[snip]
Quoted 1 line
+diff --git
a/regress/hrecord.cb/regress/hrecord.c
[snip]
Quoted 1 line
+diff --git a/regress/hsyscalls.i4 b/regress/hsyscalls.i4
[snip]
All of the above can be removed...
package/adns/adns-1.4-ipv6.patch line 933
Quoted 11 lines
package/adns/adns-1.4-ipv6.patch new file +11
-0+diff --git a/src/adns.h b/src/adns.h +index 34f9f49..aad05fd 100644 +--- a/src/adns.h ++++ b/src/adns.h +@@ -71,6 +71,10 @@ + extern "C" { /* I really dislike this - iwj. */ + #endif + ++#ifndef AF_INET6 ++#include "adns-in6fake.h" ++#endif
Ah, I guess this answers my question about addr.inet6 being defined...
Quoted 2 lines
++
+ /* All structin_addranywhere in adns are in NETWORK byte order. */
[snip]
Rest of the patch should stay (except for it being a feature-adding patch).
BTW, is this patch really 4 years old? Does that imply that adns is in
fact dead?
package/adns/adns-1.4-rh514838.patch line 1
Quoted 7 lines
package/adns/adns-1.4-rh514838.patch new file +1
-0@@ -0,0 +1,26 @@ +Fixes Bug 514838
A bit more explanation would be useful :-) And add your Sob.
Quoted 33 lines
package/adns/adns-1.4-rh514838.patch new file +25
-0+ +Upstream-Status: Pending +URL: https://bugzilla.redhat.com/show_bug.cgi?id=514838 + +diff -up adns-1.4/src/general.c.rh514838 adns-1.4/src/general.c +--- adns-1.4/src/general.c.rh514838 2006-04-08 16:36:57.000000000 +0200 ++++ adns-1.4/src/general.c 2009-08-06 13:55:06.752562767 +0200 +@@ -267,6 +267,8 @@ static const struct sinfo { + SINFO( nodata, "No such data" ) + }; + ++static const char *unknown_error_str = "unknown error code"; ++ + static int si_compar(const void *key, const void *elem) { + const adns_status *st= key; + const struct sinfo *si= elem; +@@ -283,7 +285,7 @@ const char *adns_strerror(adns_status st + const struct sinfo *si; + + si= findsinfo(st); +- return si->string; ++ return (si == NULL) ? unknown_error_str : si->string; + } + + const char *adns_errabbrev(adns_status st) {package/adns/adns.mk new file +2
-0@@ -0,0 +1,15 @@ +############################################################# +#
package/adns/adns.mk line 12
Quoted 10 lines
package/adns/adns.mk new file +10
-0+# adns +# +############################################################# + +ADNS_VERSION = 1.4 +ADNS_SOURCE = adns-$(ADNS_VERSION).tar.gz +ADNS_SITE = http://www.chiark.greenend.org.uk/~ian/adns/ftp/ +ADNS_AUTORECONF = YES +ADNS_INSTALL_STAGING = YES +ADNS_CONF_OPT += --enable-dynamic=elf
Shouldn't this be in an ifeq ($(BR2_PREFER_STATIC_LIB),)?
package/adns/adns.mk line 15
Quoted 3 lines
package/adns/adns.mk new file +3
-0+ +$(eval $(autotools-package)) +
Redundant empty line at end of file.
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 new package: adns
23.2.2013 19:48, Arnout Vandecappelle kirjoitti:
Quoted 6 lines · Stefan Fr?berg
Quoted 4 lines
GNU adns
Advanced, easy to use, asynchronous-capable DNS client library and utilities.
Quoted 8 lines
It's not really necessary to repeat the help text in the commit message.
Quoted 3 lines
adns is a resolver library for C (and C++) programs, and a collection of useful DNS resolver utilities.
Isn't this just repeating the above?
Ok
Quoted 15 lines
Quoted 2 lines
Signed-off-by Stefan Fr?berg <[email protected]>[snip]
package/adns/adns-1.4-cnamechain.patch line 1
Quoted 8 lines
package/adns/adns-1.4-cnamechain.patch new file +1
-0@@ -0,0 +1,1275 @@ +[ADNS] Re: CNAME chainsCould you start the patch with a link to the place where you found
it, and your Signed-off-by?
Official Gentoo patch. Ok..
Quoted 4 lines
This file is redundant.
[snip]
Quoted 13 lines
package/adns/adns-1.4-destdir.patch line 2
Quoted 9 lines
package/adns/adns-1.4-destdir.patch new file +2
-0@@ -0,0 +1,54 @@ +Fix installation directory +Upstream-Status: PendingIs this a patch you wrote yourself or a patch from somewhere else? In
either case, it requires your Signed-off-by.
From that suse page like I told previously. Ok.
[snip]
Quoted 14 lines
[snip]
package/adns/adns-1.4-ipv6.patch line 2
Quoted 9 lines
package/adns/adns-1.4-ipv6.patch new file +2
-0@@ -0,0 +1,2725 @@ +Add IPv6 support +Upstream-Status: PendingDitto.
Quoted 3 lines
Also, this looks like a feature patch, not a cross-build patch, so we
normally would not include it in buildroot...
Ok. Then these should be removed too from then current git
avahi/avahi-ipv6only.patchavahi/avahi-optional-ipv6.patchiproute2/iproute2-optional-ipv6.patchlibeXosip2/libeXosip2-fix-non-ipv6-build.patchlibglib2/libglib2-optional-ipv6.patchx11vnc/x11vnc-ipv6.patch
Quoted 21 lines
Quoted 8 lines
package/adns/adns-1.4-ipv6.patch new file +8
-0+ +diff --git a/Makefile b/Makefile +index 5ba3e19..a87bc87 100644 +--- a/Makefile ++++ b/Makefile +@@ -56,9 +56,9 @@ dist_tmp=dist_tmp/adns-$(DISTVERSION) + dist: distprep + rm -rf dist_tmp*package/adns/adns-1.4-ipv6.patch
Quoted 10 lines
package/adns/adns-1.4-ipv6.patch new file +6
-4+ mkdir dist_tmp $(dist_tmp) +- find \( -name CVS -o -name dist_tmp* \) -prune -o -type d -print | \ ++ find . \( -name CVS -o -name dist_tmp* \) -prune -o -type d -print | \ + sed -e 's#.*#mkdir -p $(dist_tmp)/&#' | sh +- find \( -name CVS -o -name dist_tmp* \) -prune -o -type f -print | \ ++ find . \( -name CVS -o -name dist_tmp* \) -prune -o -type f -print | \These have nothing to do with IPv6, and anyway pointless.
[snip]
Quoted 9 lines
[snip]
Rest of the patch should stay (except for it being a feature-adding
patch).BTW, is this patch really 4 years old? Does that imply that adns is
in fact dead?
Might be, but so are many other packages in buildroot too. Latest stable release of matchbox for example, is
from 2007.
Official debian patch. Can be find from here:
http://people.debian.org/~lucab/deb/adns/adns-ipv6.patch
Quoted 12 lines
package/adns/adns-1.4-rh514838.patch line 1
Quoted 9 lines
package/adns/adns-1.4-rh514838.patch new file +1
-0@@ -0,0 +1,26 @@ +Fixes Bug 514838A bit more explanation would be useful :-) And add your Sob.
Official Fedora patch. Ok
Quoted 48 lines
Quoted 35 lines
package/adns/adns-1.4-rh514838.patch new file +10
-0+ +Upstream-Status: Pending +URL: https://bugzilla.redhat.com/show_bug.cgi?id=514838 + +diff -up adns-1.4/src/general.c.rh514838 adns-1.4/src/general.c +--- adns-1.4/src/general.c.rh514838 2006-04-08 16:36:57.000000000 +0200 ++++ adns-1.4/src/general.c 2009-08-06 13:55:06.752562767 +0200 +@@ -267,6 +267,8 @@ static const struct sinfo { + SINFO( nodata, "No suchdata" )
+ };package/adns/adns-1.4-rh514838.patch new file +15
-0+ ++static const char *unknown_error_str = "unknown error code"; ++ + static int si_compar(const void *key, const void *elem) { + const adns_status *st= key; + const struct sinfo *si= elem; +@@ -283,7 +285,7 @@ const char *adns_strerror(adns_status st + const struct sinfo *si; + + si= findsinfo(st); +- return si->string; ++ return (si == NULL) ? unknown_error_str : si->string; + } + + const char *adns_errabbrev(adns_status st) {package/adns/adns.mk new file +2
-0@@ -0,0 +1,15 @@ +############################################################# +#package/adns/adns.mk line 12
Quoted 10 lines
package/adns/adns.mk new file +10
-0+# adns +# +############################################################# + +ADNS_VERSION = 1.4 +ADNS_SOURCE = adns-$(ADNS_VERSION).tar.gz +ADNS_SITE = http://www.chiark.greenend.org.uk/~ian/adns/ftp/ +ADNS_AUTORECONF = YES +ADNS_INSTALL_STAGING = YES +ADNS_CONF_OPT += --enable-dynamic=elfShouldn't this be in an ifeq ($(BR2_PREFER_STATIC_LIB),)?
Quoted 7 lines
package/adns/adns.mk line 15
Quoted 3 lines
package/adns/adns.mk new file +3
-0+ +$(eval $(autotools-package)) +Redundant empty line at end of file.
Ok
Thanks!
Regards
Stefan
PATCH 1/1 new package: adns
On 23/02/13 21:27, Stefan Fr?berg wrote:
[snip]
Quoted 16 lines
Quoted 12 lines
package/adns/adns-1.4-ipv6.patch line 2
Quoted 9 lines
package/adns/adns-1.4-ipv6.patch new file +2
-0@@ -0,0 +1,2725 @@ +Add IPv6 support +Upstream-Status: PendingDitto.
Quoted 3 lines
Also, this looks like a feature patch, not a cross-build patch, so we
normally would not include it in buildroot...
Quoted 8 lines
Ok. Then these should be removed too from then current git
avahi/avahi-ipv6only.patchavahi/avahi-optional-ipv6.patchiproute2/iproute2-optional-ipv6.patchlibeXosip2/libeXosip2-fix-non-ipv6-build.patchlibglib2/libglib2-optional-ipv6.patchx11vnc/x11vnc-ipv6.patch
All these patches make it possible to build these packages in
environments that don't have IPv6 support. I.e., they fix build errors. Sometimes the build error is fixed by adding 'depends on BR2_INET_IPV6', but fixing the package is of course better.
adns-1.4-ipv6.patch on the other hand adds support for IPv6. adns will
build and run fine on all toolchains without this patch.
Given that it's a huge patch as well, I tend to say we wouldn't want to
carry it.
However, the situation is not that black and white. With a dead
upstream, the patch being maintained by Debian, and IPv6 functionality being quite essential, we could consider taking it.
But there's a very easy workaround:
ADNS_PATCH = http://people.debian.org/~lucab/deb/adns/adns-ipv6.patch
and nobody will complain :-)
(Note that that won't work until patchwork 217122 is merged.)
[snip]
Quoted 7 lines
Quoted 3 lines
BTW, is this patch really 4 years old? Does that imply that adns is
in fact dead?Might be, but so are many other packages in buildroot too. Latest stable release of matchbox for example, is
from 2007.
I didn't mean to imply that we shouldn't take it in buildroot. I was
just surprised.
I took a look at the website and it looks like upstream is really dead.
Regards,
Arnout
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 new package: adns
24.2.2013 0:40, Arnout Vandecappelle kirjoitti:
Quoted 42 lines · Stefan Fr?berg
[snip]
Quoted 16 lines
Quoted 12 lines
package/adns/adns-1.4-ipv6.patch line 2
Quoted 9 lines
package/adns/adns-1.4-ipv6.patch new file +2
-0@@ -0,0 +1,2725 @@ +Add IPv6 support +Upstream-Status: PendingDitto.
Quoted 3 lines
Also, this looks like a feature patch, not a cross-build patch, so we
normally would not include it in buildroot...Quoted 8 lines
Ok. Then these should be removed too from then current git
avahi/avahi-ipv6only.patchavahi/avahi-optional-ipv6.patchiproute2/iproute2-optional-ipv6.patchlibeXosip2/libeXosip2-fix-non-ipv6-build.patchlibglib2/libglib2-optional-ipv6.patchx11vnc/x11vnc-ipv6.patchAll these patches make it possible to build these packages in
environments that don't have IPv6 support. I.e., they fix build errors. Sometimes the build error is fixed by adding 'depends onBR2_INET_IPV6', but fixing the package is of course better.adns-1.4-ipv6.patch on the other hand adds support for IPv6. adns
will build and run fine on all toolchains without this patch.Given that it's a huge patch as well, I tend to say we wouldn't want
to carry it.However, the situation is not that black and white. With a dead
upstream, the patch being maintained by Debian, and IPv6 functionality being quite essential, we could consider taking it.
Quoted 6 lines
But there's a very easy workaround:
ADNS_PATCH= http://people.debian.org/~lucab/deb/adns/adns-ipv6.patchand nobody will complain :-)
That would be good :-)
And that ipv6 patch is also nicely -p1 level too.
That patch download mechanism needs really a support for multiple patch levels.
Otherwise it's usefullness will only allow -p1 level patches to be applied from Net .
For example it could first try with -p0, then if failed with -p1. Also fuzz level could start from -F3 (default in patch?) and go up until -F4, -F5 or maybe even -F6.
I think this is what gentoo patch framework does and that's why their patches are happily mixed and matched.
Quoted 8 lines
(Note that that won't work until patchwork 217122 is merged.)
[snip]
Quoted 4 lines
Quoted 3 lines
BTW, is this patch really 4 years old? Does that imply that adns is
in fact dead?
Quoted 9 lines
Quoted 3 lines
Might be, but so are many other packages in buildroot too. Latest stable release of matchbox for example, is
from 2007.I didn't mean to imply that we shouldn't take it in buildroot. I was
just surprised.I took a look at the website and it looks like upstream is really dead.
That would explain why no response from upstream to my messages. Originally I wanted this package to be optional dependency for Baruch's wireshark
(which seems to be in good condition now).
And now I just noticed that wireshark added option in 2009 to use another asynchronous dns implementation too than adns, c-ares.
So latest wireshark can still use either adns or c-ares but adns seems really dead now.
Damn :-(
Regards
Stefan
PATCH 1/1 new package: adns
In reply to Arnout VandecappelleDear Arnout Vandecappelle,
Quoted 2 lines · Arnout Vandecappelle
BTW, is this patch really 4 years old? Does that imply that adns is in
fact dead?
The last release (1.4) was apparently published in 2006, according to the dates in http://www.chiark.greenend.org.uk/~ian/adns/ftp/. So I guess we can call that a pretty much dead project indeed. See also the mailing list archives:
http://www.chiark.greenend.org.uk/pipermail/adns-discuss/ and
http://www.chiark.greenend.org.uk/pipermail/adns-announce/ (empty) for more details.
Best regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com