Skip to contentSkip to conversation

WARNING: at fs/btrfs/inode.c:2165 btrfs_orphan_commit_root+0xcb/0xdf()

DISCUSSION Marc MERLIN 3 participants 5 messages Feb 25, 2013 – Feb 27, 2013 Btrfs file system

lore
Share & tools
lore
#0 lore raw

Is this useful to anyone?

Got this after a crash/reboot:

	if (block_rsv) {
		WARN_ON(block_rsv->size > 0);  <<<<<<<<<<<<<<<<<<<<<<
		btrfs_free_block_rsv(root, block_rsv);
	}
------------[ cut here ]------------
WARNING: at fs/btrfs/inode.c:2165 btrfs_orphan_commit_root+0xcb/0xdf()
Hardware name: 2429A78
Modules linked in: tun ppdev cpufreq_userspace cpufreq_stats cpufreq_conservative cpufreq_powersave rfcomm bnep autofs4 pci_stub vboxpci(O) vboxnetadp(O) vboxnetflt(O) vboxdrv(O) binfmt_misc uinput nfsd auth_rpcgss nfs_acl nfs lockd fscache sunrpc fuse configs parport_pc lp parport input_polldev loop firewire_sbp2 firewire_core crc_itu_t ecryptfs snd_hda_codec_realtek uvcvideo videobuf2_vmalloc videobuf2_memops videobuf2_core videodev media btusb bluetooth hid_generic usbhid hid arc4 coretemp kvm_intel kvm iwldvm ghash_clmulni_intel mac80211 snd_hda_intel snd_hda_codec snd_hwdep snd_pcm_oss snd_mixer_oss iTCO_wdt snd_pcm iTCO_vendor_support snd_page_alloc snd_seq_midi snd_seq_midi_event snd_rawmidi snd_seq battery thinkpad_acpi tpm_tis nvram ac tpm snd_seq_device tpm_bios snd_timer snd evdev iwlwifi wmi cfg80211 sdhci_pci i915 rfkill sdhci microcode mmc_core video pcspkr psmouse lpc_ich e1000e soundcore serio_raw button mei drm_kms_helper drm xhci_hcd ehci_hcd i2c_i801 i2c_algo_bit acpi_cpufreq mperf i2c_core usbcore usb_common processor raid456 multipath dm_snapshot dm_mirror dm_region_hash dm_log dm_crypt dm_mod async_raid6_recov async_pq async_xor raid6_pq async_memcpy async_tx xor blowfish_x86_64 blowfish_common ecb crc32c_intel aesni_intel xts aes_x86_64 lrw gf128mul ablk_helper cryptd thermal thermal_sys
Pid: 500, comm: btrfs-transacti Tainted: G           O 3.7.8-amd64-preempt-20130222 #1
Call Trace:
 [<ffffffff81040ed4>] warn_slowpath_common+0x7e/0x96
 [<ffffffff811f75c5>] ? alloc_extent_state+0x59/0xa4
 [<ffffffff81040f01>] warn_slowpath_null+0x15/0x17
 [<ffffffff811e972f>] btrfs_orphan_commit_root+0xcb/0xdf
 [<ffffffff811e3954>] commit_fs_roots.isra.24+0x99/0x153
 [<ffffffff814c1ed6>] ? _raw_spin_lock+0x1b/0x1f
 [<ffffffff814c2059>] ? _raw_spin_unlock+0x27/0x32
 [<ffffffff811e47e8>] btrfs_commit_transaction+0x45a/0x954
 [<ffffffff8105d4be>] ? add_wait_queue+0x44/0x44
 [<ffffffff811de8a6>] transaction_kthread+0xe7/0x18a
 [<ffffffff811de7bf>] ? try_to_freeze+0x33/0x33
 [<ffffffff8105cc31>] kthread+0x88/0x90
 [<ffffffff8105cba9>] ? kthread_freezable_should_stop+0x39/0x39
 [<ffffffff814c6b3c>] ret_from_fork+0x7c/0xb0
 [<ffffffff8105cba9>] ? kthread_freezable_should_stop+0x39/0x39
---[ end trace ee93ff454aca9d81 ]---
Signature · 4 lines
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/  
#1 lore raw
Quoted 2 lines · Marc MERLIN

Is this useful to anyone?

Hi Marc,

Thanks for the report, of course they're useful.

Could you please also show us your workloads and it'd be better to know how to reproduce this?

thanks,
liubo

Quoted 40 lines

Got this after a crash/reboot:

	if (block_rsv) {
		WARN_ON(block_rsv->size > 0);  <<<<<<<<<<<<<<<<<<<<<<
		btrfs_free_block_rsv(root, block_rsv);
	}
------------[ cut here ]------------
WARNING: at fs/btrfs/inode.c:2165 btrfs_orphan_commit_root+0xcb/0xdf()
Hardware name: 2429A78
Modules linked in: tun ppdev cpufreq_userspace cpufreq_stats cpufreq_conservative cpufreq_powersave rfcomm bnep autofs4 pci_stub vboxpci(O) vboxnetadp(O) vboxnetflt(O) vboxdrv(O) binfmt_misc uinput nfsd auth_rpcgss nfs_acl nfs lockd fscache sunrpc fuse configs parport_pc lp parport input_polldev loop firewire_sbp2 firewire_core crc_itu_t ecryptfs snd_hda_codec_realtek uvcvideo videobuf2_vmalloc videobuf2_memops videobuf2_core videodev media btusb bluetooth hid_generic usbhid hid arc4 coretemp kvm_intel kvm iwldvm ghash_clmulni_intel mac80211 snd_hda_intel snd_hda_codec snd_hwdep snd_pcm_oss snd_mixer_oss iTCO_wdt snd_pcm iTCO_vendor_support snd_page_alloc snd_seq_midi snd_seq_midi_event snd_rawmidi snd_seq battery thinkpad_acpi tpm_tis nvram ac tpm snd_seq_device tpm_bios snd_timer snd evdev iwlwifi wmi cfg80211 sdhci_pci i915 rfkill sdhci microcode mmc_core video pcspkr psmouse lpc_ich e1000e soundcore serio_raw button mei drm_kms_helper drm xhci_hcd ehci_hcd i2c_i801 i2c_a!
 lgo_bit acpi_cpufreq mperf i2c_core usbcore usb_common processor raid456 multipath dm_snapshot dm_mirror dm_region_hash dm_log dm_crypt dm_mod async_raid6_recov async_pq async_xor raid6_pq async_memcpy async_tx xor blowfish_x86_64 blowfish_common ecb crc32c_intel aesni_intel xts aes_x86_64 lrw gf128mul ablk_helper cryptd thermal thermal_sys
Pid: 500, comm: btrfs-transacti Tainted: G           O 3.7.8-amd64-preempt-20130222 #1
Call Trace:
 [<ffffffff81040ed4>] warn_slowpath_common+0x7e/0x96
 [<ffffffff811f75c5>] ? alloc_extent_state+0x59/0xa4
 [<ffffffff81040f01>] warn_slowpath_null+0x15/0x17
 [<ffffffff811e972f>] btrfs_orphan_commit_root+0xcb/0xdf
 [<ffffffff811e3954>] commit_fs_roots.isra.24+0x99/0x153
 [<ffffffff814c1ed6>] ? _raw_spin_lock+0x1b/0x1f
 [<ffffffff814c2059>] ? _raw_spin_unlock+0x27/0x32
 [<ffffffff811e47e8>] btrfs_commit_transaction+0x45a/0x954
 [<ffffffff8105d4be>] ? add_wait_queue+0x44/0x44
 [<ffffffff811de8a6>] transaction_kthread+0xe7/0x18a
 [<ffffffff811de7bf>] ? try_to_freeze+0x33/0x33
 [<ffffffff8105cc31>] kthread+0x88/0x90
 [<ffffffff8105cba9>] ? kthread_freezable_should_stop+0x39/0x39
 [<ffffffff814c6b3c>] ret_from_fork+0x7c/0xb0
 [<ffffffff8105cba9>] ? kthread_freezable_should_stop+0x39/0x39
---[ end trace ee93ff454aca9d81 ]---
Signature · 8 lines
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/  
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
Quoted 7 lines · Liu Bo
Quoted 2 lines · Marc MERLIN

Is this useful to anyone?

Hi Marc,

Thanks for the report, of course they're useful.

Thanks. I wasn't sure since I haven't seen the real problem of crashes during mount due to unexpected state in replay logs being improved over the last 4 kernel versions, and I wasn't sure if they are being worked on.

Quoted 2 lines

Could you please also show us your workloads and it'd be better to know how to reproduce this?

Sure thing.

Workload is a simple laptop, where something tyipcally dies during writes and I get a full system hang because linux is unable to flush its disk queues, so in the end I power cycle.
Details here:
http://www.mail-archive.com/[email protected]/msg391505.html

As mentioned in my other mail, I do run on top of dmcrypt since I can't have an unencrypted laptop, and ecryptfs is way too slow while not supporting encryption of long filenames.

The next question is: are your write requests getting there in the order they should. My crashes and your BUG() that get triggered indicate that maybe not.

Currently, I have:

gandalfthegreat:~# cat /sys/block/sda/queue/scheduler 
noop [deadline] cfq 

That could be a problem I guess, so I'll change it to noop, just in case.

My boot is like this:
/vmlinuz-3.7.8-amd64-preempt-20130222 root=/dev/mapper/cryptroot ro rootflags=subvol=root cryptopts=source=/dev/sda4,keyscript=/sbin/cryptgetpw,discard

btrfs is mounted like so:
LABEL=btrfs_pool1 / btrfs subvol=root,defaults,compress=lzo,discard,nossd,space_cache,noatime

Is there anything else I can give?
(I'll answer on the other thread with the fsimage)

Marc

Signature · 4 lines
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/  
#3 lore raw
In reply to Marc MERLIN
Quoted 9 lines · Marc MERLIN

Is this useful to anyone?

Got this after a crash/reboot:

	if (block_rsv) {
		WARN_ON(block_rsv->size > 0);  <<<<<<<<<<<<<<<<<<<<<<
		btrfs_free_block_rsv(root, block_rsv);
	}

Fixed in btrfs-next, thanks for reporting!

Josef

#4 lore raw
Quoted 5 lines · Josef Bacik
Quoted 4 lines · Marc MERLIN

Is this useful to anyone?

Got this after a crash/reboot:

Quoted 7 lines
Quoted 5 lines
	if (block_rsv) {
		WARN_ON(block_rsv->size > 0);  <<<<<<<<<<<<<<<<<<<<<<
		btrfs_free_block_rsv(root, block_rsv);
	}

Fixed in btrfs-next, thanks for reporting!

FYI, the commit Josef mentioned is

Btrfs: cleanup orphan reservation if truncate fails
http://git.kernel.org/?p=linux/kernel/git/josef/btrfs-next.git;a=commit;h=4a7d0f6854c4a4ad1dba00a3b128a32d39b9a742

(Correct me if it is wrong.)

thanks,
liubo

Quoted 6 lines

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html