Skip to contentSkip to conversation

ioatdma: allow all channels to have irq coalescing support

PATCH In review Dave Jiang 3 participants 3 messages Feb 26, 2013 – Mar 7, 2013 dmaengine

lore
Share & tools
lore

Dave Jiang

author
#0 lore raw

PATCH 1/1 ioatdma: allow all channels to have irq coalescing support

Looks like only the RAID channels are allowed to have irq coalescing support in the existing code. Fixing that. The ioat3 cleanup code can handle memcpy ops anyways

---
 drivers/dma/ioat/dma_v3.c |   12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)
drivers/dma/ioat/dma_v3.c +3 -9
index 47588dc..368a184 100644
@@ -1268,15 +1268,9 @@ int __devinit ioat3_dma_probe(struct ioatdma_device *device, int dca)
 	}
 
 
-	if (is_raid_device) {
-		dma->device_tx_status = ioat3_tx_status;
-		device->cleanup_fn = ioat3_cleanup_event;
-		device->timer_fn = ioat3_timer_event;
-	} else {
-		dma->device_tx_status = ioat_dma_tx_status;
-		device->cleanup_fn = ioat2_cleanup_event;
-		device->timer_fn = ioat2_timer_event;
-	}
+	dma->device_tx_status = ioat3_tx_status;
+	device->cleanup_fn = ioat3_cleanup_event;
+	device->timer_fn = ioat3_timer_event;
 
 	#ifdef CONFIG_ASYNC_TX_DISABLE_PQ_VAL_DMA
 	dma_cap_clear(DMA_PQ_VAL, dma->cap_mask);
Acked-by on v1 1/1
#1 lore raw
Quoted 34 lines · Dave Jiang

Looks like only the RAID channels are allowed to have irq coalescing support
in the existing code. Fixing that. The ioat3 cleanup code can handle memcpy
ops anyways

---
drivers/dma/ioat/dma_v3.c | 12 +++---------

1 file changed, 3 insertions(+), 9 deletions(-)
drivers/dma/ioat/dma_v3.c +3 -9
index 47588dc..368a184 100644
@@ -1268,15 +1268,9 @@ int __devinit ioat3_dma_probe(struct
 ioatdma_device *device, int dca)
 	}
 
 
-	if (is_raid_device) {
-		dma->device_tx_status = ioat3_tx_status;
-		device->cleanup_fn = ioat3_cleanup_event;
-		device->timer_fn = ioat3_timer_event;
-	} else {
-		dma->device_tx_status = ioat_dma_tx_status;
-		device->cleanup_fn = ioat2_cleanup_event;
-		device->timer_fn = ioat2_timer_event;
-	}
+	dma->device_tx_status = ioat3_tx_status;
+	device->cleanup_fn = ioat3_cleanup_event;
+	device->timer_fn = ioat3_timer_event;
 
 	#ifdef CONFIG_ASYNC_TX_DISABLE_PQ_VAL_DMA
Quoted 1 line
	dma_cap_clear(DMA_PQ_VAL, dma->cap_mask);
#2 lore raw
Quoted 11 lines · Dan Williams
Quoted 7 lines · Dave Jiang

Looks like only the RAID channels are allowed to have irq coalescing support
in the existing code. Fixing that. The ioat3 cleanup code can handle memcpy
ops anyways

Applied thanks

Quoted 31 lines
Quoted 27 lines

---
drivers/dma/ioat/dma_v3.c | 12 +++---------

1 file changed, 3 insertions(+), 9 deletions(-)
drivers/dma/ioat/dma_v3.c +3 -9
index 47588dc..368a184 100644
@@ -1268,15 +1268,9 @@ int __devinit ioat3_dma_probe(struct
 ioatdma_device *device, int dca)
 	}
 
 
-	if (is_raid_device) {
-		dma->device_tx_status = ioat3_tx_status;
-		device->cleanup_fn = ioat3_cleanup_event;
-		device->timer_fn = ioat3_timer_event;
-	} else {
-		dma->device_tx_status = ioat_dma_tx_status;
-		device->cleanup_fn = ioat2_cleanup_event;
-		device->timer_fn = ioat2_timer_event;
-	}
+	dma->device_tx_status = ioat3_tx_status;
+	device->cleanup_fn = ioat3_cleanup_event;
+	device->timer_fn = ioat3_timer_event;
 
 	#ifdef CONFIG_ASYNC_TX_DISABLE_PQ_VAL_DMA
Quoted 1 line
	dma_cap_clear(DMA_PQ_VAL, dma->cap_mask);