Skip to contentSkip to conversation

clk: vt8500: Fix variable name '*prate' compile error

PATCH In review Tim Gardner 3 participants 6 messages Feb 26, 2013 – Mar 17, 2013 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: vt8500: Fix variable name '*prate' compile error

commit 72480014b86c8b51fb51c5c6a0525876055c37c7 (clk: vt8500: Fix device clock divisor calculations) introduced a compile error in the naming of a variable in vt8500_dclk_set_rate(). It looks like a simple cut and paste error.

Cc Mike Turquette <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
---
 drivers/clk/clk-vt8500.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk-vt8500.c +1 -1
index b5538bb..09c6331 100644
@@ -157,7 +157,7 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate,
 	divisor =  parent_rate / rate;
 
 	/* If prate / rate would be decimal, incr the divisor */
-	if (rate * divisor < *prate)
+	if (rate * divisor < parent_rate)
 		divisor++;
 
 	if (divisor == cdev->div_mask + 1)
Signature · 1 line
1.7.9.5
#1 lore raw

Quoting Tim Gardner (2013-02-26 09:34:12)

Quoted 7 lines

commit 72480014b86c8b51fb51c5c6a0525876055c37c7 (clk: vt8500: Fix device clock divisor calculations) introduced a compile error in the naming of a variable in vt8500_dclk_set_rate(). It looks like a simple cut and paste error.

Cc Mike Turquette <[email protected]>
Cc linux-arm-kernel at lists.infradead.org

Tim,

Thanks for the fix. I already have a fix for this issue in my clk-fixes branch. In fact I forgot to bundle this one and another mxs fix in my 3.9 pull request so I'll send a follow-up bugfix branch after 3.9-rc1 is out.

Regards,
Mike

Quoted 19 lines
---
 drivers/clk/clk-vt8500.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk-vt8500.c +1 -1
index b5538bb..09c6331 100644
@@ -157,7 +157,7 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate,
        divisor =  parent_rate / rate;
 
        /* If prate / rate would be decimal, incr the divisor */
-       if (rate * divisor < *prate)
+       if (rate * divisor < parent_rate)
                divisor++;
 
        if (divisor == cdev->div_mask + 1)
Signature · 1 line
1.7.9.5
#2 lore raw
Quoted 9 lines · Mike Turquette

Quoting Tim Gardner (2013-02-26 09:34:12)

Quoted 7 lines

commit 72480014b86c8b51fb51c5c6a0525876055c37c7 (clk: vt8500: Fix device clock divisor calculations) introduced a compile error in the naming of a variable in vt8500_dclk_set_rate(). It looks like a simple cut and paste error.

Cc Mike Turquette <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Quoted 7 lines

Tim,

Thanks for the fix. I already have a fix for this issue in my clk-fixes branch. In fact I forgot to bundle this one and another mxs fix in my 3.9 pull request so I'll send a follow-up bugfix branch after 3.9-rc1 is out.

It seems this hasn't happened yet. I also don't see the patch in linux-next. Is this patch still on your radar?

Arnd

#3 lore raw

Quoting Arnd Bergmann (2013-03-11 15:07:32)

Quoted 12 lines · Mike Turquette
Quoted 11 lines

Quoting Tim Gardner (2013-02-26 09:34:12)

Quoted 7 lines

commit 72480014b86c8b51fb51c5c6a0525876055c37c7 (clk: vt8500: Fix device clock divisor calculations) introduced a compile error in the naming of a variable in vt8500_dclk_set_rate(). It looks like a simple cut and paste error.

Cc Mike Turquette <[email protected]>
Cc linux-arm-kernel at lists.infradead.org

Tim,

Quoted 9 lines
Quoted 5 lines

Thanks for the fix. I already have a fix for this issue in my clk-fixes branch. In fact I forgot to bundle this one and another mxs fix in my 3.9 pull request so I'll send a follow-up bugfix branch after 3.9-rc1 is out.

It seems this hasn't happened yet. I also don't see the patch in linux-next. Is this patch still on your radar?

Arnd,

Yes it is. I haven't pushed a new branch out since 3.9-rc1 due to LCE and vacation after that. This fix and other pending patches will get pulled in this week.

Regards,
Mike

Quoted 1 line

Arnd

#4 lore raw
Quoted 4 lines · Mike Turquette

Yes it is. I haven't pushed a new branch out since 3.9-rc1 due to LCE and vacation after that. This fix and other pending patches will get pulled in this week.

I've actually put it into the arm-soc bug fix queue now, since I did not hear back from you and it never showed up in linux-next.

Arnd

#5 lore raw

PATCH 1/1 clk: vt8500: Fix variable name '*prate' compile error

Quoting Arnd Bergmann (2013-03-17 14:13:08)

Quoted 9 lines · Mike Turquette
Quoted 4 lines

Yes it is. I haven't pushed a new branch out since 3.9-rc1 due to LCE and vacation after that. This fix and other pending patches will get pulled in this week.

I've actually put it into the arm-soc bug fix queue now, since I did not hear back from you and it never showed up in linux-next.

That is fine by me.

Thanks,
Mike

Quoted 1 line

Arnd