Skip to contentSkip to conversation

b43-asm: fix compile error: undefined reference to `yydebug'

PATCH New Hauke Mehrtens 2 participants 2 messages Feb 28, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 b43-asm: fix compile error: undefined reference to `yydebug'

With bison 2.7 YYDEBUG will be set to 0 if it was not set, then #ifdef YYDEBUG returns true, but bison 2.7 treets YYDEBUG 0 as not set.

This fixes the following error:
obj/main.o: In function `main':
main.c:(.text.startup+0xaf): undefined reference to `yydebug'
collect2: error: ld returned 1 exit status

---
 assembler/Makefile |    2 +-
 assembler/main.c   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
assembler/Makefile +1 -1
index 21c652d..e9ce6f6 100644
@@ -30,7 +30,7 @@ BIN		= b43-asm.bin
 SRCS		= parser.c scanner.c main.c initvals.c util.c args.c
 
 # YACC related CFLAGS
-CFLAGS		+= -DYYSTYPE="void *" -DYYERROR_VERBOSE -DYYDEBUG -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -Wno-unused
+CFLAGS		+= -DYYSTYPE="void *" -DYYERROR_VERBOSE -DYYDEBUG=1 -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -Wno-unused
 
 .SUFFIXES:
 .PHONY: all install clean distclean
assembler/main.c +1 -1
index afca996..a62a15e 100644
@@ -1260,7 +1260,7 @@ static void initialize(void)
 {
 	INIT_LIST_HEAD(&infile.sl);
 	INIT_LIST_HEAD(&infile.ivals);
-#ifdef YYDEBUG
+#if YYDEBUG
 	if (IS_INSANE_DEBUG)
 		yydebug = 1;
 	else
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 b43-asm: fix compile error: undefined reference to `yydebug'

Quoted 2 lines · On Thu, 28 Feb 2013 11:34:43 +0100 Hauke Mehrtens <[email protected]> wrote:

With bison 2.7 YYDEBUG will be set to 0 if it was not set, then #ifdef YYDEBUG returns true, but bison 2.7 treets YYDEBUG 0 as not set.

Applied.
Thanks for the patch.

Also note that b43-tools.git will be mirrored from now on at github:
https://github.com/mbuesch?tab=repositories
Just in case bues.ch is not reachable for whatever reason. The repositories
on bues.ch are still the main ones, though, and should be used in links, documentation, etc...

Signature · 1 line
Michael