i2o: check copy_from_user() size parameter

PATCH New Dan Carpenter 1 participant 1 message Mar 1, 2013 Kernel janitors

Share & tools

Dan Carpenter

author

2013-03-01 05:21 UTC #0 lore raw

PATCH 1/1 i2o: check copy_from_user() size parameter

Limit the size of the copy so we don't corrupt memory. Hopefully this can only be called by root, but fixing this makes the static checkers happier.

Signed-off-by Dan Carpenter <[email protected]>

drivers/message/i2o/i2o_config.c +10 -0

index 5451bef..a60c188 100644
@@ -687,6 +687,11 @@ static int i2o_cfg_passthru32(struct file *file, unsigned cmnd,
 		}
 		size = size >> 16;
 		size *= 4;
+		if (size > sizeof(rmsg)) {
+			rcode = -EINVAL;
+			goto sg_list_cleanup;
+		}
+
 		/* Copy in the user's I2O command */
 		if (copy_from_user(rmsg, user_msg, size)) {
 			rcode = -EFAULT;

@@ -922,6 +927,11 @@ static int i2o_cfg_passthru(unsigned long arg)
 		}
 		size = size >> 16;
 		size *= 4;
+		if (size > sizeof(rmsg)) {
+			rcode = -EFAULT;
+			goto sg_list_cleanup;
+		}
+
 		/* Copy in the user's I2O command */
 		if (copy_from_user(rmsg, user_msg, size)) {
 			rcode = -EFAULT;