regulator: twl: Convert twl4030ldo_ops to get_voltage_sel
Subsystems (2)
PATCH 1/1 regulator: twl: Convert twl4030ldo_ops to get_voltage_sel
This fixes an inconsistent behavior between list_voltage() and get_voltage() because current implementation of get_voltage() does not check the case IS_UNSUP() is true.
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/twl-regulator.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/regulator/twl-regulator.c +4 -5
@@ -465,24 +465,23 @@ twl4030ldo_set_voltage_sel(struct regulator_dev *rdev, unsigned selector) selector); } -static int twl4030ldo_get_voltage (struct regulator_dev *rdev) +static int twl4030ldo_get_voltage_sel (struct regulator_dev *rdev) {struct twlreg_info *info =rdev_get_drvdata (rdev); -int vsel =twlreg_read (info,TWL_MODULE_PM_RECEIVER , -VREG_VOLTAGE ); +int vsel =twlreg_read (info,TWL_MODULE_PM_RECEIVER ,VREG_VOLTAGE );if (vsel <0 )return vsel; vsel &= info->table_len -1 ; -return LDO_MV (info->table[vsel]) *1000 ; +return vsel; }static struct regulator_ops twl4030ldo_ops = { .list_voltage = twl4030ldo_list_voltage, .set_voltage_sel = twl4030ldo_set_voltage_sel, - .get_voltage = twl4030ldo_get_voltage, + .get_voltage_sel = twl4030ldo_get_voltage_sel, .enable = twl4030reg_enable, .disable = twl4030reg_disable,
Signature · 1 line
1.7.9.5
Mark Brown
AppliedQuoted 3 lines · Axel Lin
This fixes an inconsistent behavior between
list_voltage()andget_voltage()because current implementation ofget_voltage()does not check the caseIS_UNSUP()is true.
Applied, thanks.