Skip to contentSkip to conversation

shmobile: kzm9g: correct smsc regulator registration

PATCH New Simon Horman 2 participants 5 messages Feb 15, 2013 – Mar 1, 2013

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover shmobile: kzm9g: correct smsc regulator registration

Correct registration of regulators for the SMSC device on the kzm9g and update the defconfig accordingly.

Simon Horman (2):
ARM: shmobile: kzm9g: correct smsc regulator registration
ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig

 arch/arm/configs/kzm9g_defconfig     |    1 -
 arch/arm/mach-shmobile/board-kzm9g.c |    4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)
#1 lore raw

PATCH 1/2 ARM: shmobile: kzm9g: correct smsc regulator registration

Correct the name of smsc devices used for regulator registration allowing the regulators to be found and used.

This eliminates the need for CONFIG_REGULATOR_DUMMY when CONFIG_REGULATOR is set.

Cc Guennadi Liakhovetski <[email protected]>
---
 arch/arm/mach-shmobile/board-kzm9g.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-shmobile/board-kzm9g.c +2 -2
index 1a26077..3cf5898 100644
@@ -61,8 +61,8 @@
 
 /* Dummy supplies, where voltage doesn't matter */
 static struct regulator_consumer_supply dummy_supplies[] = {
-	REGULATOR_SUPPLY("vddvario", "smsc911x"),
-	REGULATOR_SUPPLY("vdd33a", "smsc911x"),
+	REGULATOR_SUPPLY("vddvario", "smsc911x.0"),
+	REGULATOR_SUPPLY("vdd33a", "smsc911x.0"),
 };
 
 /*
Signature · 1 line
1.7.10.4
Applied
#2 lore raw

PATCH 1/2 ARM: shmobile: kzm9g: correct smsc regulator registration

Quoted 5 lines · Simon Horman

Correct the name of smsc devices used for regulator registration allowing the regulators to be found and used.

This eliminates the need for CONFIG_REGULATOR_DUMMY when CONFIG_REGULATOR is set.

Applied to the boards3 branch of the renesas tree and thus included in its next branch and queued up for v3.10.

Quoted 30 lines
Cc Guennadi Liakhovetski <[email protected]>
---
 arch/arm/mach-shmobile/board-kzm9g.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-shmobile/board-kzm9g.c +2 -2
index 1a26077..3cf5898 100644
@@ -61,8 +61,8 @@
 
 /* Dummy supplies, where voltage doesn't matter */
 static struct regulator_consumer_supply dummy_supplies[] = {
-	REGULATOR_SUPPLY("vddvario", "smsc911x"),
-	REGULATOR_SUPPLY("vdd33a", "smsc911x"),
+	REGULATOR_SUPPLY("vddvario", "smsc911x.0"),
+	REGULATOR_SUPPLY("vdd33a", "smsc911x.0"),
 };
 
 /*
Signature · 6 lines
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw

PATCH 2/2 ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig

In reply to Simon Horman

Don't enable REGULATOR_DUMMY, it is only intended for development / testing. There doesn't seem to be any value in setting it here and doing so was an error on my part.

Cc Guennadi Liakhovetski <[email protected]>
---
 arch/arm/configs/kzm9g_defconfig |    1 -
 1 file changed, 1 deletion(-)

This patch depends on "ARM: shmobile: kzm9g: correct smsc regulator registration"

arch/arm/configs/kzm9g_defconfig +0 -1
index 670c3b6..6751c02 100644
@@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y
 CONFIG_GPIO_PCF857X=y
 # CONFIG_HWMON is not set
 CONFIG_REGULATOR=y
-CONFIG_REGULATOR_DUMMY=y
 CONFIG_FB=y
 CONFIG_FB_SH_MOBILE_LCDC=y
 CONFIG_FRAMEBUFFER_CONSOLE=y
Signature · 1 line
1.7.10.4
Applied
#4 lore raw

PATCH 2/2 ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig

Quoted 3 lines · Simon Horman

Don't enable REGULATOR_DUMMY, it is only intended for development / testing. There doesn't seem to be any value in setting it here and doing so was an error on my part.

Applied to the defconfig branch of the renesas tree and thus included in its next branch and queued up for v3.10.

Quoted 24 lines
Cc Guennadi Liakhovetski <[email protected]>
---
 arch/arm/configs/kzm9g_defconfig |    1 -
 1 file changed, 1 deletion(-)

This patch depends on "ARM: shmobile: kzm9g: correct smsc regulator registration"

arch/arm/configs/kzm9g_defconfig +0 -1
index 670c3b6..6751c02 100644
@@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y
 CONFIG_GPIO_PCF857X=y
 # CONFIG_HWMON is not set
 CONFIG_REGULATOR=y
-CONFIG_REGULATOR_DUMMY=y
 CONFIG_FB=y
 CONFIG_FB_SH_MOBILE_LCDC=y
 CONFIG_FRAMEBUFFER_CONSOLE=y
Signature · 1 line
1.7.10.4