IIO_BUFFER - IIO_TRIGGERED_BUFFER circular dependency
Hi all,
IIO_TRIGGERED_BUFFER depends on IIO_BUFFER because of:
drivers/iio/industrialio-triggered-buffer.c:20:16: error:
‘iio_sw_buffer_preenable’ undeclared here (not in a function)
On the other side, it is often selected as follows.
select IIO_TRIGGERED_BUFFER if (IIO_BUFFER)
For that reason, selecting IIO_BUFFER in the IIO_TRIGGERED_BUFFER declaration results in a circular dependency. Sometimes the "if (IIO_BUFFER)" when selecting IIO_TRIGGERED_BUFFER is missing, though, which can result in the compile error.
What is the proper solution ?
- Add "if (IIO_BUFFER)" whenever IIO_TRIGGERED_BUFFER is selected or
- Remove "if (IIO_BUFFER)" from IIO_TRIGGERED_BUFFER selection and add "select IIO_BUFFER" to the IIO_TRIGGERED_BUFFER declaration
I would prefer the latter to solve the problem for good.
Thanks,
Guenter
Quoted 15 lines · Guenter Roeck
Hi all,
IIO_TRIGGERED_BUFFERdepends onIIO_BUFFERbecause of:
drivers/iio/industrialio-triggered-buffer.c:20:16: error:
‘iio_sw_buffer_preenable’ undeclared here (not in a function)On the other side, it is often selected as follows.
select
IIO_TRIGGERED_BUFFERif (IIO_BUFFER)For that reason, selecting
IIO_BUFFERin theIIO_TRIGGERED_BUFFERdeclaration results in a circular dependency. Sometimes the "if (IIO_BUFFER)" when selectingIIO_TRIGGERED_BUFFERis missing, though, which can result in the compile error.
Quoted 7 lines
What is the proper solution ?
- Add "if (IIO_BUFFER)" wheneverIIO_TRIGGERED_BUFFERis selected or
- Remove "if (IIO_BUFFER)" fromIIO_TRIGGERED_BUFFERselection and add "selectIIO_BUFFER" to theIIO_TRIGGERED_BUFFERdeclarationI would prefer the latter to solve the problem for good.
Hi,
This is a bit tricky, some drivers have optional buffer support, so they only select the helper module if buffer support is enabled, since they don't use the helper module if buffer support is disabled. Other driver though always want buffer support so they select the helper module unconditionally. So far it was the responsibility of the driver's Kconfig entry to make sure that if it selects IIO_TRIGGERED_BUFFER it needs to make sure that IIO_BUFFER is also selected. As far as I can see all drivers do this currently. Which one breaks things for you?
If it was for me we would make IIO_BUFFER non-user-selectable and just let every driver that has support for buffers select it. But when this came up in the past Jonathon had other views on this.
- Lars
Quoted 26 lines · Lars-Peter Clausen
Quoted 15 lines · Guenter Roeck
Hi all,
IIO_TRIGGERED_BUFFERdepends onIIO_BUFFERbecause of:
drivers/iio/industrialio-triggered-buffer.c:20:16: error:
‘iio_sw_buffer_preenable’ undeclared here (not in a function)On the other side, it is often selected as follows.
select
IIO_TRIGGERED_BUFFERif (IIO_BUFFER)For that reason, selecting
IIO_BUFFERin theIIO_TRIGGERED_BUFFERdeclaration results in a circular dependency. Sometimes the "if (IIO_BUFFER)" when selectingIIO_TRIGGERED_BUFFERis missing, though, which can result in the compile error.Quoted 7 lines
What is the proper solution ?
- Add "if (IIO_BUFFER)" wheneverIIO_TRIGGERED_BUFFERis selected or
- Remove "if (IIO_BUFFER)" fromIIO_TRIGGERED_BUFFERselection and add "selectIIO_BUFFER" to theIIO_TRIGGERED_BUFFERdeclarationI would prefer the latter to solve the problem for good.
Hi,
Quoted 9 lines
This is a bit tricky, some drivers have optional buffer support, so they only select the helper module if buffer support is enabled, since they don't use the helper module if buffer support is disabled. Other driver though always want buffer support so they select the helper module unconditionally. So far it was the responsibility of the driver's
Kconfigentry to make sure that if it selectsIIO_TRIGGERED_BUFFERit needs to make sure thatIIO_BUFFERis also selected. As far as I can see all drivers do this currently. Which one breaks things for you?
It is a randconfig thing, so it breaks in some of my nightly randconfig builds, and it has also been reported as build failure in the official builds. I can dig out some affected configurations and send it to you if you like, but the gist of it is that IIO_TRIGGERED_BUFFER can be selected without IIO_BUFFER, but depends on it. That just isn't correct. Of course, the other option might be to make IIO_TRIGGERED_BUFFER dependent on IIO_BUFFER. Would that be acceptable ?
Thanks,
Guenter
Quoted 36 lines · Guenter Roeck
Quoted 26 lines · Lars-Peter Clausen
Quoted 15 lines · Guenter Roeck
Hi all,
IIO_TRIGGERED_BUFFERdepends onIIO_BUFFERbecause of:
drivers/iio/industrialio-triggered-buffer.c:20:16: error:
‘iio_sw_buffer_preenable’ undeclared here (not in a function)On the other side, it is often selected as follows.
select
IIO_TRIGGERED_BUFFERif (IIO_BUFFER)For that reason, selecting
IIO_BUFFERin theIIO_TRIGGERED_BUFFERdeclaration results in a circular dependency. Sometimes the "if (IIO_BUFFER)" when selectingIIO_TRIGGERED_BUFFERis missing, though, which can result in the compile error.Quoted 7 lines
What is the proper solution ?
- Add "if (IIO_BUFFER)" wheneverIIO_TRIGGERED_BUFFERis selected or
- Remove "if (IIO_BUFFER)" fromIIO_TRIGGERED_BUFFERselection and add "selectIIO_BUFFER" to theIIO_TRIGGERED_BUFFERdeclarationI would prefer the latter to solve the problem for good.
Hi,
Quoted 9 lines
This is a bit tricky, some drivers have optional buffer support, so they only select the helper module if buffer support is enabled, since they don't use the helper module if buffer support is disabled. Other driver though always want buffer support so they select the helper module unconditionally. So far it was the responsibility of the driver's
Kconfigentry to make sure that if it selectsIIO_TRIGGERED_BUFFERit needs to make sure thatIIO_BUFFERis also selected. As far as I can see all drivers do this currently. Which one breaks things for you?
Quoted 3 lines
It is a randconfig thing, so it breaks in some of my nightly randconfig builds, and it has also been reported as build failure in the official builds. I can dig out some affected configurations and send it to you if you like.
Yes that would be great, thanks.
Quoted 5 lines
but the gist of
it is thatIIO_TRIGGERED_BUFFERcan be selected withoutIIO_BUFFER, but depends on it. That just isn't correct. Of course, the other option might be to makeIIO_TRIGGERED_BUFFERdependent onIIO_BUFFER. Would that be acceptable ?
That won't work, you can overwrite 'depends on' by selecting the symbol.
But the reason why there is a cyclic dependency is not because of the 'select IIO_TRIGGERED_BUFFER if (IIO_BUFFER)' but rather because IIO_TRIGGERED_BUFFER is in an 'if IIO_BUFFER' section. Moving it out there fixes the cyclic dependency error. But creates a recursive dependency warning.
I think we could avoid this warning by introducing a new symbol. E.g. IIO_BUFFER_INTERN (bad name). IIO_BUFFER_INTERN won't be user selectable. It will be selected by IIO_BUFFER and IIO_TRIGGERED_BUFFER and if it is selected buffer support is built. E.g. something like this:
drivers/iio/Kconfig +8 -3
@@ -14,11 +14,15 @@ if IIO config IIO_BUFFER bool "Enable buffer support within IIO" + select IIO_BUFFER_INTERN help Provide core support for various buffer based data acquisition methods. -if IIO_BUFFER +config IIO_BUFFER_INTERN + bool + +if IIO_BUFFER_INTERN config IIO_BUFFER_CB boolean "IIO callback buffer used for push in-kernel interfaces"
@@ -35,15 +39,16 @@ config IIO_KFIFO_BUF no buffer events so it is up to userspace to work out how often to read from the buffer. +endif # IIO_BUFFER + config IIO_TRIGGERED_BUFFER tristate select IIO_TRIGGER select IIO_KFIFO_BUF + select IIO_BUFFER_INTERN help Provides helper functions for setting up triggered buffers. -endif # IIO_BUFFER - config IIO_TRIGGER boolean "Enable triggered sampling support" help
drivers/iio/Makefile +1 -1
@@ -4,7 +4,7 @@ obj-$(CONFIG_IIO) += industrialio.o industrialio-y := industrialio-core.o industrialio-event.o inkern.o -industrialio-$(CONFIG_IIO_BUFFER) += industrialio-buffer.o +industrialio-$(CONFIG_IIO_BUFFER_INTERN) += industrialio-buffer.o industrialio-$(CONFIG_IIO_TRIGGER) += industrialio-trigger.o industrialio-$(CONFIG_IIO_BUFFER_CB) += buffer_cb.o
Although this has the downside that it is not immediately visible anymore whether buffer support is going to be built or not.
- Lars
Quoted 56 lines · Lars-Peter Clausen
Quoted 36 lines · Guenter Roeck
Quoted 26 lines · Lars-Peter Clausen
Quoted 15 lines · Guenter Roeck
Hi all,
IIO_TRIGGERED_BUFFERdepends onIIO_BUFFERbecause of:
drivers/iio/industrialio-triggered-buffer.c:20:16: error:
‘iio_sw_buffer_preenable’ undeclared here (not in a function)On the other side, it is often selected as follows.
select
IIO_TRIGGERED_BUFFERif (IIO_BUFFER)For that reason, selecting
IIO_BUFFERin theIIO_TRIGGERED_BUFFERdeclaration results in a circular dependency. Sometimes the "if (IIO_BUFFER)" when selectingIIO_TRIGGERED_BUFFERis missing, though, which can result in the compile error.Quoted 7 lines
What is the proper solution ?
- Add "if (IIO_BUFFER)" wheneverIIO_TRIGGERED_BUFFERis selected or
- Remove "if (IIO_BUFFER)" fromIIO_TRIGGERED_BUFFERselection and add "selectIIO_BUFFER" to theIIO_TRIGGERED_BUFFERdeclarationI would prefer the latter to solve the problem for good.
Hi,
Quoted 9 lines
This is a bit tricky, some drivers have optional buffer support, so they only select the helper module if buffer support is enabled, since they don't use the helper module if buffer support is disabled. Other driver though always want buffer support so they select the helper module unconditionally. So far it was the responsibility of the driver's
Kconfigentry to make sure that if it selectsIIO_TRIGGERED_BUFFERit needs to make sure thatIIO_BUFFERis also selected. As far as I can see all drivers do this currently. Which one breaks things for you?Quoted 3 lines
It is a randconfig thing, so it breaks in some of my nightly randconfig builds, and it has also been reported as build failure in the official builds. I can dig out some affected configurations and send it to you if you like.
Yes that would be great, thanks.
Quoted 5 lines
but the gist of
it is thatIIO_TRIGGERED_BUFFERcan be selected withoutIIO_BUFFER, but depends on it. That just isn't correct. Of course, the other option might be to makeIIO_TRIGGERED_BUFFERdependent onIIO_BUFFER. Would that be acceptable ?That won't work, you can overwrite 'depends on' by selecting the symbol.
But the reason why there is a cyclic dependency is not because of the 'select
IIO_TRIGGERED_BUFFERif (IIO_BUFFER)' but rather becauseIIO_TRIGGERED_BUFFERis in an 'ifIIO_BUFFER' section. Moving it out there fixes the cyclic dependency error. But creates a recursive dependency warning.
Quoted 5 lines
I think we could avoid this warning by introducing a new symbol. E.g.
IIO_BUFFER_INTERN(bad name).IIO_BUFFER_INTERNwon't be user selectable. It will be selected byIIO_BUFFERandIIO_TRIGGERED_BUFFERand if it is selected buffer support is built. E.g. something like this:
Agreed, that would also solve the need of selecting IIO_BUFFER as well if IIO_TRIGGERED_BUFFER is selected. For now I solved the problem with the two patches I submitted, so assuming those are accepted I guess this one or something similar can wait for -next.
Thanks,
Guenter
Jonathan Cameron
maintainerQuoted 62 lines · Guenter Roeck
Quoted 56 lines · Lars-Peter Clausen
Quoted 36 lines · Guenter Roeck
Quoted 26 lines · Lars-Peter Clausen
Quoted 15 lines · Guenter Roeck
Hi all,
IIO_TRIGGERED_BUFFERdepends onIIO_BUFFERbecause of:
drivers/iio/industrialio-triggered-buffer.c:20:16: error:
‘iio_sw_buffer_preenable’ undeclared here (not in a function)On the other side, it is often selected as follows.
select
IIO_TRIGGERED_BUFFERif (IIO_BUFFER)For that reason, selecting
IIO_BUFFERin theIIO_TRIGGERED_BUFFERdeclaration results in a circular dependency. Sometimes the "if (IIO_BUFFER)" when selectingIIO_TRIGGERED_BUFFERis missing, though, which can result in the compile error.Quoted 7 lines
What is the proper solution ?
- Add "if (IIO_BUFFER)" wheneverIIO_TRIGGERED_BUFFERis selected or
- Remove "if (IIO_BUFFER)" fromIIO_TRIGGERED_BUFFERselection and add "selectIIO_BUFFER" to theIIO_TRIGGERED_BUFFERdeclarationI would prefer the latter to solve the problem for good.
Hi,
Quoted 9 lines
This is a bit tricky, some drivers have optional buffer support, so they only select the helper module if buffer support is enabled, since they don't use the helper module if buffer support is disabled. Other driver though always want buffer support so they select the helper module unconditionally. So far it was the responsibility of the driver's
Kconfigentry to make sure that if it selectsIIO_TRIGGERED_BUFFERit needs to make sure thatIIO_BUFFERis also selected. As far as I can see all drivers do this currently. Which one breaks things for you?Quoted 3 lines
It is a randconfig thing, so it breaks in some of my nightly randconfig builds, and it has also been reported as build failure in the official builds. I can dig out some affected configurations and send it to you if you like.
Yes that would be great, thanks.
Quoted 5 lines
but the gist of
it is thatIIO_TRIGGERED_BUFFERcan be selected withoutIIO_BUFFER, but depends on it. That just isn't correct. Of course, the other option might be to makeIIO_TRIGGERED_BUFFERdependent onIIO_BUFFER. Would that be acceptable ?That won't work, you can overwrite 'depends on' by selecting the symbol.
But the reason why there is a cyclic dependency is not because of the 'select
IIO_TRIGGERED_BUFFERif (IIO_BUFFER)' but rather becauseIIO_TRIGGERED_BUFFERis in an 'ifIIO_BUFFER' section. Moving it out there fixes the cyclic dependency error. But creates a recursive dependency warning.Quoted 5 lines
I think we could avoid this warning by introducing a new symbol. E.g.
IIO_BUFFER_INTERN(bad name).IIO_BUFFER_INTERNwon't be user selectable. It will be selected byIIO_BUFFERandIIO_TRIGGERED_BUFFERand if it is selected buffer support is built. E.g. something like this:
Quoted 4 lines
Agreed, that would also solve the need of selecting
IIO_BUFFERas well ifIIO_TRIGGERED_BUFFERis selected. For now I solved the problem with the two patches I submitted, so assuming those are accepted I guess this one or something similar can wait for -next.
Agreed. Sounds like Lars volunteered to do this to me ;) It's a little uggly but I can't immediately think of anything better.
Quoted 8 lines
Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 36 lines · Guenter Roeck
Quoted 26 lines · Lars-Peter Clausen
Quoted 15 lines · Guenter Roeck
Hi all,
IIO_TRIGGERED_BUFFERdepends onIIO_BUFFERbecause of:
drivers/iio/industrialio-triggered-buffer.c:20:16: error:
‘iio_sw_buffer_preenable’ undeclared here (not in a function)On the other side, it is often selected as follows.
select
IIO_TRIGGERED_BUFFERif (IIO_BUFFER)For that reason, selecting
IIO_BUFFERin theIIO_TRIGGERED_BUFFERdeclaration results in a circular dependency. Sometimes the "if (IIO_BUFFER)" when selectingIIO_TRIGGERED_BUFFERis missing, though, which can result in the compile error.Quoted 7 lines
What is the proper solution ?
- Add "if (IIO_BUFFER)" wheneverIIO_TRIGGERED_BUFFERis selected or
- Remove "if (IIO_BUFFER)" fromIIO_TRIGGERED_BUFFERselection and add "selectIIO_BUFFER" to theIIO_TRIGGERED_BUFFERdeclarationI would prefer the latter to solve the problem for good.
Hi,
Quoted 9 lines
This is a bit tricky, some drivers have optional buffer support, so they only select the helper module if buffer support is enabled, since they don't use the helper module if buffer support is disabled. Other driver though always want buffer support so they select the helper module unconditionally. So far it was the responsibility of the driver's
Kconfigentry to make sure that if it selectsIIO_TRIGGERED_BUFFERit needs to make sure thatIIO_BUFFERis also selected. As far as I can see all drivers do this currently. Which one breaks things for you?
Quoted 7 lines
It is a randconfig thing, so it breaks in some of my nightly randconfig builds, and it has also been reported as build failure in the official builds. I can dig out some affected configurations and send it to you if you like, but the gist of it is that
IIO_TRIGGERED_BUFFERcan be selected withoutIIO_BUFFER, but depends on it. That just isn't correct. Of course, the other option might be to makeIIO_TRIGGERED_BUFFERdependent onIIO_BUFFER. Would that be acceptable ?
Wait, that is already the case. So I guess to fix the problem, it will be necesary to change all instances of
select IIO_TRIGGERED_BUFFER
to
select IIO_TRIGGERED_BUFFER if if (IIO_BUFFER)
for instances where IIO_BUFFER is not also selected, or to also select IIO_BUFFER if the driver really needs it.
Offender is INV_MPU6050_IIO, which does need IIO_BUFFER. I'll send a patch to fix that.
Guenter