Skip to contentSkip to conversation

microperl: remove it

PATCH New Francois Perrad 3 participants 8 messages Mar 2, 2013 – Aug 13, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 microperl: remove it

microperl has been deprecated by perl

---
 docs/manual/deprecated-list.txt                    |    1 -
 package/Config.in                                  |    1 -
 package/libxml-parser-perl/libxml-parser-perl.mk   |    6 -
 package/microperl/Config.in                        |   30 ----
 .../microperl/microperl-no-signal-handlers.patch   |   22 ---
 package/microperl/microperl-uudmap.patch           |   47 ------
 package/microperl/microperl.mk                     |  156 --------------------
 7 files changed, 263 deletions(-)
 delete mode 100644 package/microperl/Config.in
 delete mode 100644 package/microperl/microperl-no-signal-handlers.patch
 delete mode 100644 package/microperl/microperl-uudmap.patch
 delete mode 100644 package/microperl/microperl.mk
docs/manual/deprecated-list.txt +0 -1
index 6dc87a4..3c2b1c5 100644
@@ -20,7 +20,6 @@ their status either too old or unmaintained.
 ** +busybox+ 1.18.x
 ** +customize+
 ** +lzma+
-** +microperl+
 ** +netkitbase+
 ** +netkittelnet+
 ** +pkg-config+
package/Config.in +0 -1
index faee5c3..8de1276 100644
@@ -313,7 +313,6 @@ menu "Perl libraries/modules"
 source "package/cpanminus/Config.in"
 endmenu
 endif
-source "package/microperl/Config.in"
 source "package/php/Config.in"
 source "package/python/Config.in"
 source "package/python3/Config.in"
package/libxml-parser-perl/libxml-parser-perl.mk +0 -6
index 996b10d..4454e57 100644
@@ -10,12 +10,6 @@ LIBXML_PARSER_PERL_SITE = http://www.cpan.org/modules/by-module/XML/
 
 LIBXML_PARSER_PERL_DEPENDENCIES = expat
 
-ifeq ($(BR2_PACKAGE_MICROPERL),y)
-# microperl builds host-microperl, so ensure we build after that to build
-# against host-microperl instead of the system perl
-LIBXML_PARSER_PERL_DEPENDENCIES += microperl
-endif
-
 define HOST_LIBXML_PARSER_PERL_CONFIGURE_CMDS
  (cd $(@D) ; \
    $(HOST_CONFIGURE_OPTS) perl Makefile.PL \
package/microperl/Config.in deleted +0 -30
deleted file mode 100644
index 19d104a..0000000
@@ -1,30 +0,0 @@
-config BR2_PACKAGE_MICROPERL
-	bool "microperl"
-	# needs fork()
-	depends on BR2_USE_MMU
-	depends on BR2_DEPRECATED
-	help
-	  Perl without operating-specific functions such as readdir.
-
-if BR2_PACKAGE_MICROPERL
-
-config BR2_PACKAGE_MICROPERL_MODULES
-	string "additional modules"
-	help
-	  List of space-separated microperl modules to copy to the rootfs.
-
-	  Examples: warnings.pm Getopt/Std.pm Time::Local
-
-	  Module dependencies are not automatic so check your needs.
-	  You can't use XS modules like IO.
-
-menu "module bundles"
-
-config BR2_PACKAGE_MICROPERL_BUNDLE_CGI
-	bool "CGI"
-	help
-	  Copy required modules to do CGI scripting.
-
-endmenu
-
-endif
package/microperl/microperl-no-signal-handlers.patch deleted +0 -22
deleted file mode 100644
index 3c9aa41..0000000
@@ -1,22 +0,0 @@
-Backport of http://perl5.git.perl.org/perl.git/commitdiff/01d65469392dfc0a?hp=a82b5f080d91ffe184d8ac4795ac71e72e612c2f
-
-Signed-off-by: Gustavo Zacarias <[email protected]>
-
-diff -Nura perl-5.12.3/miniperlmain.c perl-5.12.3-nosig/miniperlmain.c
---- perl-5.12.3/miniperlmain.c	2011-01-09 17:20:57.000000000 -0300
-+++ perl-5.12.3-nosig/miniperlmain.c	2011-04-14 10:16:53.564639438 -0300
-@@ -116,12 +116,14 @@
-     if (!exitstatus)
-         perl_run(my_perl);
- 
-+#ifndef PERL_MICRO
-     /* Unregister our signal handler before destroying my_perl */
-     for (i = 0; PL_sig_name[i]; i++) {
- 	if (rsignal_state(PL_sig_num[i]) == (Sighandler_t) PL_csighandlerp) {
- 	    rsignal(PL_sig_num[i], (Sighandler_t) SIG_DFL);
- 	}
-     }
-+#endif
- 
-     exitstatus = perl_destruct(my_perl);
- 
package/microperl/microperl-uudmap.patch deleted +0 -47

47 lines not on this page · raw message

package/microperl/microperl.mk deleted +0 -156

156 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 2/3 cpanminus: works with arm & mips

---
 package/cpanminus/Config.in    |   15 +++++++++++----
 package/cpanminus/cpanminus.mk |    2 +-
 2 files changed, 12 insertions(+), 5 deletions(-)
package/cpanminus/Config.in +11 -4
index b10d211..cf93a7e 100644
@@ -1,9 +1,16 @@
 config BR2_PACKAGE_CPANMINUS
 	bool "cpanminus"
-	# Requires host-qemu, which cannot work properly due to kernel
-	# headers mismatch between the build environment and the
-	# target.
-	depends on BR2_BROKEN
+	# host-qemu doesn't work for the following platforms
+	depends on !BR2_avr32
+	depends on !BR2_bfin
+	depends on !BR2_sh2
+	depends on !BR2_sh2a
+	depends on !BR2_sh3
+	depends on !BR2_sh3eb
+	depends on !BR2_sh64
+	# host-qemu doesn't support system() on the following platforms
+	depends on !BR2_i386
+	depends on !BR2_x86_64
 	help
 	  cpanminus is a script to get, unpack, build and install Perl modules
 	  from CPAN.
package/cpanminus/cpanminus.mk +1 -1
index e7e3f29..f815199 100644
@@ -36,7 +36,7 @@ define CPANMINUS_INSTALL_TARGET_CMDS
 		--no-man-pages \
 		$(CPANMINUS_MIRROR) \
 		$(call qstrip,$(BR2_PACKAGE_CPANMINUS_MODULES))
-	-find $(CPANMINUS_PERL_SITEARCH) -type f -name *.bs -exec rm -f {} \;
+	-find $(CPANMINUS_PERL_SITELIB) -type f -name *.bs -exec rm -f {} \;
 endef
 else
 define CPANMINUS_INSTALL_TARGET_CMDS
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 2/3 cpanminus: works with arm & mips

Dear Francois Perrad,

Quoted 11 lines · Francois Perrad
---
 package/cpanminus/Config.in    |   15 +++++++++++----
 package/cpanminus/cpanminus.mk |    2 +-
 2 files changed, 12 insertions(+), 5 deletions(-)
package/cpanminus/Config.in +0 -0
index b10d211..cf93a7e 100644

package/cpanminus/Config.in line 6

Quoted 6 lines
package/cpanminus/Config.in +0 -4
@@ -1,9 +1,16 @@
 config BR2_PACKAGE_CPANMINUS
 	bool "cpanminus"
-	# Requires host-qemu, which cannot work properly due to kernel
-	# headers mismatch between the build environment and the
-	# target.
-	depends on BR2_BROKEN

Sorry, but I don't see where the problem mentioned in the comment here has been solved. Anything using host-qemu to help in cross-compilation cannot work: it is very likely that the kernel headers used to build the target toolchain are much more recent than the kernel running on the build machine. Since the Qemu user-mode emulation works by converting the target syscall into host syscall, it cannot work when kernel headers are more recent than the kernel version running on the build machine.

I don't see how this can be solved, it is a fundamental problem in the approach.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#3 lore raw

PATCH 2/3 cpanminus: works with arm & mips

Fran?ois,

Quoted 30 lines · Thomas Petazzoni

Dear Francois Perrad,

Quoted 11 lines · Francois Perrad
---
 package/cpanminus/Config.in    |   15 +++++++++++----
 package/cpanminus/cpanminus.mk |    2 +-
 2 files changed, 12 insertions(+), 5 deletions(-)
package/cpanminus/Config.in +0 -0
index b10d211..cf93a7e 100644

package/cpanminus/Config.in line 6

Quoted 6 lines
package/cpanminus/Config.in +0 -4
@@ -1,9 +1,16 @@
 config BR2_PACKAGE_CPANMINUS
 	bool "cpanminus"
-	# Requires host-qemu, which cannot work properly due to kernel
-	# headers mismatch between the build environment and the
-	# target.
-	depends on BR2_BROKEN

Sorry, but I don't see where the problem mentioned in the comment here has been solved. Anything using host-qemu to help in cross-compilation cannot work: it is very likely that the kernel headers used to build the target toolchain are much more recent than the kernel running on the build machine. Since the Qemu user-mode emulation works by converting the target syscall into host syscall, it cannot work when kernel headers are more recent than the kernel version running on the build machine.

Quoted 2 lines

I don't see how this can be solved, it is a fundamental problem in the approach.

Since you haven't given any further comments on this since March, the patch has been waiting in our patchwork queue.

While waiting for (hopefully) some solution, or comment from you, I'll mark the patch as "Rejected" until we get to an agreement on how to solve the cpanminus problem.

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#4 lore raw

PATCH 3/3 cpanminus: bump to version 1.6002

In reply to Francois Perrad
---
 package/cpanminus/cpanminus.mk |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/cpanminus/cpanminus.mk +3 -3
index f815199..cb3c0d7 100644
@@ -4,9 +4,9 @@
 #
 #############################################################
 
-CPANMINUS_VERSION = 1.5018
-CPANMINUS_SOURCE = miyagawa-cpanminus-$(CPANMINUS_VERSION)-0-gee6cd30.tar.gz
-CPANMINUS_SITE = https://github.com/miyagawa/cpanminus/tarball/$(CPANMINUS_VERSION)
+CPANMINUS_VERSION = 1.6002
+CPANMINUS_SOURCE = $(CPANMINUS_VERSION).tar.gz
+CPANMINUS_SITE = https://github.com/miyagawa/cpanminus/archive
 CPANMINUS_DEPENDENCIES = host-qemu perl $(call qstrip,$(BR2_PACKAGE_CPANMINUS_NATIVE_DEPENDENCIES))
 
 CPANMINUS_RUN_PERL = $(QEMU_USER) $(STAGING_DIR)/usr/bin/perl
Signature · 1 line
1.7.9.5
#5 lore raw

PATCH 3/3 cpanminus: bump to version 1.6002

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Francois" == Francois Perrad <[email protected]> writes:

Francois> Signed-off-by: Francois Perrad <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

PATCH 1/3 microperl: remove it

In reply to Francois Perrad

Dear Francois Perrad,

Quoted 16 lines · Francois Perrad

microperl has been deprecated by perl

---
 docs/manual/deprecated-list.txt                    |    1 -
 package/Config.in                                  |    1 -
 package/libxml-parser-perl/libxml-parser-perl.mk   |    6 -
 package/microperl/Config.in                        |   30 ----
 .../microperl/microperl-no-signal-handlers.patch   |   22 ---
 package/microperl/microperl-uudmap.patch           |   47 ------
 package/microperl/microperl.mk                     |  156 --------------------
 7 files changed, 263 deletions(-)
 delete mode 100644 package/microperl/Config.in
 delete mode 100644 package/microperl/microperl-no-signal-handlers.patch
 delete mode 100644 package/microperl/microperl-uudmap.patch
 delete mode 100644 package/microperl/microperl.mk

I think docs/manual/deprecated-list.txt is automatically generated, so it probably shouldn't be changed, but I guess Peter can fix that when committing.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#7 lore raw

PATCH 1/3 microperl: remove it

In reply to Francois Perrad
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Francois" == Francois Perrad <[email protected]> writes:

Francois> microperl has been deprecated by perl Francois> Signed-off-by: Francois Perrad <[email protected]>

Committed except for the deprecated-list.txt change, thanks.

Signature · 1 line
Bye, Peter Korsgaard