ASoC: wm8350: Use jiffies rather than msecs in schedule_delayed_work()
Subsystems (3)
PATCH 1/1 ASoC: wm8350: Use jiffies rather than msecs in schedule_delayed_work()
The delay parameter of schedule_delayed_work() is number of jiffies to wait rather than miliseconds.
Before commit 6d3c26bcb "ASoC: Use delayed work to debounce WM8350 jack IRQs", the debounce time is 200 miliseconds in wm8350_hp_jack_handler(). So I think this is a bug when convert to use delayed work.
Signed-off-by Axel Lin <[email protected]>
--- sound/soc/codecs/wm8350.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/wm8350.c +2 -2
@@ -1301,7 +1301,7 @@ static irqreturn_t wm8350_hpl_jack_handler(int irq, void *data)if (device_may_wakeup (wm8350->dev))pm_wakeup_event (wm8350->dev,250 ); -schedule_delayed_work (&priv->hpl.work,200 ); +schedule_delayed_work (&priv->hpl.work,msecs_to_jiffies (200 ));return IRQ_HANDLED ; }
@@ -1318,7 +1318,7 @@ static irqreturn_t wm8350_hpr_jack_handler(int irq, void *data)if (device_may_wakeup (wm8350->dev))pm_wakeup_event (wm8350->dev,250 ); -schedule_delayed_work (&priv->hpr.work,200 ); +schedule_delayed_work (&priv->hpr.work,msecs_to_jiffies (200 ));return IRQ_HANDLED ; }
Signature · 1 line
1.7.9.5
Mark Brown
AppliedQuoted 2 lines · Axel Lin
The delay parameter of
schedule_delayed_work()is number of jiffies to wait rather than miliseconds.
Applied, thanks.