Skip to contentSkip to conversation

u-boot: u-boot SPL is usually under ./spl/

PATCH New Carlo Caione 3 participants 7 messages Mar 3, 2013 – Mar 4, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 u-boot: u-boot SPL is usually under ./spl/

---
 boot/uboot/uboot.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
boot/uboot/uboot.mk +1 -1
index ea77259..3dfcca3 100644
@@ -103,7 +103,7 @@ endef
 define UBOOT_INSTALL_IMAGES_CMDS
 	cp -dpf $(@D)/$(UBOOT_BIN) $(BINARIES_DIR)/
 	$(if $(BR2_TARGET_UBOOT_SPL),
-		cp -dpf $(@D)/$(BR2_TARGET_UBOOT_SPL_NAME) $(BINARIES_DIR)/)
+		cp -dpf $(@D)/spl/$(BR2_TARGET_UBOOT_SPL_NAME) $(BINARIES_DIR)/)
 endef
 
 define UBOOT_INSTALL_OMAP_IFT_IMAGE
Signature · 1 line
1.8.1.3
#1 lore raw

PATCH 1/1 u-boot: u-boot SPL is usually under ./spl/

Dear Carlo Caione,

Quoted 10 lines · Carlo Caione
---
 boot/uboot/uboot.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
boot/uboot/uboot.mk +0 -0
index ea77259..3dfcca3 100644

boot/uboot/uboot.mk endef · line 106

Quoted 5 lines
boot/uboot/uboot.mk +1 -1
@@ -103,7 +103,7 @@ endef
 define UBOOT_INSTALL_IMAGES_CMDS
 	cp -dpf $(@D)/$(UBOOT_BIN) $(BINARIES_DIR)/
 	$(if $(BR2_TARGET_UBOOT_SPL),
-		cp -dpf $(@D)/$(BR2_TARGET_UBOOT_SPL_NAME) $(BINARIES_DIR)/)
+		cp -dpf $(@D)/spl/$(BR2_TARGET_UBOOT_SPL_NAME) $(BINARIES_DIR)/)

In the case of OMAP, the SPL gets generated in the main source directory. For which configuration do you see that it is installed only in the spl/ sub-directory?

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 u-boot: u-boot SPL is usually under ./spl/

Quoted 8 lines · Thomas Petazzoni

Dear Carlo Caione,

Quoted 5 lines · Carlo Caione
---
 boot/uboot/uboot.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines

boot/uboot/uboot.mk endef · line 106

Quoted 10 lines
boot/uboot/uboot.mk +1 -1
index ea77259..3dfcca3 100644
@@ -103,7 +103,7 @@ endef
 define UBOOT_INSTALL_IMAGES_CMDS
      cp -dpf $(@D)/$(UBOOT_BIN) $(BINARIES_DIR)/
      $(if $(BR2_TARGET_UBOOT_SPL),
-             cp -dpf $(@D)/$(BR2_TARGET_UBOOT_SPL_NAME) $(BINARIES_DIR)/)
+             cp -dpf $(@D)/spl/$(BR2_TARGET_UBOOT_SPL_NAME) $(BINARIES_DIR)/)

In the case of OMAP, the SPL gets generated in the main source directory. For which configuration do you see that it is installed only in the spl/ sub-directory?

I'm trying to use buildroot to create an image for a cubieboard
(http://cubieboard.org/).
In this case I have to use u-boot-sunxi and SPL gets generated only in spl/

Best,

--
Carlo Caione

#3 lore raw

PATCH 1/1 u-boot: u-boot SPL is usually under ./spl/

Dear Carlo Caione,

Quoted 7 lines · Carlo Caione
Quoted 3 lines

In the case of OMAP, the SPL gets generated in the main source directory. For which configuration do you see that it is installed only in the spl/ sub-directory?

I'm trying to use buildroot to create an image for a cubieboard
(http://cubieboard.org/).
In this case I have to use u-boot-sunxi and SPL gets generated only in spl/

Right, I tested this, and it gets installed in spl/.

What about setting BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl.bin" ?

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#4 lore raw

PATCH 1/1 u-boot: u-boot SPL is usually under ./spl/

Quoted 8 lines · Thomas Petazzoni

Dear Carlo Caione,

Quoted 4 lines · Carlo Caione
Quoted 3 lines

In the case of OMAP, the SPL gets generated in the main source directory. For which configuration do you see that it is installed only in the spl/ sub-directory?

Quoted 7 lines
Quoted 3 lines

I'm trying to use buildroot to create an image for a cubieboard
(http://cubieboard.org/).
In this case I have to use u-boot-sunxi and SPL gets generated only in spl/

Right, I tested this, and it gets installed in spl/.

What about setting BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl.bin" ?

Well, honestly I don't like it (not really clean) but I'll go for it if there is no other way :)
(BTW, IIRC MLO in OMAP is just spl/u-boot-spl.bin with an additional header)

Regards,

--
Carlo Caione

#5 lore raw

PATCH 1/1 u-boot: u-boot SPL is usually under ./spl/

Dear Carlo Caione,

Quoted 4 lines · Carlo Caione
Quoted 1 line

What about setting BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl.bin" ?

Well, honestly I don't like it (not really clean) but I'll go for it if there is no other way :)

Well, in this specific case, I think it's probably the out of tree uboot-sunxi thing that does not comply with normal U-Boot practices. I think in U-Boot mainline, the SPL, whatever its name is, is always finally installed in the main source directory at the end of the build.

If you really want, we can tune the boot/uboot.mk logic so that it search $(@D) and $(@D)/spl, but I would rather suggest to fix uboot-sunxi instead :)

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#6 lore raw

PATCH 1/1 u-boot: u-boot SPL is usually under ./spl/

In reply to Carlo Caione
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Carlo" == Carlo Caione <[email protected]> writes:

What about setting BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl.bin" ?

Carlo> Well, honestly I don't like it (not really clean) but I'll go for it Carlo> if there is no other way :)

Carlo> (BTW, IIRC MLO in OMAP is just spl/u-boot-spl.bin with an Carlo> additional header)

True, but the header is essential to get the ROM to use it.

I find it ok that the path is relative to the u-boot basedir.

Signature · 1 line
Bye, Peter Korsgaard