Use qemu_open / qemu_close in rng backend
PATCH 1/1 Use qemu_open / qemu_close in rng backend
In the rng backend use qemu_open and qemu_close rather than POSIX open/close.
Signed-off-by Stefan Berger <[email protected]>
backends/rng-random.c +2 -2
@@ -74,7 +74,7 @@ static void rng_random_opened(RngBackend *b, Error **errp)error_set (errp,QERR_INVALID_PARAMETER_VALUE ,"filename" ,"a valid filename" ); }else { - s->fd =open (s->filename,O_RDONLY |O_NONBLOCK ); + s->fd =qemu_open (s->filename,O_RDONLY |O_NONBLOCK );if (s->fd ==-1 ) {error_set (errp,QERR_OPEN_FILE_FAILED , s->filename);
@@ -130,7 +130,7 @@ static void rng_random_finalize(Object *obj)qemu_set_fd_handler (s->fd,NULL ,NULL ,NULL );if (s->fd !=-1 ) { -close (s->fd); +qemu_close (s->fd); }g_free (s->filename);
[don't you also need to cc the main qemu list, even for trivial patches?]
Quoted 4 lines · Stefan Berger
In the rng backend use
qemu_openandqemu_closerather than POSIX open/close.Signed-off-by Stefan Berger <[email protected]>
Reviewed-by Eric Blake <[email protected]>
Quoted 27 lines
backends/rng-random.c +1
-1@@ -74,7 +74,7 @@ static void rng_random_opened(RngBackend *b, Error **errp)error_set (errp,QERR_INVALID_PARAMETER_VALUE ,"filename" ,"a valid filename" ); }else { - s->fd =open (s->filename,O_RDONLY |O_NONBLOCK ); + s->fd =qemu_open (s->filename,O_RDONLY |O_NONBLOCK );if (s->fd ==-1 ) {error_set(errp, QERR_OPEN_FILE_FAILED, s->filename);backends/rng-random.c +1
-1@@ -130,7 +130,7 @@ static void rng_random_finalize(Object *obj)qemu_set_fd_handler (s->fd,NULL ,NULL ,NULL );if (s->fd !=-1 ) { -close (s->fd); +qemu_close (s->fd); }g_free (s->filename);
Signature · 2 lines
Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Stefan Hajnoczi
AppliedQuoted 4 lines · Stefan Berger
In the rng backend use
qemu_openandqemu_closerather than POSIX open/close.Signed-off-by Stefan Berger <[email protected]>
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan