ioatdma: make debug output more readable
PATCH 1/1 ioatdma: make debug output more readable
Making OP field a hex instead of integer to make it more readable. Also add the dump out of the NEXT field.
--- drivers/dma/ioat/dma.h | 2 +- drivers/dma/ioat/dma_v3.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
drivers/dma/ioat/dma.h +1 -1
@@ -179,7 +179,7 @@ __dump_desc_dbg(struct ioat_chan_common *chan, struct ioat_dma_descriptor *hw,struct device *dev =to_dev (chan);dev_dbg (dev,"desc[%d]: (%#llx->%#llx) cookie: %d flags: %#x" -" ctl: %#x (op: %d int_en: %d compl: %d)\n" , id, +" ctl: %#10.8x (op: %#x int_en: %d compl: %d)\n" , id, (unsigned long long ) tx->phys, (unsigned long long ) hw->next, tx->cookie, tx->flags, hw->ctl, hw->ctl_f.op, hw->ctl_f.int_en, hw->ctl_f.compl_write);
drivers/dma/ioat/dma_v3.c +2 -1
@@ -605,7 +605,7 @@ dump_pq_desc_dbg(struct ioat2_dma_chan *ioat, struct ioat_ring_ent *desc, structint i; dev_dbg(dev, "desc[%d]: (%#llx->%#llx) flags: %#x" - " sz: %#x ctl: %#x (op: %d int: %d compl: %d pq: '%s%s' src_cnt: %d)\n", + " sz: %#10.8x ctl: %#x (op: %#x int: %d compl: %d pq: '%s%s' src_cnt: %d)\n", desc_id(desc), (unsigned long long) desc->txd.phys, (unsigned long long) (pq_ex ? pq_ex->next : pq->next), desc->txd.flags, pq->size, pq->ctl, pq->ctl_f.op, pq->ctl_f.int_en,
@@ -617,6 +617,7 @@ dump_pq_desc_dbg(struct ioat2_dma_chan *ioat, struct ioat_ring_ent *desc, struct (unsigned long long) pq_get_src(descs, i), pq->coef[i]);dev_dbg (dev,"\tP: %#llx\n" , pq->p_addr);dev_dbg (dev,"\tQ: %#llx\n" , pq->q_addr); +dev_dbg (dev,"\tNEXT: %#llx\n" , pq->next); } static struct dma_async_tx_descriptor *
Quoted 45 lines · Dave Jiang
Making OP field a hex instead of integer to make it more readable. Also add
the dump out of the NEXT field.Signed-off-by Dave Jiang <[email protected]>---
drivers/dma/ioat/dma.h | 2 +- drivers/dma/ioat/dma_v3.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)drivers/dma/ioat/dma.h +1
-1@@ -179,7 +179,7 @@ __dump_desc_dbg(struct ioat_chan_common *chan, structioat_dma_descriptor *hw, struct device *dev = to_dev(chan); dev_dbg(dev, "desc[%d]: (%#llx->%#llx) cookie: %d flags: %#x" - " ctl: %#x (op: %d int_en: %d compl: %d)\n", id, + " ctl: %#10.8x (op: %#x int_en: %d compl: %d)\n", id, (unsigned long long) tx->phys, (unsigned long long) hw->next, tx->cookie, tx->flags,hw->ctl, hw->ctl_f.op, hw->ctl_f.int_en, hw->ctl_f.compl_write);drivers/dma/ioat/dma_v3.c +0
-0@@ -605,7 +605,7 @@ dump_pq_desc_dbg(struct ioat2_dma_chan *ioat, struct
ioat_ring_ent*desc, structint i; dev_dbg(dev, "desc[%d]: (%#llx->%#llx) flags: %#x"drivers/dma/ioat/dma_v3.c +0
-1- " sz: %#x ctl: %#x (op: %d int: %d compl: %d pq: '%s%s' src_cnt:%d)\n",
drivers/dma/ioat/dma_v3.c +1
-0+ " sz: %#10.8x ctl: %#x (op: %#x int: %d compl: %d pq: '%s%s' src_cnt:%d)\n",
desc_id(desc), (unsigned long long) desc->txd.phys, (unsigned long long) (pq_ex ? pq_ex->next : pq->next), desc->txd.flags, pq->size, pq->ctl, pq->ctl_f.op, pq->ctl_f.int_en,drivers/dma/ioat/dma_v3.c +0
-0@@ -617,6 +617,7 @@ dump_pq_desc_dbg(struct ioat2_dma_chan *ioat, struct
ioat_ring_ent*desc, struct(unsigned long long) pq_get_src(descs, i), pq->coef[i]); dev_dbg(dev, "\tP: %#llx\n", pq->p_addr); dev_dbg(dev, "\tQ: %#llx\n", pq->q_addr);
drivers/dma/ioat/dma_v3.c dump_pq_desc_dbg(struct ioat2_dma_chan *ioat, struct ioat_ring_ent *desc, struct · line 620
Quoted 1 line
drivers/dma/ioat/dma_v3.c +1
-0+dev_dbg (dev,"\tNEXT: %#llx\n" , pq->next);
Looks ok, did you want to distinguish when ->next is pointing to an extended descriptor?
Quoted 35 lines · Dan Williams
Quoted 32 lines · Dave Jiang
Making OP field a hex instead of integer to make it more readable. Also add
the dump out of the NEXT field.Signed-off-by Dave Jiang <[email protected]>---
drivers/dma/ioat/dma.h | 2 +- drivers/dma/ioat/dma_v3.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)drivers/dma/ioat/dma.h +1
-1@@ -179,7 +179,7 @@ __dump_desc_dbg(struct ioat_chan_common *chan, structioat_dma_descriptor *hw, struct device *dev = to_dev(chan); dev_dbg(dev, "desc[%d]: (%#llx->%#llx) cookie: %d flags: %#x" - " ctl: %#x (op: %d int_en: %d compl: %d)\n", id, + " ctl: %#10.8x (op: %#x int_en: %d compl: %d)\n", id, (unsigned long long) tx->phys, (unsigned long long) hw->next, tx->cookie, tx->flags,hw->ctl, hw->ctl_f.op, hw->ctl_f.int_en, hw->ctl_f.compl_write);drivers/dma/ioat/dma_v3.c +0
-0@@ -605,7 +605,7 @@ dump_pq_desc_dbg(struct ioat2_dma_chan *ioat, struct
ioat_ring_ent*desc, structint i;
Quoted 16 lines
Quoted 13 lines
dev_dbg(dev, "desc[%d]: (%#llx->%#llx) flags: %#x"drivers/dma/ioat/dma_v3.c +0
-1- " sz: %#x ctl: %#x (op: %d int: %d compl: %d pq: '%s%s' src_cnt:%d)\n",
drivers/dma/ioat/dma_v3.c +1
-0+ " sz: %#10.8x ctl: %#x (op: %#x int: %d compl: %d pq: '%s%s' src_cnt:%d)\n",
desc_id(desc), (unsigned long long) desc->txd.phys, (unsigned long long) (pq_ex ? pq_ex->next : pq->next), desc->txd.flags, pq->size, pq->ctl, pq->ctl_f.op, pq->ctl_f.int_en,drivers/dma/ioat/dma_v3.c +0
-0@@ -617,6 +617,7 @@ dump_pq_desc_dbg(struct ioat2_dma_chan *ioat, struct
ioat_ring_ent*desc, struct(unsigned long long) pq_get_src(descs, i), pq->coef[i]); dev_dbg(dev, "\tP: %#llx\n", pq->p_addr); dev_dbg(dev, "\tQ: %#llx\n", pq->q_addr);drivers/dma/ioat/dma_v3.c dump_pq_desc_dbg(struct ioat2_dma_chan *ioat, struct ioat_ring_ent *desc, struct · line 620
Quoted 1 line
drivers/dma/ioat/dma_v3.c +1
-0+dev_dbg (dev,"\tNEXT: %#llx\n" , pq->next);Looks ok, did you want to distinguish when ->next is pointing to an extended descriptor?
Probably a good idea. Let me add that
Quoted 4 lines · Dave Jiang
Making OP field a hex instead of integer to make it more readable. Also add the dump out of the NEXT field.
Signed-off-by Dave Jiang <[email protected]>
Applied thanks
Quoted 40 lines
--- drivers/dma/ioat/dma.h | 2 +- drivers/dma/ioat/dma_v3.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)drivers/dma/ioat/dma.h +1
-1@@ -179,7 +179,7 @@ __dump_desc_dbg(struct ioat_chan_common *chan, struct ioat_dma_descriptor *hw,struct device *dev =to_dev (chan);dev_dbg (dev,"desc[%d]: (%#llx->%#llx) cookie: %d flags: %#x" -" ctl: %#x (op: %d int_en: %d compl: %d)\n" , id, +" ctl: %#10.8x (op: %#x int_en: %d compl: %d)\n" , id, (unsigned long long ) tx->phys, (unsigned long long ) hw->next, tx->cookie, tx->flags, hw->ctl, hw->ctl_f.op, hw->ctl_f.int_en, hw->ctl_f.compl_write);drivers/dma/ioat/dma_v3.c +2
-1@@ -605,7 +605,7 @@ dump_pq_desc_dbg(struct ioat2_dma_chan *ioat, struct ioat_ring_ent *desc, structint i; dev_dbg(dev, "desc[%d]: (%#llx->%#llx) flags: %#x" - " sz: %#x ctl: %#x (op: %d int: %d compl: %d pq: '%s%s' src_cnt: %d)\n", + " sz: %#10.8x ctl: %#x (op: %#x int: %d compl: %d pq: '%s%s' src_cnt: %d)\n", desc_id(desc), (unsigned long long) desc->txd.phys, (unsigned long long) (pq_ex ? pq_ex->next : pq->next), desc->txd.flags, pq->size, pq->ctl, pq->ctl_f.op, pq->ctl_f.int_en,@@ -617,6 +617,7 @@ dump_pq_desc_dbg(struct ioat2_dma_chan *ioat, struct ioat_ring_ent *desc, struct (unsigned long long) pq_get_src(descs, i), pq->coef[i]);dev_dbg (dev,"\tP: %#llx\n" , pq->p_addr);dev_dbg (dev,"\tQ: %#llx\n" , pq->q_addr); +dev_dbg (dev,"\tNEXT: %#llx\n" , pq->next); } static struct dma_async_tx_descriptor *
Quoted 4 lines · Dave Jiang
Making OP field a hex instead of integer to make it more readable. Also add the dump out of the NEXT field.
Signed-off-by Dave Jiang <[email protected]>
Applied Thanks
Quoted 40 lines
--- drivers/dma/ioat/dma.h | 2 +- drivers/dma/ioat/dma_v3.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)drivers/dma/ioat/dma.h +1
-1@@ -179,7 +179,7 @@ __dump_desc_dbg(struct ioat_chan_common *chan, struct ioat_dma_descriptor *hw,struct device *dev =to_dev (chan);dev_dbg (dev,"desc[%d]: (%#llx->%#llx) cookie: %d flags: %#x" -" ctl: %#x (op: %d int_en: %d compl: %d)\n" , id, +" ctl: %#10.8x (op: %#x int_en: %d compl: %d)\n" , id, (unsigned long long ) tx->phys, (unsigned long long ) hw->next, tx->cookie, tx->flags, hw->ctl, hw->ctl_f.op, hw->ctl_f.int_en, hw->ctl_f.compl_write);drivers/dma/ioat/dma_v3.c +2
-1@@ -605,7 +605,7 @@ dump_pq_desc_dbg(struct ioat2_dma_chan *ioat, struct ioat_ring_ent *desc, structint i; dev_dbg(dev, "desc[%d]: (%#llx->%#llx) flags: %#x" - " sz: %#x ctl: %#x (op: %d int: %d compl: %d pq: '%s%s' src_cnt: %d)\n", + " sz: %#10.8x ctl: %#x (op: %#x int: %d compl: %d pq: '%s%s' src_cnt: %d)\n", desc_id(desc), (unsigned long long) desc->txd.phys, (unsigned long long) (pq_ex ? pq_ex->next : pq->next), desc->txd.flags, pq->size, pq->ctl, pq->ctl_f.op, pq->ctl_f.int_en,@@ -617,6 +617,7 @@ dump_pq_desc_dbg(struct ioat2_dma_chan *ioat, struct ioat_ring_ent *desc, struct (unsigned long long) pq_get_src(descs, i), pq->coef[i]);dev_dbg (dev,"\tP: %#llx\n" , pq->p_addr);dev_dbg (dev,"\tQ: %#llx\n" , pq->q_addr); +dev_dbg (dev,"\tNEXT: %#llx\n" , pq->next); } static struct dma_async_tx_descriptor *