am335x-evm: enable ext4
PATCH v2 1/3 am335x-evm: enable ext4
The kernel is loaded from an ext4 partition, not ext2 on beaglebone boards.
--- include/configs/am335x_evm.h | 1 + 1 file changed, 1 insertion(+)
include/configs/am335x_evm.h +1 -0
@@ -144,6 +144,7 @@#define CONFIG_DOS_PARTITION #define CONFIG_CMD_FAT #define CONFIG_CMD_EXT2 +#define CONFIG_CMD_EXT4 #define CONFIG_SPI #define CONFIG_OMAP3_SPI
Signature · 1 line
1.8.1.2
PATCH v2 2/3 am335x-evm: add support for BeagleBone Black DT name
--- include/configs/am335x_evm.h | 2 ++ 1 file changed, 2 insertions(+)
include/configs/am335x_evm.h +2 -0
@@ -86,6 +86,8 @@"findfdt=" \"if test $board_name = A335BONE; then " \"setenv fdtfile am335x-bone.dtb; fi; " \ +"if test $board_name = A335BNLT; then " \ +"setenv fdtfile am335x-bonelt.dtb; fi; " \"if test $board_name = A33515BB; then " \"setenv fdtfile am335x-evm.dtb; fi; " \"if test $board_name = A335X_SK; then " \
Signature · 1 line
1.8.1.2
PATCH v2 2/3 am335x-evm: add support for BeagleBone Black DT name
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Koen" == Koen Kooi <[email protected]> writes:
Koen> Signed-off-by: Koen Kooi <[email protected]> Koen> ---
Koen> include/configs/am335x_evm.h | 2 ++
Koen> 1 file changed, 2 insertions(+)
Koen> diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h Koen> index 2190a7d..951422c 100644
Koen> --- a/include/configs/am335x_evm.h
Koen> +++ b/include/configs/am335x_evm.h
Koen> @@ -86,6 +86,8 @@
Koen> "findfdt="\ Koen> "if test $board_name = A335BONE; then " \ Koen> "setenv fdtfile am335x-bone.dtb; fi; " \
Koen> + "if test $board_name = A335BNLT; then " \
Koen> + "setenv fdtfile am335x-bonelt.dtb; fi; " \
Where does the 'bonelt' name come from? Seems quite far from bone black to me.
Other than that it looks fine.
Signature · 1 line
Bye, Peter Korsgaard
PATCH v2 2/3 am335x-evm: add support for BeagleBone Black DT name
Op 17 feb. 2013 om 14:06 heeft Peter Korsgaard <[email protected]> het volgende geschreven:
Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Koen" == Koen Kooi <[email protected]> writes:
Koen> Signed-off-by: Koen Kooi <[email protected]> Koen> ---
Koen>include/configs/am335x_evm.h| 2 ++
Koen> 1 file changed, 2 insertions(+)Koen> diff --git
a/include/configs/am335x_evm.hb/include/configs/am335x_evm.hKoen> index 2190a7d..951422c 100644
Koen> ---a/include/configs/am335x_evm.h
Koen> +++b/include/configs/am335x_evm.h
Koen> @@ -86,6 +86,8 @@
Koen> "findfdt="\
Koen> "if test $board_name = A335BONE; then " \
Koen> "setenv fdtfile am335x-bone.dtb; fi; " \
Koen> + "if test $board_name = A335BNLT; then " \
Koen> + "setenv fdtfile am335x-bonelt.dtb; fi; " \
Quoted 2 lines
Where does the 'bonelt' name come from? Seems quite far from bone black to me.
It's the old name for it, it's also used in the eeprom
Quoted 7 lines
Other than that it looks fine.
Acked-by Peter Korsgaard <[email protected]>Signature · 1 line
Bye, Peter Korsgaard
PATCH v2 3/3 am335x-evm: switch to DT boot
In reply to Koen KooiThe findfdt method is being used to locate the right .dtb for the board and load it from /boot.
--- include/configs/am335x_evm.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
include/configs/am335x_evm.h +4 -1
@@ -79,7 +79,7 @@"loaduimage=ext2load mmc ${mmcdev}:2 ${loadaddr} ${bootfile}\0" \"mmcboot=echo Booting from mmc ...; " \"run mmcargs; " \ -"bootm ${loadaddr}\0" \ +"bootm ${loadaddr} - ${fdtaddr}\0" \"ramboot=echo Booting from ramdisk ...; " \"run ramargs; " \"bootm ${loadaddr}\0" \
@@ -93,7 +93,9 @@"if test $board_name = A335X_SK; then " \"setenv fdtfile am335x-evmsk.dtb; fi\0" \ + #define CONFIG_BOOTCOMMAND \ +"run findfdt; " \"mmc dev ${mmcdev}; if mmc rescan; then " \"echo SD/MMC found on device ${mmcdev};" \"if run loadbootenv; then " \
@@ -105,6 +107,7 @@"run uenvcmd;" \"fi;" \"if run loaduimage; then " \ +"ext2load mmc ${mmcdev}:2 ${fdtaddr} /boot/${fdtfile}; " \"run mmcboot;" \"fi;" \"fi;" \
Signature · 1 line
1.8.1.2
PATCH v2 3/3 am335x-evm: switch to DT boot
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Koen" == Koen Kooi <[email protected]> writes:
Koen> The findfdt method is being used to locate the right .dtb for the Koen> board and load it from /boot.
Signature · 1 line
Bye, Peter Korsgaard
PATCH v2 1/3 am335x-evm: enable ext4
In reply to Koen KooiQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Koen" == Koen Kooi <[email protected]> writes:
Koen> The kernel is loaded from an ext4 partition, not ext2 on beaglebone boards. Koen> Signed-off-by: Koen Kooi <[email protected]>
Koen> ---
Koen> include/configs/am335x_evm.h | 1 +
Koen> 1 file changed, 1 insertion(+)
Koen> diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h Koen> index 72459d8..2190a7d 100644
Koen> --- a/include/configs/am335x_evm.h
Koen> +++ b/include/configs/am335x_evm.h
Koen> @@ -144,6 +144,7 @@
Koen> #define CONFIG_DOS_PARTITION Koen> #define CONFIG_CMD_FAT Koen> #define CONFIG_CMD_EXT2
Koen> +#define CONFIG_CMD_EXT4
Shouldn't the bootcmd then also be changed to use ext4load instead? Why keep CMD_EXT2 enabled?
Signature · 1 line
Bye, Peter Korsgaard
PATCH v2 1/3 am335x-evm: enable ext4
Op 17 feb. 2013 om 14:03 heeft Peter Korsgaard <[email protected]> het volgende geschreven:
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Koen" == Koen Kooi <[email protected]> writes:
Koen> The kernel is loaded from an ext4 partition, not ext2 on beaglebone boards. Koen> Signed-off-by: Koen Kooi <[email protected]>
Koen> ---
Koen>include/configs/am335x_evm.h| 1 +
Koen> 1 file changed, 1 insertion(+)Koen> diff --git
a/include/configs/am335x_evm.hb/include/configs/am335x_evm.hKoen> index 72459d8..2190a7d 100644
Koen> ---a/include/configs/am335x_evm.h
Koen> +++b/include/configs/am335x_evm.h
Koen> @@ -144,6 +144,7 @@
Quoted 7 lines
Koen> #define CONFIG_DOS_PARTITION Koen> #define CONFIG_CMD_FAT Koen> #define CONFIG_CMD_EXT2Koen> +#define
CONFIG_CMD_EXT4Shouldn't the bootcmd then also be changed to use ext4load instead? Why keep
CMD_EXT2enabled?
that will be a followup patch
Quoted 3 lines
Signature · 2 lines
-- Bye, Peter Korsgaard
PATCH v2 1/3 am335x-evm: enable ext4
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Koen" == Koen Kooi <[email protected]> writes:
Koen> #define CONFIG_CMD_EXT2
Koen> +#define CONFIG_CMD_EXT4
Quoted 3 lines
Quoted 3 lines
Shouldn't the bootcmd then also be changed to use ext4load instead? Why keep
CMD_EXT2enabled?
Koen> that will be a followup patch
Ok. It imho makes sense to do both changes at once as they are strongly related and in the same file.
Signature · 1 line
Bye, Peter Korsgaard
PATCH v2 1/3 am335x-evm: enable ext4
Quoted 5 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Koen" == Koen Kooi <[email protected]> writes:
Koen> #define
CONFIG_CMD_EXT2
Koen> +#defineCONFIG_CMD_EXT4Quoted 1 line
Quoted 1 line
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
Shouldn't the bootcmd then also be changed to use ext4load instead? Why keep
CMD_EXT2enabled?Koen> that will be a followup patch
Ok. It imho makes sense to do both changes at once as they are strongly related and in the same file.
And we ought to add CONFIG_CMD_FS_GENERIC and just 'load' so that this can more easily work with folks still using FAT for boot.
Signature · 1 line
Tom