Add bzip2 to host-python when it is selected (aids in compiling nodejs)
PATCH v3 1/2 Add bzip2 to host-python when it is selected (aids in compiling nodejs)
Based off of patches posted by (and Signed-off-by): Jonathan Liu <[email protected]>
--- package/python/python.mk | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
package/python/python.mk +1 -2
@@ -30,7 +30,6 @@ HOST_PYTHON_CONF_OPT += \ --disable-gdbm \ --disable-bsddb \ --disable-test-modules \ - --disable-bz2 \ --disable-ssl HOST_PYTHON_MAKE_ENV = \
@@ -49,7 +48,7 @@ HOST_PYTHON_MAKE = $(MAKE1) PYTHON_DEPENDENCIES = host-python libffi -HOST_PYTHON_DEPENDENCIES = host-expat host-zlib +HOST_PYTHON_DEPENDENCIES = host-expat host-zlib host-bzip2 PYTHON_INSTALL_STAGING = YES
Signature · 1 line
1.7.6.5
PATCH v3 1/2 Add bzip2 to host-python when it is selected (aids in compiling nodejs)
Dear Daniel Price,
Quoted 3 lines · Daniel Price
Based off of patches posted by (and Signed-off-by): Jonathan Liu <[email protected]>
Signed-off-by Daniel Price <[email protected]>
If you add the attached patch to the nodejs package, then we no longer need the bz2 module in Python, at least not in the default nodejs build.
Thomas
Signature · 11 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: nodejs-remove-python-bz2-dependency.patch Type: text/x-patch Size: 824 bytes Desc: not available URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130304/ba1efdd2/attachment.bin>
PATCH v3 1/2 Add bzip2 to host-python when it is selected (aids in compiling nodejs)
Ok. I'm agnostic about how we solve this. I can incorporate your
patch. So do I append your "Signed-off-by" to mine? I don't want to
do it the wrong way.
-dp
Quoted 10 lines · Thomas Petazzoni
Dear Daniel Price,
Quoted 3 lines · Daniel Price
Based off of patches posted by (and Signed-off-by): Jonathan Liu <[email protected]>
Signed-off-by Daniel Price <[email protected]>If you add the attached patch to the nodejs package, then we no longer need the bz2 module in Python, at least not in the default nodejs build.
Quoted 6 lines
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
Daniel.Price at gmail.com; Twitter: @danielbprice
PATCH v3 1/2 Add bzip2 to host-python when it is selected (aids in compiling nodejs)
Dear Daniel Price,
Quoted 3 lines · Daniel Price
Ok. I'm agnostic about how we solve this. I can incorporate your
patch. So do I append your "Signed-off-by" to mine? I don't want to
do it the wrong way.
Yes, you can keep my Signed-off-by inside the nodejs-remove-python-bz2-dependency.patch file, and add your own after mine. No need to append my Signed-off-by on the global nodejs patch, though.
Best regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com