Skip to contentSkip to conversation

ARM: OMAP: RX-51: add missing USB phy binding

PATCH New Aaro Koskinen 4 participants 5 messages Mar 5, 2013 – Mar 6, 2013

Subsystems (3)
lore
Share & tools
lore

Aaro Koskinen

author maintainer
#0 lore raw

PATCH 1/1 ARM: OMAP: RX-51: add missing USB phy binding

Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to add phy binding for RX-51, and as a result USB does not work anymore on 3.9-rc1. Add the missing binding.

---
 arch/arm/mach-omap2/board-rx51.c |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-omap2/board-rx51.c +2 -0
index f7c4616..d2ea68e 100644
@@ -17,6 +17,7 @@
 #include <linux/io.h>
 #include <linux/gpio.h>
 #include <linux/leds.h>
+#include <linux/usb/phy.h>
 #include <linux/usb/musb.h>
 #include <linux/platform_data/spi-omap2-mcspi.h>
 
@@ -98,6 +99,7 @@ static void __init rx51_init(void)
 	sdrc_params = nokia_get_sdram_timings();
 	omap_sdrc_init(sdrc_params, sdrc_params);
 
+	usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
 	usb_musb_init(&musb_board_data);
 	rx51_peripherals_init();
 
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 ARM: OMAP: RX-51: add missing USB phy binding

Quoted 5 lines · Aaro Koskinen

Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to add phy binding for RX-51, and as a result USB does not work anymore on 3.9-rc1. Add the missing binding.

Quoted 31 lines
---
 arch/arm/mach-omap2/board-rx51.c |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-omap2/board-rx51.c +2 -0
index f7c4616..d2ea68e 100644
@@ -17,6 +17,7 @@
 #include <linux/io.h>
 #include <linux/gpio.h>
 #include <linux/leds.h>
+#include <linux/usb/phy.h>
 #include <linux/usb/musb.h>
 #include <linux/platform_data/spi-omap2-mcspi.h>
 
@@ -98,6 +99,7 @@ static void __init rx51_init(void)
 	sdrc_params = nokia_get_sdram_timings();
 	omap_sdrc_init(sdrc_params, sdrc_params);
 
+	usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
 	usb_musb_init(&musb_board_data);
 	rx51_peripherals_init();
 
Signature · 6 lines
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130305/e19e9ba6/attachment.sig>
#2 lore raw

PATCH 1/1 ARM: OMAP: RX-51: add missing USB phy binding

Quoted 8 lines · Felipe Balbi
Quoted 5 lines · Aaro Koskinen

Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to add phy binding for RX-51, and as a result USB does not work anymore on 3.9-rc1. Add the missing binding.

Quoted 33 lines
Quoted 32 lines
---
  arch/arm/mach-omap2/board-rx51.c |    2 ++
  1 file changed, 2 insertions(+)
arch/arm/mach-omap2/board-rx51.c +2 -1
index f7c4616..d2ea68e 100644
@@ -17,6 +17,7 @@
  #include <linux/io.h>
  #include <linux/gpio.h>
  #include <linux/leds.h>
+#include <linux/usb/phy.h>
  #include <linux/usb/musb.h>
  #include <linux/platform_data/spi-omap2-mcspi.h>
 
@@ -98,6 +99,7 @@ static void __init rx51_init(void)
  	sdrc_params = nokia_get_sdram_timings();
  	omap_sdrc_init(sdrc_params, sdrc_params);
 
+	usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
  	usb_musb_init(&musb_board_data);
  	rx51_peripherals_init();
 
--

1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#3 lore raw

PATCH 1/1 ARM: OMAP: RX-51: add missing USB phy binding

Quoted 10 lines · kishon
Quoted 8 lines · Felipe Balbi
Quoted 5 lines · Aaro Koskinen

Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to add phy binding for RX-51, and as a result USB does not work anymore on 3.9-rc1. Add the missing binding.

Thanks, applying into omap-for-v3.9-rc1/fixes.

Regards,

Tony

Quoted 33 lines
Quoted 32 lines
Quoted 31 lines
---
 arch/arm/mach-omap2/board-rx51.c |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-omap2/board-rx51.c +2 -1
index f7c4616..d2ea68e 100644
@@ -17,6 +17,7 @@
 #include <linux/io.h>
 #include <linux/gpio.h>
 #include <linux/leds.h>
+#include <linux/usb/phy.h>
 #include <linux/usb/musb.h>
 #include <linux/platform_data/spi-omap2-mcspi.h>
 
@@ -98,6 +99,7 @@ static void __init rx51_init(void)
 	sdrc_params = nokia_get_sdram_timings();
 	omap_sdrc_init(sdrc_params, sdrc_params);
 
+	usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
 	usb_musb_init(&musb_board_data);
 	rx51_peripherals_init();
 
--

1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw

PATCH 1/1 ARM: OMAP: RX-51: add missing USB phy binding

In reply to kishon

Hi,

Quoted 10 lines · kishon
Quoted 8 lines · Felipe Balbi
Quoted 5 lines · Aaro Koskinen

Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to add phy binding for RX-51, and as a result USB does not work anymore on 3.9-rc1. Add the missing binding.

Btw I dint add usb_bind_phy for board-am3517evm.c, board-ti8168evm.c too since those board files also dint have any reference to twl4030/twl6030. Can someone let me know what phy these platforms use or provide a patch for the same?

Thanks
Kishon