ARM: Push selects for TWD/SCU into machine entries
Subsystems (8)
PATCH v2 1/1 ARM: Push selects for TWD/SCU into machine entries
The TWD and SCU configs are selected by default as long as MSM_SCORPIONMP is false and/or MCT is false. Implementing the logic this way certainly saves lines in the Kconfig but it precludes those machines which select MSM_SCORPIONMP or MCT from participating in the single zImage effort because when those machines are combined with other SMP capable machines the TWD and SCU are no longer selected by default.
Push the select out to the machine entries so that we can compile these machines together and still select the appropriate configs.
---
Resending to collect some more acks.
arch/arm/Kconfig | 8 ++++++-- arch/arm/mach-exynos/Kconfig | 2 ++ arch/arm/mach-highbank/Kconfig | 1 + arch/arm/mach-imx/Kconfig | 3 ++- arch/arm/mach-msm/Kconfig | 7 ++----- arch/arm/mach-omap2/Kconfig | 2 ++ arch/arm/mach-prima2/Kconfig | 1 + arch/arm/mach-realview/Kconfig | 8 ++++++++ arch/arm/mach-vexpress/Kconfig | 2 ++ arch/arm/plat-spear/Kconfig | 2 ++ 10 files changed, 28 insertions(+), 8 deletions(-)
arch/arm/Kconfig +6 -2
@@ -672,6 +672,8 @@ config ARCH_TEGRA select CLKSRC_OF select COMMON_CLK select GENERIC_CLOCKEVENTS + select HAVE_ARM_SCU if SMP + select HAVE_ARM_TWD if LOCAL_TIMERS select HAVE_CLK select HAVE_SMP select MIGHT_HAVE_CACHE_L2X0
@@ -718,6 +720,8 @@ config ARCH_SHMOBILE bool "Renesas SH-Mobile / R-Mobile" select CLKDEV_LOOKUP select GENERIC_CLOCKEVENTS + select HAVE_ARM_SCU if SMP + select HAVE_ARM_TWD if LOCAL_TIMERS select HAVE_CLK select HAVE_MACH_CLKDEV select HAVE_SMP
@@ -910,6 +914,8 @@ config ARCH_U8500 select CLKDEV_LOOKUP select CPU_V7 select GENERIC_CLOCKEVENTS + select HAVE_ARM_SCU if SMP + select HAVE_ARM_TWD if LOCAL_TIMERS select HAVE_SMP select MIGHT_HAVE_CACHE_L2X0 select SPARSE_IRQ
@@ -1526,7 +1532,6 @@ config SMP depends on GENERIC_CLOCKEVENTS depends on HAVE_SMP depends on MMU - select HAVE_ARM_SCU if !ARCH_MSM_SCORPIONMP select USE_GENERIC_SMP_HELPERS help This enables support for systems with more than one CPU. If you have
@@ -1650,7 +1655,6 @@ config LOCAL_TIMERS bool "Use local timer interrupts" depends on SMP default y - select HAVE_ARM_TWD if (!ARCH_MSM_SCORPIONMP && !EXYNOS4_MCT) help Enable support for local timers on SMP platforms, rather then the legacy IPI broadcast method. Local timers allows the system
arch/arm/mach-exynos/Kconfig +2 -0
@@ -14,6 +14,7 @@ menu "SAMSUNG EXYNOS SoCs Support" config ARCH_EXYNOS4 bool "SAMSUNG EXYNOS4" default y + select HAVE_ARM_SCU if SMP select HAVE_SMP select MIGHT_HAVE_CACHE_L2X0 help
@@ -21,6 +22,7 @@ config ARCH_EXYNOS4 config ARCH_EXYNOS5 bool "SAMSUNG EXYNOS5" + select HAVE_ARM_SCU if SMP select HAVE_SMP help Samsung EXYNOS5 (Cortex-A15) SoC based systems
arch/arm/mach-highbank/Kconfig +1 -0
@@ -12,6 +12,7 @@ config ARCH_HIGHBANK select CPU_V7 select GENERIC_CLOCKEVENTS select HAVE_ARM_SCU + select HAVE_ARM_TWD if LOCAL_TIMERS select HAVE_SMP select MAILBOX select PL320_MBOX
arch/arm/mach-imx/Kconfig +2 -1
@@ -811,7 +811,8 @@ config SOC_IMX6Q select ARM_GIC select COMMON_CLK select CPU_V7 - select HAVE_ARM_SCU + select HAVE_ARM_SCU if SMP + select HAVE_ARM_TWD if LOCAL_TIMERS select HAVE_CAN_FLEXCAN if CAN select HAVE_IMX_GPC select HAVE_IMX_MMDC
arch/arm/mach-msm/Kconfig +2 -5
@@ -44,10 +44,10 @@ endchoice config ARCH_MSM8X60 bool "MSM8X60" - select ARCH_MSM_SCORPIONMP select ARM_GIC select CPU_V7 select GPIO_MSM_V2 + select HAVE_SMP select MSM_GPIOMUX select MSM_SCM if SMP select MSM_V2_TLMM
@@ -55,9 +55,9 @@ config ARCH_MSM8X60 config ARCH_MSM8960 bool "MSM8960" - select ARCH_MSM_SCORPIONMP select ARM_GIC select CPU_V7 + select HAVE_SMP select MSM_GPIOMUX select MSM_SCM if SMP select MSM_V2_TLMM
@@ -68,9 +68,6 @@ config MSM_HAS_DEBUG_UART_HS config MSM_SOC_REV_A bool -config ARCH_MSM_SCORPIONMP - bool - select HAVE_SMP config ARCH_MSM_ARM11 bool
arch/arm/mach-omap2/Kconfig +2 -0
@@ -87,6 +87,8 @@ config ARCH_OMAP4 select ARM_GIC select CACHE_L2X0 select CPU_V7 + select HAVE_ARM_SCU if SMP + select HAVE_ARM_TWD if LOCAL_TIMERS select HAVE_SMP select LOCAL_TIMERS if SMP select OMAP_INTERCONNECT
arch/arm/mach-prima2/Kconfig +1 -0
@@ -16,6 +16,7 @@ config ARCH_MARCO default y select ARM_GIC select CPU_V7 + select HAVE_ARM_SCU if SMP select HAVE_SMP select SMP_ON_UP help
arch/arm/mach-realview/Kconfig +8 -0
@@ -12,6 +12,8 @@ config REALVIEW_EB_A9MP bool "Support Multicore Cortex-A9 Tile" depends on MACH_REALVIEW_EB select CPU_V7 + select HAVE_ARM_SCU if SMP + select HAVE_ARM_TWD if LOCAL_TIMERS select HAVE_SMP select MIGHT_HAVE_CACHE_L2X0 help
@@ -23,6 +25,8 @@ config REALVIEW_EB_ARM11MP depends on MACH_REALVIEW_EB select ARCH_HAS_BARRIERS if SMP select CPU_V6K + select HAVE_ARM_SCU if SMP + select HAVE_ARM_TWD if LOCAL_TIMERS select HAVE_SMP select MIGHT_HAVE_CACHE_L2X0 help
@@ -43,6 +47,8 @@ config MACH_REALVIEW_PB11MP select ARCH_HAS_BARRIERS if SMP select ARM_GIC select CPU_V6K + select HAVE_ARM_SCU if SMP + select HAVE_ARM_TWD if LOCAL_TIMERS select HAVE_PATA_PLATFORM select HAVE_SMP select MIGHT_HAVE_CACHE_L2X0
@@ -85,6 +91,8 @@ config MACH_REALVIEW_PBX bool "Support RealView(R) Platform Baseboard Explore" select ARCH_SPARSEMEM_ENABLE if CPU_V7 && !REALVIEW_HIGH_PHYS_OFFSET select ARM_GIC + select HAVE_ARM_SCU if SMP + select HAVE_ARM_TWD if LOCAL_TIMERS select HAVE_PATA_PLATFORM select HAVE_SMP select MIGHT_HAVE_CACHE_L2X0
arch/arm/mach-vexpress/Kconfig +2 -0
@@ -9,6 +9,8 @@ config ARCH_VEXPRESS select COMMON_CLK_VERSATILE select CPU_V7 select GENERIC_CLOCKEVENTS + select HAVE_ARM_SCU if SMP + select HAVE_ARM_TWD if LOCAL_TIMERS select HAVE_CLK select HAVE_PATA_PLATFORM select HAVE_SMP
arch/arm/plat-spear/Kconfig +2 -0
@@ -14,6 +14,8 @@ config ARCH_SPEAR13XX select ARM_GIC select CPU_V7 select GPIO_SPEAR_SPICS + select HAVE_ARM_SCU if SMP + select HAVE_ARM_TWD if LOCAL_TIMERS select HAVE_SMP select MIGHT_HAVE_CACHE_L2X0 select PINCTRL
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Quoted 8 lines · Stephen Boyd
The TWD and SCU configs are selected by default as long as
MSM_SCORPIONMPis false and/or MCT is false. Implementing the logic this way certainly saves lines in theKconfigbut it precludes those machines which selectMSM_SCORPIONMPor MCT from participating in the single zImage effort because when those machines are combined with other SMP capable machines the TWD and SCU are no longer selected by default.
Quoted 4 lines
Push the select out to the machine entries so that we can compile these machines together and still select the appropriate configs.
Resending to collect some more acks.
Seems simple enough it doesn't really need many, but for Tegra,
Which kernel is this going into? It's possible Tegra will get converted to multi-platform in 3.10, which might move that main ARCH_TEGRA block from arch/arm/Kconfig into arch/arm/mach-tegra/Kconfig, although I suppose it doesn't /have/ to move it. I think some/all(?) other multi-platform conversions have moved their main Kconfig option like that though.
Quoted 10 lines · Stephen Warren
Seems simple enough it doesn't really need many, but for Tegra,
Acked-by Stephen Warren <[email protected]>Which kernel is this going into? It's possible Tegra will get converted to multi-platform in 3.10, which might move that main
ARCH_TEGRAblock fromarch/arm/Kconfigintoarch/arm/mach-tegra/Kconfig, although I suppose it doesn't /have/ to move it. I think some/all(?) other multi-platform conversions have moved their mainKconfigoption like that though.
Thanks. I'm hoping that Arnd/Olof can pick this up. I'm not sure which version it will go into.
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Quoted 12 lines · Stephen Boyd
Quoted 10 lines · Stephen Warren
Seems simple enough it doesn't really need many, but for Tegra,
Acked-by Stephen Warren <[email protected]>Which kernel is this going into? It's possible Tegra will get converted to multi-platform in 3.10, which might move that main
ARCH_TEGRAblock fromarch/arm/Kconfigintoarch/arm/mach-tegra/Kconfig, although I suppose it doesn't have to move it. I think some/all(?) other multi-platform conversions have moved their mainKconfigoption like that though.
Quoted 3 lines
Thanks. I'm hoping that Arnd/Olof can pick this up. I'm not sure which version it will go into.
Hmm, it certainly looks useful to me. I think it should go into the next cleanup branch as a base, so others can build on top of it. We will also need it for the Exynos multiplatform patches that I hope can land in 3.10 as well.
Sneaking it in through the fixes branch would make life easier for us, but it doesn't feel right.
Arnd
Quoted 14 lines · Arnd Bergmann
Quoted 4 lines · Stephen Boyd
Quoted 3 lines · Stephen Warren
Seems simple enough it doesn't really need many, but for Tegra,
Acked-by Stephen Warren <[email protected]>Quoted 9 lines
Quoted 6 lines
Which kernel is this going into? It's possible Tegra will get converted to multi-platform in 3.10, which might move that main
ARCH_TEGRAblock fromarch/arm/Kconfigintoarch/arm/mach-tegra/Kconfig, although I suppose it doesn't have to move it. I think some/all(?) other multi-platform conversions have moved their mainKconfigoption like that though.Thanks. I'm hoping that Arnd/Olof can pick this up. I'm not sure which version it will go into.
Quoted 7 lines
Hmm, it certainly looks useful to me. I think it should go into the next cleanup branch as a base, so others can build on top of it. We will also need it for the Exynos multiplatform patches that I hope can land in 3.10 as well.
Sneaking it in through the fixes branch would make life easier for us, but it doesn't feel right.
Arnd, can you pick this up into the arm-soc tree now? It would be good to get this into next so that conflicts are avoided later on.
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Quoted 20 lines · Stephen Boyd
Quoted 19 lines · Arnd Bergmann
Quoted 4 lines · Stephen Boyd
Quoted 3 lines · Stephen Warren
Seems simple enough it doesn't really need many, but for Tegra,
Acked-by Stephen Warren <[email protected]>Quoted 9 lines
Quoted 6 lines
Which kernel is this going into? It's possible Tegra will get converted to multi-platform in 3.10, which might move that main
ARCH_TEGRAblock fromarch/arm/Kconfigintoarch/arm/mach-tegra/Kconfig, although I suppose it doesn't have to move it. I think some/all(?) other multi-platform conversions have moved their mainKconfigoption like that though.Thanks. I'm hoping that Arnd/Olof can pick this up. I'm not sure which version it will go into.
Hmm, it certainly looks useful to me. I think it should go into the next cleanup branch as a base, so others can build on top of it. We will also need it for the Exynos multiplatform patches that I hope can land in 3.10 as well.
Quoted 5 lines
Quoted 2 lines
Sneaking it in through the fixes branch would make life easier for us, but it doesn't feel right.
Arnd, can you pick this up into the arm-soc tree now? It would be good to get this into next so that conflicts are avoided later on.
Arnd?
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Quoted 21 lines · Stephen Boyd
Quoted 20 lines · Stephen Boyd
Quoted 19 lines · Arnd Bergmann
Quoted 4 lines · Stephen Boyd
Quoted 3 lines · Stephen Warren
Seems simple enough it doesn't really need many, but for Tegra,
Acked-by Stephen Warren <[email protected]>Quoted 9 lines
Quoted 6 lines
Which kernel is this going into? It's possible Tegra will get converted to multi-platform in 3.10, which might move that main
ARCH_TEGRAblock fromarch/arm/Kconfigintoarch/arm/mach-tegra/Kconfig, although I suppose it doesn't have to move it. I think some/all(?) other multi-platform conversions have moved their mainKconfigoption like that though.Thanks. I'm hoping that Arnd/Olof can pick this up. I'm not sure which version it will go into.
Hmm, it certainly looks useful to me. I think it should go into the next cleanup branch as a base, so others can build on top of it. We will also need it for the Exynos multiplatform patches that I hope can land in 3.10 as well.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Sneaking it in through the fixes branch would make life easier for us, but it doesn't feel right.
Arnd, can you pick this up into the arm-soc tree now? It would be good to get this into next so that conflicts are avoided later on.
Arnd?
Ping?
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Arnd Bergmann
AppliedQuoted 10 lines · Stephen Boyd
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Sneaking it in through the fixes branch would make life easier for us, but it doesn't feel right.
Arnd, can you pick this up into the arm-soc tree now? It would be good to get this into next so that conflicts are avoided later on.
Arnd?
Ping?
Sorry for the long delay, you scrolled down from my unread emails twice.
Three tips for you to make it more likely to get a fast reaction time:
* Send the original patch to Olof and me, not just the reply to the on-list patch.
* Use the arm at kernel.org alias to reach us, since that will make the email go into the right folder
* Use the [GIT PULL] keyword in the subject line, ideally sending a pull request as well, instead of a separate email. While we do apply emails, It's often batch processing to apply everything and then we scan for emails that have PULL in the subject, while others can get lost.
I've applied it to the next/soc branch now.
Arnd
Quoted 2 lines · Arnd Bergmann
I've applied it to the next/soc branch now.
I just made up my mind again after I got a few merge conflicts. I have added it to the next/multiplatform branch now instead of next/soc, since a few of the Kconfig entries changed in this patch are moved to other files in that branch.
I've also added an entry for mach-zynq, which has gained SMP support in the meantime. I assume it uses TWD/SCU as it is otherwise rather close to the ARM reference platforms.
Arnd