Skip to contentSkip to conversation

lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

PATCH New Jingoo Han 2 participants 2 messages Mar 6, 2013 PCI

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

T24gV2VkbmVzZGF5LCBNYXJjaCAwNiwgMjAxMyA1OjI2IFBNLCBUaG9tYXMgUGV0YXp6b25pIHdy b3RlOg0KPiANCj4gRGVhciBKaW5nb28gSGFuLA0KPiANCj4gT24gV2VkLCAwNiBNYXIgMjAxMyAw NjoyODowOCArMDAwMCAoR01UKSwgSmluZ29vIEhhbiB3cm90ZToNCj4gDQo+ID4gU29ycnksIEkg ZGlkIG5vdCBrbm93IHRoYXQgeW91IHN1Ym1pdHRlZCB0aGUgcGF0Y2guDQo+IA0KPiBObyBwcm9i bGVtLCBJJ20gaGFwcHkgdG8gaGF2ZSBvbmUgbGVzcyBwYXRjaCB0byBjYXJyeSBpbiBteSBQQ0ll IHBhdGNoDQo+IHNldCA6KQ0KDQpUaGFuayB5b3UgOikNCg0KPiANCj4gPiBMaWtlIHlvdSwgSSBh bSBkZXZlbG9waW5nIFBDSWUgSG9zdCBkcml2ZXIuDQo+IA0KPiBKdXN0IGN1cmlvdXMsIGRvIHlv dSBhbHJlYWR5IGhhdmUgc29tZSBjb2RlPyBUaGllcnJ5IFJlZGluZyBhbmQgbXlzZWxmDQo+IGhh dmUgYmVlbiBsb29raW5nIGF0IGVhY2ggb3RoZXIncyBQQ0llIGhvc3QgZHJpdmVyIHNpbmNlIGEg d2hpbGUgaW4NCj4gb3JkZXIgdG8gbWFrZSBzb21lIGNvbnNpc3RlbnQgY2hvaWNlcyB3aGVyZSBw b3NzaWJsZS4gSXQgd291bGQgYmUgZ29vZA0KPiB0byBzZWUgeW91ciBjb2RlIGFzIHdlbGwuDQoN ClllcywgSSBhbSBkZXZlbG9waW5nIGEgUENJZSBkcml2ZXIgZm9yIFNhbXN1bmcgRXh5bm9zIFNv Q3MuDQpBbHNvLCAyIGRheXMgYWdvLCBJIHN1Ym1pdHRlZCB0aGUgUENJZSBkcml2ZXIuDQoNCmh0 dHA6Ly93d3cuc3Bpbmljcy5uZXQvbGlzdHMvbGludXgtcGNpL21zZzIwNTQ4Lmh0bWwNCmh0dHA6 Ly93d3cuc3Bpbmljcy5uZXQvbGlzdHMvbGludXgtcGNpL21zZzIwNTQ5Lmh0bWwNCg0KSWYgc29t ZW9uZSBsb29rIGF0IG15IGNvZGUsIGl0IHdpbGwgYmUgdmVyeSBoZWxwZnVsLg0KVGhhbmsgeW91 IDopDQoNCkJlc3QgcmVnYXJkcywNCkppbmdvbyBIYW4NCg0KPiANCj4gQmVzdCByZWdhcmRzLA0K PiANCj4gVGhvbWFzDQo+IC0tDQo+IFRob21hcyBQZXRhenpvbmksIEZyZWUgRWxlY3Ryb25zDQo+ IEtlcm5lbCwgZHJpdmVycywgcmVhbC10aW1lIGFuZCBlbWJlZGRlZCBMaW51eA0KPiBkZXZlbG9w bWVudCwgY29uc3VsdGluZywgdHJhaW5pbmcgYW5kIHN1cHBvcnQuDQo+IGh0dHA6Ly9mcmVlLWVs ZWN0cm9ucy5jb20NCg==

#1 lore raw

PATCH 5/32 lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

Quoted 7 lines · Jingoo Han

Yes, I am developing a PCIe driver for Samsung Exynos SoCs. Also, 2 days ago, I submitted the PCIe driver.

http://www.spinics.net/lists/linux-pci/msg20548.html
http://www.spinics.net/lists/linux-pci/msg20549.html

If someone look at my code, it will be very helpful.

I took a quick peek at your DT bindings and I think they are way off base. You need to read the thread(s) related to the new Armada and Tegra drivers. Your bindings should look closer to them.

You need to have DT bindings that follow the OF PCI requirements.

You need to determine if your hardware follows the PCI-SIG requirements and includes a root port bridge config space, this will guide if you need to use seperate PCI domains and DT stanzas, or if a single domain and stanza should be used.

Please include lspci output in future commit messages

If you CC me the next time you post these patches I may be able to try and help a bit, but lets start a new thread for that sort of discussion. :)

Regards,
Jason