Skip to contentSkip to conversation

buildtar: Add ARCH to the archive name

PATCH In review Borislav Petkov 3 participants 6 messages Mar 6, 2013 – Sep 12, 2013 1 message not in the archive Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 buildtar: Add ARCH to the archive name

From: Borislav Petkov <[email protected]>

When dealing with multiple sub-arches (like 32- and 64-bit on x86, for example) generating a bunch of kernel tar archives with the same name but for different sub-arches could get confusing and error-prone. Also, the build process could overwrite otherwise unrelated builds and you probably don't want that. So, add the architecture to the archive name for more clarity and less shoot-yourself-in-the-foot practices.

---
 scripts/package/buildtar | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/package/buildtar +1 -1
index 62d8234f8787..cdd9bb909bcd 100644
@@ -16,7 +16,7 @@ set -e
 # Some variables and settings used throughout the script
 #
 tmpdir="${objtree}/tar-install"
-tarball="${objtree}/linux-${KERNELRELEASE}.tar"
+tarball="${objtree}/linux-${KERNELRELEASE}-${ARCH}.tar"
 
 
 #
Signature · 1 line
1.8.1.3.535.ga923c31
#1 lore raw
Quoted 10 lines · Borislav Petkov

From: Borislav Petkov <[email protected]>

When dealing with multiple sub-arches (like 32- and 64-bit on x86, for example) generating a bunch of kernel tar archives with the same name but for different sub-arches could get confusing and error-prone. Also, the build process could overwrite otherwise unrelated builds and you probably don't want that. So, add the architecture to the archive name for more clarity and less shoot-yourself-in-the-foot practices.

Good idea, but I already hear people yelling about their scripts that break with this change :)

Joerg

#2 lore raw
Quoted 2 lines · Joerg Roedel

Good idea, but I already hear people yelling about their scripts that break with this change :)

They better fix them then. :-)

Signature · 5 lines
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
#3 lore raw
Quoted 5 lines · Borislav Petkov
Quoted 2 lines · Joerg Roedel

Good idea, but I already hear people yelling about their scripts that break with this change :)

They better fix them then. :-)

OK, I applied the patch to kbuild.git#misc. Let's see how many people protest...

Michal

#4 lore raw
Quoted 9 lines · Michal Marek
Quoted 5 lines · Borislav Petkov
Quoted 2 lines · Joerg Roedel

Good idea, but I already hear people yelling about their scripts that break with this change :)

They better fix them then. :-)

OK, I applied the patch to kbuild.git#misc. Let's see how many people protest...

Yeah, leave it in there for 3.10 so that it sees a whole cycle of testing in -next and what not, so that we can see who complains. :)

Thanks.

Signature · 5 lines
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

A message that is not in the archive (sent off-list or not yet received): CAKA=qzZRfSD33u4cXvpnzQn5isNB4iNY4cibeAwY46gyFmMHhg@mail.gmail.com

#6 lore raw
Quoted 7 lines · Josh Hunt

I didn't take the time to build the rpm pkg, but deb-pkg produces files like:

linux-image-3.10.0-rc7_3.10.0-rc7-26_amd64.deb

tarbz2-pkg now produces files with the name of:
linux-3.10.0-rc7-x86.tar.bz2

Right, I'm not really happy with this solution too because builds which don't supply ARCH on the command line add "x86" to the archive name and my intention was to have either "i386" or "x86_64" appended to the archive name so that when building a bunch of different kernel packages, I can know which is 32-bit and which is 64-bit.

Having it say "x86" doesn't tell me all that much. Whether it has "-" or an "_" prepended I don't care.

So I'll go and revisit this thing. I'll add you to CC for feedback since your script got broke :)

And, btw, other suggestions are appreciated too.

Thanks.

Signature · 2 lines
Regards/Gruss,
Boris.