Added comments to explain watchdog_disabled variable
PATCH 1/1 Added comments to explain watchdog_disabled variable
From: anish kumar <[email protected]>
This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is multifold. Uses are:
1. Check if smpboot_register_percpu_thread function passed.
2. Makes sure that user enables and disables the watchdog in sequence i.e. enable watchdog->disable watchdog->enable watchdog
Unlike enable watchdog->enable watchdog which is wrong.
--- kernel/watchdog.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
kernel/watchdog.c +5 -0
@@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int write,return ret;set_sample_period (); +/* +* Watchdog threads shouldn't be enabled if they are +* disabled.'watchdog_disabled' variable check in +* watchdog_*_all_cpus() function takes care of this. +*/ if (watchdog_enabled && watchdog_thresh)watchdog_enable_all_cpus ();else
Signature · 1 line
1.7.1
Quoted 19 lines · anish kumar
From: anish kumar <[email protected]>
This
watchdog_disabledflag is bit of cryptic.Howerver it's usefullnes is multifold. Uses are:
1. Check ifsmpboot_register_percpu_threadfunction passed.
2. Makes sure that user enables and disables the watchdog in sequence i.e. enablewatchdog->disablewatchdog->enablewatchdog
Unlike enablewatchdog->enablewatchdog which is wrong.Signed-off-by anish kumar <[email protected]>--- kernel/watchdog.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)kernel/watchdog.c +0
-0
kernel/watchdog.c int proc_dowatchdog(struct ctl_table *table, int write, · line 523
Quoted 6 lines
kernel/watchdog.c +3
-0@@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int write,return ret;set_sample_period (); +/* +* Watchdog threads shouldn't be enabled if they are +* disabled.'watchdog_disabled' variable check in
Missing a 'The' ^^^
Other than that,
Quoted 29 lines · Don Zickus
Quoted 19 lines · anish kumar
From: anish kumar <[email protected]>
This
watchdog_disabledflag is bit of cryptic.Howerver it's usefullnes is multifold. Uses are:
1. Check ifsmpboot_register_percpu_threadfunction passed.
2. Makes sure that user enables and disables the watchdog in sequence i.e. enablewatchdog->disablewatchdog->enablewatchdog
Unlike enablewatchdog->enablewatchdog which is wrong.Signed-off-by anish kumar <[email protected]>--- kernel/watchdog.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)kernel/watchdog.c +0
-0kernel/watchdog.c int proc_dowatchdog(struct ctl_table *table, int write, · line 523
Quoted 6 lines
kernel/watchdog.c +3
-0@@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int write,return ret;set_sample_period (); +/* +* Watchdog threads shouldn't be enabled if they are +* disabled.'watchdog_disabled' variable check in Missing a 'The' ^^^
Quoted 3 lines
Other than that,
Acked-by Don Zickus <[email protected]>
Is this patch picked up?
Quoted 30 lines · anish singh
Quoted 29 lines · Don Zickus
Quoted 19 lines · anish kumar
From: anish kumar <[email protected]>
This
watchdog_disabledflag is bit of cryptic.Howerver it's usefullnes is multifold. Uses are:
1. Check ifsmpboot_register_percpu_threadfunction passed.
2. Makes sure that user enables and disables the watchdog in sequence i.e. enablewatchdog->disablewatchdog->enablewatchdog
Unlike enablewatchdog->enablewatchdog which is wrong.Signed-off-by anish kumar <[email protected]>--- kernel/watchdog.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)kernel/watchdog.c +0
-0kernel/watchdog.c int proc_dowatchdog(struct ctl_table *table, int write, · line 523
Quoted 6 lines
kernel/watchdog.c +3
-0@@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int write,return ret;set_sample_period (); +/* +* Watchdog threads shouldn't be enabled if they are +* disabled.'watchdog_disabled' variable check in Missing a 'The' ^^^
Quoted 4 lines
Quoted 3 lines
Other than that,
Acked-by Don Zickus <[email protected]>Is this patch picked up?
Andrew,
Do you want me to respin the patch with that change? Or how should I move this patch forward?
Cheers,
Don