tty: ipwireless: Remove redundant NULL check before kfree
PATCH 1/1 tty: ipwireless: Remove redundant NULL check before kfree
From: Syam Sidhardhan <[email protected]>
kfree on NULL pointer is a no-op.
Signed-off-by Syam Sidhardhan <[email protected]>
---
v1 -> Corrected the from address.
drivers/tty/ipwireless/hardware.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/tty/ipwireless/hardware.c +1 -2
@@ -1732,8 +1732,7 @@ void ipwireless_hardware_free(struct ipw_hardware *hw)flush_work (&hw->work_rx);for (i =0 ; i <NL_NUM_OF_ADDRESSES ; i++) -if (hw->packet_assembler[i] !=NULL ) -kfree (hw->packet_assembler[i]); +kfree (hw->packet_assembler[i]);for (i =0 ; i <NL_NUM_OF_PRIORITIES ; i++)list_for_each_entry_safe (tp, tq, &hw->tx_queue[i], queue) {
Signature · 1 line
1.7.9.5
Quoted 5 lines · On Thu, 7 Mar 2013, [email protected] wrote:
From: Syam Sidhardhan <[email protected]>
kfree on NULL pointer is a no-op.
Signed-off-by Syam Sidhardhan <[email protected]>
With my ipwireless maintainer hat on:
Acked-by Jiri Kosina <[email protected]>
Greg, could you please take it through tty tree?
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs
Greg KH
maintainerQuoted 6 lines · Jiri Kosina
Quoted 4 lines · On Thu, 7 Mar 2013, [email protected] wrote:
From: Syam Sidhardhan <[email protected]>
kfree on NULL pointer is a no-op.
Quoted 7 lines
Quoted 1 line
Signed-off-by Syam Sidhardhan <[email protected]>With my ipwireless maintainer hat on:
Acked-by Jiri Kosina <[email protected]>Greg, could you please take it through tty tree?
Ok, will do.
thanks,
greg k-h