Skip to contentSkip to conversation

ARM: Dove: add RTC device node

PATCH New Jean-Francois Moine 4 participants 5 messages Mar 8, 2013 – Mar 9, 2013 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: Dove: add RTC device node

The commit 48be9ac930086f removed the RTC initialization. This patch re-enables the RTC via the DT.

---
 arch/arm/boot/dts/dove.dtsi |    5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/dove.dtsi +5 -0
index 46afade..28ff4dc 100644
@@ -197,6 +197,11 @@
 			status = "disabled";
 		};
 
+		rtc at d8500 {
+			compatible = "marvell,orion-rtc";
+			reg = <0xd8500 0x20>;
+		};
+
 		crypto: crypto at 30000 {
 			compatible = "marvell,orion-crypto";
 			reg = <0x30000 0x10000>,
Signature · 2 lines
Ken ar c'henta?	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
#1 lore raw

PATCH 1/1 ARM: Dove: add RTC device node

Hello.

Quoted 1 line · Jean-Francois Moine

The commit 48be9ac930086f

Please also specify the summary line for that commit in parens (or however
you like).

Quoted 4 lines

removed the RTC initialization.
This patch re-enables the RTC via the DT.

WBR, Sergei

Applied
#2 lore raw

PATCH 1/1 ARM: Dove: add RTC device node

In reply to Jean-Francois Moine
Quoted 7 lines · Jean-Francois Moine

The commit 48be9ac930086f removed the RTC initialization. This patch re-enables the RTC via the DT.

---
 arch/arm/boot/dts/dove.dtsi |    5 +++++
 1 file changed, 5 insertions(+)

Applied to mvebu/fixes with the following commit entry:

ARM: Dove: add RTC device node

The commit:

48be9ac ARM: Dove: split legacy and DT setup

removed the RTC initialization. This patch re-enables the RTC via the DT.

thx,

Jason.

#3 lore raw

PATCH 1/1 ARM: Dove: add RTC device node

Quoted 10 lines · Jason Cooper

Applied to mvebu/fixes with the following commit entry:

ARM: Dove: add RTC device node

The commit:

48be9ac ARM: Dove: split legacy and DT setup

removed the RTC initialization. This patch re-enables the RTC via the DT.

Looks good. FWIW, the style I tend to use is

|ARM: Dove: add RTC device node
|
|The commit 48be9ac "ARM: Dove: split legacy and DT setup" removed the RTC
|initialization.  This patch re-enables the RTC via the DT.

I don't think that there is a wide agreement on how to refer to other patches yet, but I do a lot of regression fixes like that, so maybe I can start a trend here.

ARnd

#4 lore raw

PATCH 1/1 ARM: Dove: add RTC device node

Quoted 15 lines · Arnd Bergmann
Quoted 10 lines · Jason Cooper

Applied to mvebu/fixes with the following commit entry:

ARM: Dove: add RTC device node

The commit:

48be9ac ARM: Dove: split legacy and DT setup

removed the RTC initialization. This patch re-enables the RTC via the DT.

Looks good. FWIW, the style I tend to use is

Quoted 8 lines
|ARM: Dove: add RTC device node
|
|The commit 48be9ac "ARM: Dove: split legacy and DT setup" removed the RTC
|initialization.  This patch re-enables the RTC via the DT.

I don't think that there is a wide agreement on how to refer to other patches yet, but I do a lot of regression fixes like that, so maybe I can start a trend here.

Looks good to me. flows a bit better than what I had. I'll use that from now on for anything I come across.

thx,

Jason.