Skip to contentSkip to conversation

gssd - expired credentials problem

PATCH In review Lukas Hejtmanek 2 participants 2 messages Mar 9, 2013 – Mar 25, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gssd - expired credentials problem

Hi,

I noticed that there is a problem with expired credentials if NFS client's time is even few seconds behind KDC's or NFS server's time. Client's kernel requests new GSS context but rpc.gssd is happy with existing krb cache as it valid according to local time.

Is there any reason for gssd to check validity of existing cache when kernel requests a new context?

However, it seems that this trivial patch solves this issue.

300 is because I believe that clock skew must be within 300sec for kerberos.

utils/gssd/krb5_util.c 2013-02-15 16:35:35.652482164 +0100 renamed from utils/gssd/krb5_util.c 2012-11-12 00:01:23.000000000 +0100 +1 -1
diff -rNu nfs-utils-1.2.7.orig/utils/gssd/krb5_util.c nfs-utils-1.2.7/utils/gssd/krb5_util.c
@@ -343,7 +343,7 @@
        char kt_name[BUFSIZ];
        char cc_name[BUFSIZ];
        int code;
-       time_t now = time(0);
+       time_t now = time(0)+300; // workaround for clock skew among NFS server, NFS client and KDC
        char *cache_type;
        char *pname = NULL;
        char *k5err = NULL;
Signature · 1 line
Lukáš Hejtmánek
#1 lore raw
Quoted 7 lines · Lukas Hejtmanek

Hi,

I noticed that there is a problem with expired credentials if NFS client's time is even few seconds behind KDC's or NFS server's time. Client's kernel requests new GSS context but rpc.gssd is happy with existing krb cache as it valid according to local time.

Quoted 8 lines

Is there any reason for gssd to check validity of existing cache when kernel requests a new context?

However, it seems that this trivial patch solves this issue.

300 is because I believe that clock skew must be within 300sec for kerberos.

Committed...

steved.

Quoted 15 lines

diff -rNu nfs-utils-1.2.7.orig/utils/gssd/krb5_util.c nfs-utils-1.2.7/utils/gssd/krb5_util.c

utils/gssd/krb5_util.c 2013-02-15 16:35:35.652482164 +0100 renamed from utils/gssd/krb5_util.c 2012-11-12 00:01:23.000000000 +0100 +1 -1
@@ -343,7 +343,7 @@
        char kt_name[BUFSIZ];
        char cc_name[BUFSIZ];
        int code;
-       time_t now = time(0);
+       time_t now = time(0)+300; // workaround for clock skew among NFS server, NFS client and KDC
        char *cache_type;
        char *pname = NULL;
        char *k5err = NULL;