Skip to contentSkip to conversation

powerpc/82xx/km: make handle_mgcoge3un_reset static

PATCH New Holger Brunck 2 participants 4 messages Jan 18, 2013 – Mar 9, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 powerpc/82xx/km: make handle_mgcoge3un_reset static

---
 board/keymile/km82xx/km82xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
board/keymile/km82xx/km82xx.c +1 -1
index 67b69f6..8cf3035 100644
@@ -370,7 +370,7 @@ static void set_pin(int state, unsigned long mask);
  * will toggle once what forces the mgocge3un part to restart
  * immediately.
  */
-void handle_mgcoge3un_reset(void)
+static void handle_mgcoge3un_reset(void)
 {
 	char *bobcatreset = getenv("bobcatreset");
 	if (bobcatreset) {
Signature · 1 line
1.7.1
#1 lore raw

PATCH 2/2 powerpc/82xx/km: removed unneeded ifdef

All boards from this serie uses i2c. So we can drop these unneeded defines.

---
 board/keymile/km82xx/km82xx.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
board/keymile/km82xx/km82xx.c +0 -3
index 8cf3035..ddf4795 100644
@@ -31,10 +31,7 @@
 #include <libfdt.h>
 #endif
 
-#if defined(CONFIG_HARD_I2C) || defined(CONFIG_SOFT_I2C)
 #include <i2c.h>
-#endif
-
 #include "../common/common.h"
 
 /*
Signature · 1 line
1.7.1
#2 lore raw

PATCH 2/2 powerpc/82xx/km: removed unneeded ifdef

Dear Holger Brunck,

Quoted 7 lines · In message <[email protected]> you…

All boards from this serie uses i2c. So we can drop these unneeded defines.

---
 board/keymile/km82xx/km82xx.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

Applied to u-boot-mpc82xx, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
An armed society is a polite society.
#3 lore raw

PATCH 1/2 powerpc/82xx/km: make handle_mgcoge3un_reset static

In reply to Holger Brunck

Dear Holger Brunck,

Quoted 4 lines · In message <[email protected]> you…
---
 board/keymile/km82xx/km82xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied to u-boot-mpc82xx, thanks.

Best regards,

Wolfgang Denk

Signature · 8 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Many companies that have made themselves dependent on [the  equipment
of  a  certain  major  manufacturer] (and in doing so have sold their
soul to the devil) will collapse under the sheer weight  of  the  un-
mastered complexity of their data processing systems.
          -- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5