Skip to contentSkip to conversation

bridge: reserve space for IFLA_BRPORT_FAST_LEAVE

PATCH In review Stephen Hemminger 2 participants 2 messages Mar 11, 2013 – Mar 12, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bridge: reserve space for IFLA_BRPORT_FAST_LEAVE

The bridge multicast fast leave feature was added sufficient space was not reserved in the netlink message. This means the flag may be lost in netlink events and results of queries.

Found by observation while looking up some netlink stuff for discussion with Vlad. Problem introduced by commit c2d3babfafbb9f6629cfb47139758e59a5eb0d80

Author: David S. Miller <[email protected]>
Date:   Wed Dec 5 16:24:45 2012 -0500

bridge: implement multicast fast leave

---
Should go to net and stable for 3.8.X

net/bridge/br_netlink.c +1 -0
@@ -29,6 +29,7 @@ static inline size_t br_port_info_size(v
 		+ nla_total_size(1)	/* IFLA_BRPORT_MODE */
 		+ nla_total_size(1)	/* IFLA_BRPORT_GUARD */
 		+ nla_total_size(1)	/* IFLA_BRPORT_PROTECT */
+		+ nla_total_size(1)	/* IFLA_BRPORT_FAST_LEAVE */
 		+ 0;
 }
 
maintainer
#1 lore raw

From: Stephen Hemminger <[email protected]>
Date: Mon, 11 Mar 2013 16:52:17 -0700

Quoted 9 lines

The bridge multicast fast leave feature was added sufficient space was not reserved in the netlink message. This means the flag may be lost in netlink events and results of queries.

Found by observation while looking up some netlink stuff for discussion with Vlad. Problem introduced by commit c2d3babfafbb9f6629cfb47139758e59a5eb0d80

Author: David S. Miller <[email protected]>
Date:   Wed Dec 5 16:24:45 2012 -0500
Quoted 6 lines

bridge: implement multicast fast leave

---
Should go to net and stable for 3.8.X

Applied and queued up for -stable.