Skip to contentSkip to conversation

SNB-PEBS errate in perf code - omits stepping 2?

PATCH Konrad Rzeszutek Wilk 2 participants 2 messages Mar 11, 2013 – Mar 12, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hey,

I think quirk:

+static int intel_snb_pebs_broken(int cpu)
+{
+ u32 rev = UINT_MAX; /* default to broken for unknown models */
+
+ switch (cpu_data(cpu).x86_model) {
+ case 42: /* SNB */
+ rev = 0x28;
+ break;
+
+ case 45: /* SNB-EP */

+               switch (cpu_data(cpu).x86_mask) {
+               case 6: rev = 0x618; break;
+               case 7: rev = 0x70c; break;
+               }

+ }
+
+ return (cpu_data(cpu).microcode < rev);
+}
+

needs a bit of update? I've this CPU:

vendor_id : GenuineIntel
cpu family : 6
model : 45
model name : Genuine Intel(R) CPU @ 2.30GHz
stepping : 2
cpu MHz : 2294.534
cache size : 20480 KB
..
microcode : 0x8000020c

and since the stepping is '2' and there are no 'default' case in the switch statement, it ends up failing b/c it is asking for revision UINT_MAX.

Is there a specific microcode errate version for this type of CPU? Or am I a lucky recipient of an early development CPU?

Perhaps that check should also have this:

arch/x86/kernel/cpu/perf_event_intel.c +3 -0
index 529c893..287d43a 100644
@@ -1845,6 +1845,9 @@ static int intel_snb_pebs_broken(int cpu)
 		case 7: rev = 0x70c; break;
 		}
 	}
+	if (rev == UINT_MAX)
+		pr_warn("Please contact Intel to update quirk as you have"
+			"an unknown CPU stepping: %d\n", cpu_data(cpu).x86_mask);
 
 	return (cpu_data(cpu).microcode < rev);
 }
#1 lore raw
Quoted 37 lines · Konrad Rzeszutek Wilk

Hey,

I think quirk:

(quoted diff) +19 -0
+static int intel_snb_pebs_broken(int cpu)
+{
+       u32 rev = UINT_MAX; /* default to broken for unknown models */
+
+       switch (cpu_data(cpu).x86_model) {
+       case 42: /* SNB */
+               rev = 0x28;
+               break;
+
+       case 45: /* SNB-EP */
+               switch (cpu_data(cpu).x86_mask) {
+               case 6: rev = 0x618; break;
+               case 7: rev = 0x70c; break;
+               }
+       }
+
+       return (cpu_data(cpu).microcode < rev);
+}
+

needs a bit of update? I've this CPU:

vendor_id : GenuineIntel
cpu family : 6
model : 45
model name : Genuine Intel(R) CPU @ 2.30GHz
stepping : 2
cpu MHz : 2294.534
cache size : 20480 KB
..
microcode : 0x8000020c

Quoted 7 lines

and since the stepping is '2' and there are no 'default' case in the switch statement, it ends up failing b/c it is asking for revision UINT_MAX.

Is there a specific microcode errate version for this type of CPU? Or am I a lucky recipient of an early development CPU?

I believe you have an early sample CPU.
But I think you comment is still valid. I think the kernel should print a message once for your situation.

Quoted 17 lines

Perhaps that check should also have this:

arch/x86/kernel/cpu/perf_event_intel.c +3 -0
index 529c893..287d43a 100644
@@ -1845,6 +1845,9 @@ static int intel_snb_pebs_broken(int cpu)
                case 7: rev = 0x70c; break;
                }
        }
+       if (rev == UINT_MAX)
+               pr_warn("Please contact Intel to update quirk as you have"
+                       "an unknown CPU stepping: %d\n", cpu_data(cpu).x86_mask);
 
        return (cpu_data(cpu).microcode < rev);
 }