drm/i915: clarify reasoning for the access_ok call
Subsystems (2)
PATCH v2 1/1 drm/i915: clarify reasoning for the access_ok call
This clarifies the comment above the access_ok check so a missing VERIFY_READ doesn't alarm anyone.
Signed-off-by Kees Cook <[email protected]>
Cc Daniel Vetter <[email protected]>
---
v2:
- rewrote comment, thanks to Chris Wilson
--- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem_execbuffer.c +5 -1
@@ -751,7 +751,11 @@ validate_exec_list(struct drm_i915_gem_exec_object2 *exec, length = exec[i].relocation_count *sizeof (struct drm_i915_gem_relocation_entry ); -/* we may also need to update the presumed offsets */ +/* +* We must check that the entire relocation array is safe +* to read, but since we may need to update the presumed +* offsets during execution, check for full write access. +*/ if (!access_ok (VERIFY_WRITE , ptr, length))return -EFAULT ;
Signature · 6 lines
1.7.9.5 -- Kees Cook Chrome OS Security
Quoted 8 lines · Kees Cook
This clarifies the comment above the
access_okcheck so a missingVERIFY_READdoesn't alarm anyone.Signed-off-by Kees Cook <[email protected]>Cc Daniel Vetter <[email protected]>---
v2:
- rewrote comment, thanks to Chris Wilson
Queued for -next, thanks for the patch. Fyi I prefer the patch changelog in the actual commit message so that it gets recorded in git. Usually it's not that interesting, but sometimes knowning the history of a patch is really important. I've fixed this while applying.
-Daniel
Quoted 28 lines
--- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_gem_execbuffer.c +5
-1@@ -751,7 +751,11 @@ validate_exec_list(struct drm_i915_gem_exec_object2 *exec, length = exec[i].relocation_count *sizeof (struct drm_i915_gem_relocation_entry ); -/* we may also need to update the presumed offsets */ +/* +* We must check that the entire relocation array is safe +* to read, but since we may need to update the presumed +* offsets during execution, check for full write access. +*/ if (!access_ok (VERIFY_WRITE , ptr, length))return -EFAULT ;Signature · 6 lines
1.7.9.5 -- Kees Cook Chrome OS Security
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch