Skip to contentSkip to conversation

usb/gadget/Kconfig: fix menu

PATCH Applied Eric Bénard 3 participants 4 messages Mar 11, 2013 – Mar 12, 2013 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb/gadget/Kconfig: fix menu

by reordering the entry, USB gadget support is now a menu and the USB gadget choices are under this menu and not directly in the driver menu.

---
 drivers/usb/gadget/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/usb/gadget/Kconfig +4 -4
index 5f65cea..97a7d21 100644
@@ -1,11 +1,11 @@
-menuconfig USB_GADGET
-	depends on USB_HAVE_GADGET_DRIVER
-	bool "USB gadget support"
-
 config USB_HAVE_GADGET_DRIVER
 	bool
 	default y if ARCH_IMX || ARCH_MXS || ARCH_AT91 || ARCH_PXA
 
+menuconfig USB_GADGET
+	depends on USB_HAVE_GADGET_DRIVER
+	bool "USB gadget support"
+
 if USB_GADGET
 
 config USB_GADGET_DUALSPEED
Signature · 7 lines
1.7.11.7


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Applied
#1 lore raw
Quoted 5 lines · Eric Bénard

by reordering the entry, USB gadget support is now a menu and the USB gadget choices are under this menu and not directly in the driver menu.

Applied, thanks

Sascha

Quoted 32 lines
---
 drivers/usb/gadget/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/usb/gadget/Kconfig +4 -4
index 5f65cea..97a7d21 100644
@@ -1,11 +1,11 @@
-menuconfig USB_GADGET
-	depends on USB_HAVE_GADGET_DRIVER
-	bool "USB gadget support"
-
 config USB_HAVE_GADGET_DRIVER
 	bool
 	default y if ARCH_IMX || ARCH_MXS || ARCH_AT91 || ARCH_PXA
 
+menuconfig USB_GADGET
+	depends on USB_HAVE_GADGET_DRIVER
+	bool "USB gadget support"
+
 if USB_GADGET
 
 config USB_GADGET_DUALSPEED
Signature · 7 lines
1.7.11.7


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#2 lore raw
Quoted 8 lines · Sascha Hauer
Quoted 5 lines · Eric Bénard

by reordering the entry, USB gadget support is now a menu and the USB gadget choices are under this menu and not directly in the driver menu.

Applied, thanks

IIrc we can not do this for a Kconfig depends on USB_HAVE_GADGET_DRIVER

Quoted 31 lines

Sascha

Quoted 28 lines
---
 drivers/usb/gadget/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/usb/gadget/Kconfig +4 -4
index 5f65cea..97a7d21 100644
@@ -1,11 +1,11 @@
-menuconfig USB_GADGET
-	depends on USB_HAVE_GADGET_DRIVER
-	bool "USB gadget support"
-
 config USB_HAVE_GADGET_DRIVER
 	bool
 	default y if ARCH_IMX || ARCH_MXS || ARCH_AT91 || ARCH_PXA
 
+menuconfig USB_GADGET
+	depends on USB_HAVE_GADGET_DRIVER
+	bool "USB gadget support"
+
 if USB_GADGET
 
 config USB_GADGET_DUALSPEED
Signature · 1 line
1.7.11.7
Quoted 15 lines
Quoted 4 lines

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#3 lore raw
Quoted 10 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 8 lines · Sascha Hauer
Quoted 5 lines · Eric Bénard

by reordering the entry, USB gadget support is now a menu and the USB gadget choices are under this menu and not directly in the driver menu.

Applied, thanks

IIrc we can not do this for a Kconfig depends on USB_HAVE_GADGET_DRIVER

I tried it and I can't see any negative aspects.

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox