igb: SR-IOV init reordering
Subsystems (3)
PATCH 1/1 igb: SR-IOV init reordering
igb is ineffective at setting a lower total VFs because:
int pci_sriov_set_totalvfs(struct pci_dev *dev, u16 numvfs)
{
...
/* Shouldn't change if VFs already enabled */
if (dev->sriov->ctrl & PCI_SRIOV_CTRL_VFE)
return -EBUSY;Swap init ordering.
Signed-off-by Alex Williamson <[email protected]>
--- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/igb/igb_main.c +1 -1
@@ -2546,8 +2546,8 @@ static void igb_probe_vfs(struct igb_adapter *adapter)if ((hw->mac.type == e1000_i210) || (hw->mac.type == e1000_i211))return ; -igb_enable_sriov (pdev, max_vfs);pci_sriov_set_totalvfs (pdev,7 ); +igb_enable_sriov (pdev, max_vfs);#endif /* CONFIG_PCI_IOV */ }
Quoted 9 lines · Alex Williamson
igb is ineffective at setting a lower total VFs because:
int
pci_sriov_set_totalvfs(struct pci_dev *dev, u16 numvfs){ ... /* Shouldn't change if VFs already enabled */ if (dev->sriov->ctrl & PCI_SRIOV_CTRL_VFE) return -EBUSY;
Quoted 6 lines
Swap init ordering.
Signed-off-by Alex Williamson <[email protected]>--- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I have added the patch to my igb queue, thanks!