Skip to contentSkip to conversation

ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()

PATCH Applied Dan Carpenter 3 participants 3 messages Mar 13, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()

"val" has to be signed for the error handling to work.

sound/soc/codecs/tas5086.c +1 -1
index 008bea4..41d03ae 100644
@@ -251,7 +251,7 @@ static int tas5086_hw_params(struct snd_pcm_substream *substream,
 {
 	struct snd_soc_codec *codec = dai->codec;
 	struct tas5086_private *priv = snd_soc_codec_get_drvdata(codec);
-	unsigned int val;
+	int val;
 	int ret;
 
 	priv->rate = params_rate(params);
Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · Dan Carpenter

"val" has to be signed for the error handling to work.

Absolutely.

Quoted 1 line
Quoted 15 lines
sound/soc/codecs/tas5086.c +1 -1
index 008bea4..41d03ae 100644
@@ -251,7 +251,7 @@ static int tas5086_hw_params(struct snd_pcm_substream *substream,
 {
 	struct snd_soc_codec *codec = dai->codec;
 	struct tas5086_private *priv = snd_soc_codec_get_drvdata(codec);
-	unsigned int val;
+	int val;
 	int ret;
 
 	priv->rate = params_rate(params);