ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()
Subsystems (3)
PATCH 1/1 ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()
"val" has to be signed for the error handling to work.
Signed-off-by Dan Carpenter <[email protected]>
sound/soc/codecs/tas5086.c +1 -1
@@ -251,7 +251,7 @@ static int tas5086_hw_params(struct snd_pcm_substream *substream, {struct snd_soc_codec *codec = dai->codec;struct tas5086_private *priv =snd_soc_codec_get_drvdata (codec); -unsigned int val; +int val;int ret; priv->rate =params_rate (params);
Quoted 1 line · Dan Carpenter
"val" has to be signed for the error handling to work.
Absolutely.
Quoted 1 line
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Daniel Mack <[email protected]>
Quoted 15 lines
sound/soc/codecs/tas5086.c +1
-1@@ -251,7 +251,7 @@ static int tas5086_hw_params(struct snd_pcm_substream *substream, {struct snd_soc_codec *codec = dai->codec;struct tas5086_private *priv =snd_soc_codec_get_drvdata (codec); -unsigned int val; +int val;int ret; priv->rate =params_rate (params);
Mark Brown
AppliedQuoted 1 line · Dan Carpenter
"val" has to be signed for the error handling to work.
Applied, thanks.