Skip to contentSkip to conversation

mfd: Fix AB8500 build failure if POWER_SUPPLY is not configured

PATCH New Guenter Roeck 3 participants 3 messages Feb 28, 2013 – Mar 13, 2013 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: Fix AB8500 build failure if POWER_SUPPLY is not configured

ab8500-sysctrl.c fails to build if POWER_SUPPLY is not configured.

drivers/built-in.o: In function `ab8500_power_off':
drivers/mfd/ab8500-sysctrl.c:37: undefined reference to power_supply_get_by_name' drivers/mfd/ab8500-sysctrl.c:53: undefined reference to power_supply_get_by_name'

Select POWER_SUPPLY in Kconfig if AB8500_CORE is configured to fix the problem.

---
 drivers/mfd/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/mfd/Kconfig +1 -0
index 671f5b1..d5511de 100644
@@ -860,6 +860,7 @@ config AB8500_CORE
 	depends on GENERIC_HARDIRQS && ABX500_CORE && MFD_DB8500_PRCMU
 	select MFD_CORE
 	select IRQ_DOMAIN
+	select POWER_SUPPLY
 	help
 	  Select this option to enable access to AB8500 power management
 	  chip. This connects to U8500 either on the SSP/SPI bus (deprecated
Signature · 1 line
1.7.9.7
#1 lore raw

PATCH 1/1 mfd: Fix AB8500 build failure if POWER_SUPPLY is not configured

Quoted 9 lines · Guenter Roeck

ab8500-sysctrl.c fails to build if POWER_SUPPLY is not configured.

drivers/built-in.o: In function `ab8500_power_off':
drivers/mfd/ab8500-sysctrl.c:37: undefined reference to power_supply_get_by_name' drivers/mfd/ab8500-sysctrl.c:53: undefined reference to power_supply_get_by_name'

Select POWER_SUPPLY in Kconfig if AB8500_CORE is configured to fix the problem.

It appears an identical patch was already submitted in feb 19:
https://patchwork.kernel.org/patch/2163301/

Yours,
Linus Walleij

Applied
#2 lore raw

PATCH 1/1 mfd: Fix AB8500 build failure if POWER_SUPPLY is not configured

In reply to Guenter Roeck

Hi Guenter,

Quoted 6 lines · Guenter Roeck

ab8500-sysctrl.c fails to build if POWER_SUPPLY is not configured.

drivers/built-in.o: In function `ab8500_power_off':
drivers/mfd/ab8500-sysctrl.c:37: undefined reference to power_supply_get_by_name' drivers/mfd/ab8500-sysctrl.c:53: undefined reference to power_supply_get_by_name'

Quoted 6 lines

Select POWER_SUPPLY in Kconfig if AB8500_CORE is configured to fix the problem.

---
 drivers/mfd/Kconfig |    1 +
 1 file changed, 1 insertion(+)

I applied Axel's patch to my mfd-fixes tree now.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/