Skip to contentSkip to conversation

firewire net: resource management improvements

RFC In review YOSHIFUJI Hideaki 3 participants 8 messages Mar 8, 2013 – Mar 24, 2013

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

YOSHIFUJI Hideaki

author
#0 lore raw

cover firewire net: resource management improvements

Hello.

This series of patches tries to improve resource management of IP over Firewire device.

Because upcoming IPv6 over Firewire patch depends on this series, it would be better to let this series of patches go through Dave's net-next tree, if firewire people do not mind.

--yoshfuji

YOSHIFUJI Hideaki (11):
firewire net: No need to reset dev->local_fifo after failure of
fw_core_add_address_handler().
firewire net: Introduce fwnet_fifo_{start,stop}() helpers. firewire net: Setup broadcast and local fifo independently. firewire net: Check dev->broadcast_state inside
fwnet_broadcast_start().
firewire net: Fix memory leakage in fwnet_remove(). firewire net: Clear dev->broadcast_rcv_context and

    dev->broadcast_state after destruction of context.

firewire net: Omit checking dev->broadcast_rcv_context in
fwnet_broadcast_start().
firewire net: Fix leakage of kmap for broadcast receive buffer. firewire net: Allocate dev->broadcast_rcv_buffer_ptrs early. firewire net: Introduce fwnet_broadcast_stop() to destroy broadcast
resources.
firewire net: Release broadcast/fifo resources on ifdown.

 drivers/firewire/net.c |  177 ++++++++++++++++++++++++++++--------------------
 1 file changed, 105 insertions(+), 72 deletions(-)
Signature · 1 line
1.7.9.5
Reviewed-by on the v1 series
#1 lore raw
Quoted 27 lines · On Mar 08 YOSHIFUJI Hideaki wrote:

This series of patches tries to improve resource management of IP over Firewire device.

Because upcoming IPv6 over Firewire patch depends on this series, it would be better to let this series of patches go through Dave's net-next tree, if firewire people do not mind.

--yoshfuji

YOSHIFUJI Hideaki (11):
firewire net: No need to reset dev->local_fifo after failure of
fw_core_add_address_handler().
firewire net: Introduce fwnet_fifo_{start,stop}() helpers. firewire net: Setup broadcast and local fifo independently. firewire net: Check dev->broadcast_state inside
fwnet_broadcast_start().
firewire net: Fix memory leakage in fwnet_remove(). firewire net: Clear dev->broadcast_rcv_context and

    dev->broadcast_state after destruction of context.

firewire net: Omit checking dev->broadcast_rcv_context in
fwnet_broadcast_start().
firewire net: Fix leakage of kmap for broadcast receive buffer. firewire net: Allocate dev->broadcast_rcv_buffer_ptrs early. firewire net: Introduce fwnet_broadcast_stop() to destroy broadcast
resources.
firewire net: Release broadcast/fifo resources on ifdown.

Quoted 3 lines
 drivers/firewire/net.c |  177 ++++++++++++++++++++++++++++--------------------
 1 file changed, 105 insertions(+), 72 deletions(-)

All 11 patches:

Reviewed-by Stefan Richter <[email protected]>

ACK for routing this through net-next. David, do you need me to respond to each individual patch with the reviewer tag? Or since I already have the patches in a quilt series locally, I could commit them to a branch at linux1394.git and send you a pull request.

Signature · 3 lines
Stefan Richter
-=====-===-= --== -==-=
http://arcgraph.de/sr/
maintainer
#2 lore raw

From: Stefan Richter <[email protected]>
Date: Wed, 13 Mar 2013 15:19:19 +0100

Quoted 4 lines

ACK for routing this through net-next. David, do you need me to respond to each individual patch with the reviewer tag? Or since I already have the patches in a quilt series locally, I could commit them to a branch at linux1394.git and send you a pull request.

Anything works for me, either the series has to be reposted to netdev or someone sends me a pull request.

#3 lore raw

David,

please pull from the tag "firewire-net-resource-mgt" at

    git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git firewire-net-resource-mgt

to receive the following firewire-net driver changes:
- fix memory leak and kmap leak at shutdown
- release IR DMA context already at ifdown rather than shutdown (many controllers have got only 4 of them, so let's not hold it longer than strictly necessary)
- misc startup/shutdown changes which prepare for later addition

    of IPv6-over-1394 support

YOSHIFUJI Hideaki (11):
firewire net: No need to reset dev->local_fifo after failure of fw_core_add_address_handler(). firewire net: Introduce fwnet_fifo_{start, stop}() helpers.
firewire net: Setup broadcast and local fifo independently.
firewire net: Check dev->broadcast_state inside fwnet_broadcast_start().
firewire net: Fix memory leakage in fwnet_remove().
firewire net: Clear dev->broadcast_rcv_context and dev->broadcast_state after destruction of context. firewire net: Omit checking dev->broadcast_rcv_context in fwnet_broadcast_start(). firewire net: Fix leakage of kmap for broadcast receive buffer.
firewire net: Allocate dev->broadcast_rcv_buffer_ptrs early.
firewire net: Introduce fwnet_broadcast_stop() to destroy broadcast resources. firewire net: Release broadcast/fifo resources on ifdown.

 drivers/firewire/net.c | 177 +++++++++++++++++++--------------
 1 file changed, 105 insertions(+), 72 deletions(-)

Thanks,

Signature · 3 lines
Stefan Richter
-=====-===-= --== -==-=
http://arcgraph.de/sr/
author
#4 lore raw

Dave,

would you consider pulling this one to net-next, please? I can prepare rebased tree, if you want.

Thanks.

--yoshfuji

Quoted 31 lines · Stefan Richter

David,

please pull from the tag "firewire-net-resource-mgt" at

    git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git firewire-net-resource-mgt

to receive the following firewire-net driver changes:
- fix memory leak and kmap leak at shutdown
- release IR DMA context already at ifdown rather than shutdown (many controllers have got only 4 of them, so let's not hold it longer than strictly necessary)
- misc startup/shutdown changes which prepare for later addition

    of IPv6-over-1394 support

YOSHIFUJI Hideaki (11):
firewire net: No need to reset dev->local_fifo after failure of fw_core_add_address_handler(). firewire net: Introduce fwnet_fifo_{start, stop}() helpers.
firewire net: Setup broadcast and local fifo independently.
firewire net: Check dev->broadcast_state inside fwnet_broadcast_start().
firewire net: Fix memory leakage in fwnet_remove().
firewire net: Clear dev->broadcast_rcv_context and dev->broadcast_state after destruction of context. firewire net: Omit checking dev->broadcast_rcv_context in fwnet_broadcast_start(). firewire net: Fix leakage of kmap for broadcast receive buffer.
firewire net: Allocate dev->broadcast_rcv_buffer_ptrs early.
firewire net: Introduce fwnet_broadcast_stop() to destroy broadcast resources. firewire net: Release broadcast/fifo resources on ifdown.

 drivers/firewire/net.c | 177 +++++++++++++++++++--------------
 1 file changed, 105 insertions(+), 72 deletions(-)

Thanks,

maintainer
#5 lore raw

From: YOSHIFUJI Hideaki <[email protected]>
Date: Fri, 22 Mar 2013 12:34:23 +0900

Quoted 2 lines

would you consider pulling this one to net-next, please? I can prepare rebased tree, if you want.

So the firewire maintainers are OK with these changes?

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar

#6 lore raw
Quoted 7 lines · On Mar 22 David Miller wrote:

From: YOSHIFUJI Hideaki <[email protected]>
Date: Fri, 22 Mar 2013 12:34:23 +0900

Quoted 2 lines

would you consider pulling this one to net-next, please? I can prepare rebased tree, if you want.

So the firewire maintainers are OK with these changes?

The firewire maintainers (that is me, myself, and I) have reviewed these changes, signed off on them, committed them to linux1394.git at kernel.org, and on top of that are OK with them and with their being routed through net-next, indeed. :-)

Signature · 3 lines
Stefan Richter
-=====-===-= --== =-==-
http://arcgraph.de/sr/
maintainer
#7 lore raw

From: Stefan Richter <[email protected]>
Date: Fri, 22 Mar 2013 22:21:09 +0100

Quoted 7 lines · On Mar 22 David Miller wrote:
Quoted 6 lines

From: YOSHIFUJI Hideaki <[email protected]>
Date: Fri, 22 Mar 2013 12:34:23 +0900

Quoted 2 lines

would you consider pulling this one to net-next, please? I can prepare rebased tree, if you want.

Quoted 6 lines
Quoted 1 line

So the firewire maintainers are OK with these changes?

The firewire maintainers (that is me, myself, and I) have reviewed these changes, signed off on them, committed them to linux1394.git at kernel.org, and on top of that are OK with them and with their being routed through net-next, indeed. :-)

That's good enough for me, pulled into net-next, thanks.