Skip to contentSkip to conversation

hwmon: checkpatch cleanup: Replace printk with pr_debug or dev_dbg as appro

PATCH In review Guenter Roeck 2 participants 3 messages Mar 14, 2013

Subsystems (5)
lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw

PATCH 1/9 hwmon: checkpatch cleanup: Replace printk with pr_debug or dev_dbg as appro

Cc Hans de Goede <[email protected]>
Cc Alistair John Strachan <[email protected]>
Cc Henrik Rydberg <[email protected]>
---
 drivers/hwmon/abituguru.c  |    2 +-
 drivers/hwmon/abituguru3.c |    2 +-
 drivers/hwmon/applesmc.c   |    2 +-
 drivers/hwmon/f71805f.c    |    3 +--
 4 files changed, 4 insertions(+), 5 deletions(-)
drivers/hwmon/abituguru.c +1 -1
index 6119ff8..b84f180 100644
@@ -98,7 +98,7 @@
 #define ABIT_UGURU_NAME				"abituguru"
 #define ABIT_UGURU_DEBUG(level, format, arg...)				\
 	if (level <= verbose)						\
-		printk(KERN_DEBUG ABIT_UGURU_NAME ": "	format , ## arg)
+		pr_debug(format , ## arg)
 /* Macros to help calculate the sysfs_names array length */
 /*
  * sum of strlen of: in??_input\0, in??_{min,max}\0, in??_{min,max}_alarm\0,
drivers/hwmon/abituguru3.c +1 -1
index 205327d..dcce352 100644
@@ -78,7 +78,7 @@
 #define ABIT_UGURU3_NAME			"abituguru3"
 #define ABIT_UGURU3_DEBUG(format, arg...)	\
 	if (verbose)				\
-		printk(KERN_DEBUG ABIT_UGURU3_NAME ": "	format , ## arg)
+		pr_debug(format , ## arg)
 
 /* Macros to help calculate the sysfs_names array length */
 #define ABIT_UGURU3_MAX_NO_SENSORS 26
drivers/hwmon/applesmc.c +1 -1
index b41baff..62c2e32 100644
@@ -922,7 +922,7 @@ static void applesmc_brightness_set(struct led_classdev *led_cdev,
 	ret = queue_work(applesmc_led_wq, &backlight_work);
 
 	if (debug && (!ret))
-		printk(KERN_DEBUG "applesmc: work was already on the queue.\n");
+		dev_dbg(led_cdev->dev, "work was already on the queue.\n");
 }
 
 static ssize_t applesmc_key_count_show(struct device *dev,
drivers/hwmon/f71805f.c +1 -2
index a981697..0c9f3da 100644
@@ -1350,8 +1350,7 @@ static void f71805f_init_device(struct f71805f_data *data)
 
 	reg = f71805f_read8(data, F71805F_REG_START);
 	if ((reg & 0x41) != 0x01) {
-		printk(KERN_DEBUG DRVNAME ": Starting monitoring "
-		       "operations\n");
+		pr_debug("Starting monitoring operations\n");
 		f71805f_write8(data, F71805F_REG_START, (reg | 0x01) & ~0x40);
 	}
 
Signature · 7 lines
1.7.9.7


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
maintainer Acked-by on v1 1/9
#1 lore raw

Re: [lm-sensors] [PATCH 1/9] hwmon: checkpatch cleanup: Replace printk with pr_debug or dev_dbg as a

Quoted 4 lines · Guenter Roeck
Cc Hans de Goede <[email protected]>
Cc Alistair John Strachan <[email protected]>
Cc Henrik Rydberg <[email protected]>

LGTM.

Signature · 2 lines
Cheers,
Alistair.

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

author maintainer
#2 lore raw

Re: [lm-sensors] [PATCH 1/9] hwmon: checkpatch cleanup: Replace printk with pr_debug or dev_dbg as a

In reply to Guenter Roeck
Quoted 8 lines · Alistair Strachan
Quoted 4 lines · Guenter Roeck
Cc Hans de Goede <[email protected]>
Cc Alistair John Strachan <[email protected]>
Cc Henrik Rydberg <[email protected]>
Quoted 4 lines

LGTM.

Thanks!

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors