Skip to contentSkip to conversation

Staging: dwc2: remove a kfree(NULL)

PATCH In review Dan Carpenter 2 participants 2 messages Mar 15, 2013

Subsystems (2)
Staging Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 Staging: dwc2: remove a kfree(NULL)

dwc2_hcd_release() calls dwc2_hcd_free() which frees ->core_params and sets it to NULL.

Signed-off-by Dan Carpenter <[email protected]>
drivers/staging/dwc2/hcd.c +0 -1
index cdb142d..e123f1e 100644
@@ -2939,7 +2939,6 @@ void dwc2_hcd_remove(struct device *dev, struct dwc2_hsotg *hsotg)
 	usb_remove_hcd(hcd);
 	hsotg->priv = NULL;
 	dwc2_hcd_release(hsotg);
-	kfree(hsotg->core_params);
 
 #ifdef CONFIG_USB_DWC2_TRACK_MISSED_SOFS
 	kfree(hsotg->last_frame_num_array);
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines

From: Dan Carpenter [mailto:[email protected]]
Sent: Thursday, March 14, 2013 11:04 PM

dwc2_hcd_release() calls dwc2_hcd_free() which frees ->core_params and sets it to NULL.

Signed-off-by Dan Carpenter <[email protected]>
drivers/staging/dwc2/hcd.c +0 -0
index cdb142d..e123f1e 100644

drivers/staging/dwc2/hcd.c void dwc2_hcd_remove(struct device *dev, struct dwc2_hsotg *hsotg) · line 2944

Quoted 7 lines
drivers/staging/dwc2/hcd.c +0 -1
@@ -2939,7 +2939,6 @@ void dwc2_hcd_remove(struct device *dev, struct dwc2_hsotg *hsotg)
 	usb_remove_hcd(hcd);
 	hsotg->priv = NULL;
 	dwc2_hcd_release(hsotg);
-	kfree(hsotg->core_params);
 
 #ifdef CONFIG_USB_DWC2_TRACK_MISSED_SOFS
 	kfree(hsotg->last_frame_num_array);
Acked-by Paul Zimmerman <[email protected]>