ARM: OMAP3+: Switch to use DT based cpu0-cpufreq driver
Subsystems (6)
cover ARM: OMAP3+: Switch to use DT based cpu0-cpufreq driver
The following series arose from trying to use BeagleBoard-XM (OMAP3 variant) for doing CPU DVFS using cpufreq-cpu0. This series will eventually result in migrating the cpufreq support only through device tree (part of the effort to migrate away from non-DT configurations for OMAP). Unfortunately, as already known, we have a bunch of legacy code and mutually dependent device tree conversion that is pending.
Key features pending:
A) clock framework transition to DT - this should happen soon, so this series hacks the clock node for the time being as suggested in review of original series
B) on processors that use voltage controller, voltage processor (VC/VP hardware loop using I2C_SR path) - we have started work on transitioning them to regulator framework driven by DT.
C) Adaptive Body Bias and SmartReflex AVS conversion to DT.
As a result of these pending features:
- OMAP4 TWL6030 and TPS62361 which set voltage ONLY over I2C_SR have no regulators associated at the moment - fortunately, we boot at highest voltage, so things still work.
- Missing ABB and AVS implies that for few of the SoCs (3630, OMAP4), I have not added those OPPs in DT yet - this also needs alignment with iMX, AM series like pending work, where certain OPPs need enabling based on efuse programmed bit sequences - since it is an add-on work, it is not addressed here.
Note: Somewhere in the future, when we have regulators driven off CCF and OMAP converted to CCF, we could remove the DT regulator requirements there as well.
Key benefit of the series is to allow all relevant TI platforms now to use a single cpufreq driver and equivalent frameworks in addition be part of the transition to DT. As a result of this series, CPUFreq feature will not be available for non-DT boot systems.
Original discussion thread which triggered this series:
http://marc.info/?l=linux-pm&m=136304313700602&w=2 https://patchwork.kernel.org/patch/2251841/ https://patchwork.kernel.org/patch/2251851/
Test coverage:
test script: http://pastebin.com/MpCRY0SB
Platforms verified:
beaglebone(rev A6a) - AM33xx compatible beagleboard (rev C1D) - OMAP3430 compatible omap3-beagle-xm -OMAP3630 compatible Pandaboard -(OMAP4430 ES2.3) verified with omapconf Pandaboard-ES -(OMAP4460 ES1.1) verified with omapconf
Series is based on v3.9-rc2 tag
Also available at:
https://github.com/nmenon/linux-2.6-playground/commits/push/cpufreq-cpu0-omap-all-v1
git link: git://github.com/nmenon/linux-2.6-playground.git
branch: cpufreq-cpu0-omap-all-v1
Nishanth Menon (8):
ARM: dts: OMAP34xx: move CPU OPP tables to device tree
ARM: dts: OMAP36xx: move CPU OPP tables to device tree
ARM: dts: OMAP3: use twl4030 vdd1 regulator for CPU
ARM: dts: OMAP443x: move CPU OPP tables to device tree
ARM: dts: omap4-panda: move generic sections to panda-common
ARM: dts: OMAP446x: move CPU OPP tables to device tree
ARM: OMAP3+: use cpu0-cpufreq driver
cpufreq: omap: remove omap-cpufreq
MAINTAINERS | 1 - arch/arm/boot/dts/omap3-beagle-xm.dts | 6 + arch/arm/boot/dts/omap3-beagle.dts | 6 + arch/arm/boot/dts/omap3-evm.dts | 6 + arch/arm/boot/dts/omap3.dtsi | 10 + arch/arm/boot/dts/omap36xx.dtsi | 12 ++ arch/arm/boot/dts/omap4-panda-a4.dts | 5 +- arch/arm/boot/dts/omap4-panda-common.dtsi | 205 ++++++++++++++++++++ arch/arm/boot/dts/omap4-panda-es.dts | 5 +- arch/arm/boot/dts/omap4-panda.dts | 200 +------------------- arch/arm/boot/dts/omap4.dtsi | 10 + arch/arm/boot/dts/omap446x.dtsi | 27 +++ arch/arm/boot/dts/twl4030.dtsi | 6 + arch/arm/mach-omap2/board-generic.c | 4 + arch/arm/mach-omap2/cclock33xx_data.c | 2 +- arch/arm/mach-omap2/cclock3xxx_data.c | 2 +- arch/arm/mach-omap2/cclock44xx_data.c | 2 +- arch/arm/mach-omap2/opp3xxx_data.c | 20 -- arch/arm/mach-omap2/opp4xxx_data.c | 23 --- drivers/cpufreq/Kconfig.arm | 6 - drivers/cpufreq/Makefile | 1 - drivers/cpufreq/omap-cpufreq.c | 291 ----------------------------- 22 files changed, 305 insertions(+), 545 deletions(-) create mode 100644 arch/arm/boot/dts/omap4-panda-common.dtsi create mode 100644 arch/arm/boot/dts/omap446x.dtsi delete mode 100644 drivers/cpufreq/omap-cpufreq.c
Size change information:
add/remove: 0/0 grow/shrink: 3/5 up/down: 74/-291 (-217)
function old new delta
omap_generic_init 96 140 +44 vermagic 49 64 +15 linux_banner 130 145 +15 kernel_config_data 18333 18330 -3 omap443x_opp_def_list 144 80 -64 omap36xx_opp_def_list 160 96 -64 omap446x_opp_def_list 192 112 -80 omap34xx_opp_def_list 208 128 -80
non-zero DTB size deltas(bytes):
old new delta filename
8068 8311 +243 omap3-beagle.dtb
8647 8874 +227 omap3-beagle-xm.dtb
7783 8026 +243 omap3-evm.dtb
8000 8183 +183 omap3-tobi.dtb
13646 13771 +125 omap4-panda-a4.dtb
13646 13771 +125 omap4-panda.dtb
13602 13719 +117 omap4-panda-es.dtb
16256 16381 +125 omap4-sdp.dtb
10889 11014 +125 omap4-var-som.dtb
Regards,
Nishanth Menon
Signature · 1 line
1.7.9.5
PATCH 1/8 ARM: dts: OMAP34xx: move CPU OPP tables to device tree
Add DT OPP table for OMAP34xx family of devices. This data is decoded by OF with of_init_opp_table() helper function.
This is in preparation to use generic cpu0-cpufreq driver.
--- arch/arm/boot/dts/omap3.dtsi | 10 ++++++++++ arch/arm/mach-omap2/opp3xxx_data.c | 11 ----------- 2 files changed, 10 insertions(+), 11 deletions(-)
arch/arm/boot/dts/omap3.dtsi +10 -0
@@ -23,6 +23,16 @@ cpus { cpu@0 { compatible = "arm,cortex-a8"; + /* OMAP3430 variants OPP1-5 */ + operating-points = < + /* kHz uV */ + 125000 975000 + 250000 1075000 + 500000 1200000 + 550000 1270000 + 600000 1350000 + >; + clock-latency = <300000>; /* From legacy driver */ }; };
arch/arm/mach-omap2/opp3xxx_data.c +0 -11
@@ -87,17 +87,6 @@ struct omap_volt_data omap36xx_vddcore_volt_data[] = {/* OPP data */ static struct omap_opp_def __initdata omap34xx_opp_def_list[] = { -/* MPU OPP1 */ -OPP_INITIALIZER ("mpu" , true,125000000 ,OMAP3430_VDD_MPU_OPP1_UV ), -/* MPU OPP2 */ -OPP_INITIALIZER ("mpu" , true,250000000 ,OMAP3430_VDD_MPU_OPP2_UV ), -/* MPU OPP3 */ -OPP_INITIALIZER ("mpu" , true,500000000 ,OMAP3430_VDD_MPU_OPP3_UV ), -/* MPU OPP4 */ -OPP_INITIALIZER ("mpu" , true,550000000 ,OMAP3430_VDD_MPU_OPP4_UV ), -/* MPU OPP5 */ -OPP_INITIALIZER ("mpu" , true,600000000 ,OMAP3430_VDD_MPU_OPP5_UV ), -/* * L3 OPP1 - 41.5 MHz is disabled because: The voltage for that OPP is * almost the same than the one at 83MHz thus providing very little
Signature · 6 lines
1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/8] ARM: dts: OMAP34xx: move CPU OPP tables to device tree
Quoted 4 lines · Nishanth Menon
Add DT OPP table for OMAP34xx family of devices. This data is decoded by OF with
of_init_opp_table()helper function.This is in preparation to use generic cpu0-cpufreq driver.
No mention here about what you are removing ;-)
Jon
PATCH 2/8 ARM: dts: OMAP36xx: move CPU OPP tables to device tree
In reply to Nishanth MenonAdd DT OPP table for OMAP36xx family of devices. This data is decoded by OF with of_init_opp_table() helper function. This overrides the default OMAP34xx CPU OPP table definition.
This is in preparation to use generic cpu0-cpufreq driver.
--- arch/arm/boot/dts/omap36xx.dtsi | 12 ++++++++++++ arch/arm/mach-omap2/opp3xxx_data.c | 9 --------- 2 files changed, 12 insertions(+), 9 deletions(-)
arch/arm/boot/dts/omap36xx.dtsi +12 -0
@@ -15,6 +15,18 @@ serial3 = &uart4; }; + cpus { + /* OMAP3630 'standard device' variants OPP50 to OPP130 */ + cpu@0 { + operating-points = < + /* kHz uV */ + 300000 975000 + 600000 1075000 + 800000 1200000 + >; + clock-latency = <300000>; /* From omap-cpufreq driver */ + }; + }; ocp { uart4: serial@49042000 { compatible = "ti,omap3-uart";
arch/arm/mach-omap2/opp3xxx_data.c +0 -9
@@ -114,15 +114,6 @@ static struct omap_opp_def __initdata omap34xx_opp_def_list[] = { };static struct omap_opp_def __initdata omap36xx_opp_def_list[] = { -/* MPU OPP1 - OPP50 */ -OPP_INITIALIZER ("mpu" , true,300000000 ,OMAP3630_VDD_MPU_OPP50_UV ), -/* MPU OPP2 - OPP100 */ -OPP_INITIALIZER ("mpu" , true,600000000 ,OMAP3630_VDD_MPU_OPP100_UV ), -/* MPU OPP3 - OPP-Turbo */ -OPP_INITIALIZER ("mpu" , false,800000000 ,OMAP3630_VDD_MPU_OPP120_UV ), -/* MPU OPP4 - OPP-SB */ -OPP_INITIALIZER ("mpu" , false,1000000000 ,OMAP3630_VDD_MPU_OPP1G_UV ), -/* L3 OPP1 - OPP50 */ OPP_INITIALIZER ("l3_main" , true,100000000 ,OMAP3630_VDD_CORE_OPP50_UV ),/* L3 OPP2 - OPP100, OPP-Turbo, OPP-SB */
Signature · 6 lines
1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/8] ARM: dts: OMAP36xx: move CPU OPP tables to device tree
Quoted 3 lines · Nishanth Menon
Add DT OPP table for OMAP36xx family of devices. This data is decoded by OF with
of_init_opp_table()helper function. This overrides the default OMAP34xx CPU OPP table definition.
Not sure I following the last sentence. The tables are in a different dtsi file and only the relevant file should be included, right?
Jon
Re: [PATCH 2/8] ARM: dts: OMAP36xx: move CPU OPP tables to device tree
Quoted 8 lines · Jon Hunter
Quoted 3 lines · Nishanth Menon
Add DT OPP table for OMAP36xx family of devices. This data is decoded by OF with
of_init_opp_table()helper function. This overrides the default OMAP34xx CPU OPP table definition.Not sure I following the last sentence. The tables are in a different dtsi file and only the relevant file should be included, right?
omap3630.dsi includes omap3.dtsi (which is meant for OMAP34xx). The opp tables introduced by this patch in omap36xx.dtsi will override the ones defined on omap3.dtsi. Will the following rephrase help clarify this?
Original:
This overrides the default OMAP34xx CPU OPP table definition. Suggested;
This overrides the default OMAP34xx CPU OPP table definition in omap3.dtsi.
Signature · 2 lines
Regards, Nishanth Menon
Re: [PATCH 2/8] ARM: dts: OMAP36xx: move CPU OPP tables to device tree
Quoted 14 lines · Nishanth Menon
Quoted 8 lines · Jon Hunter
Quoted 3 lines · Nishanth Menon
Add DT OPP table for OMAP36xx family of devices. This data is decoded by OF with
of_init_opp_table()helper function. This overrides the default OMAP34xx CPU OPP table definition.Not sure I following the last sentence. The tables are in a different dtsi file and only the relevant file should be included, right?
omap3630.dsi includes
omap3.dtsi(which is meant for OMAP34xx). The opp tables introduced by this patch inomap36xx.dtsiwill override the ones defined onomap3.dtsi. Will the following rephrase help clarify this?
Quoted 5 lines
Original:
This overrides the default OMAP34xx CPU OPP table definition. Suggested;
This overrides the default OMAP34xx CPU OPP table definition inomap3.dtsi.
Sorry, I just missed that the omap3430 opps were in omap3.dtsi and not omap34xx.dtsi. I guess I am not familiar with how the DTC overrides nodes, however, at least from a readability standpoint it would seem nice to have the omap3430 opps in a omap3430 specific dtsi and not omap3.dtsi. However, thats just my opinion.
Cheers
Jon
Re: [PATCH 2/8] ARM: dts: OMAP36xx: move CPU OPP tables to device tree
Quoted 22 lines · Jon Hunter
Quoted 14 lines · Nishanth Menon
Quoted 8 lines · Jon Hunter
Quoted 3 lines · Nishanth Menon
Add DT OPP table for OMAP36xx family of devices. This data is decoded by OF with
of_init_opp_table()helper function. This overrides the default OMAP34xx CPU OPP table definition.Not sure I following the last sentence. The tables are in a different dtsi file and only the relevant file should be included, right?
omap3630.dsi includes
omap3.dtsi(which is meant for OMAP34xx). The opp tables introduced by this patch inomap36xx.dtsiwill override the ones defined onomap3.dtsi. Will the following rephrase help clarify this?Quoted 5 lines
Original:
This overrides the default OMAP34xx CPU OPP table definition. Suggested;
This overrides the default OMAP34xx CPU OPP table definition inomap3.dtsi.
Quoted 5 lines
Sorry, I just missed that the omap3430 opps were in
omap3.dtsiand notomap34xx.dtsi. I guess I am not familiar with how the DTC overrides nodes, however, at least from a readability standpoint it would seem nice to have the omap3430 opps in a omap3430 specific dtsi and notomap3.dtsi. However, thats just my opinion.
most of omap3630 is based off omap3430. I know from an readability point of view, it might have been good to split that to omap3-common.dtsi, omap34xx.dtsi, omap36xx.dtsi etc.. But there is no real need at this point in time to do that. Unless, ofcourse, we'd like to set that up as an standard for all OMAP SoCs...
Signature · 2 lines
Regards, Nishanth Menon
Re: [PATCH 2/8] ARM: dts: OMAP36xx: move CPU OPP tables to device tree
Quoted 28 lines · Nishanth Menon
Quoted 22 lines · Jon Hunter
Quoted 14 lines · Nishanth Menon
Quoted 8 lines · Jon Hunter
Quoted 3 lines · Nishanth Menon
Add DT OPP table for OMAP36xx family of devices. This data is decoded by OF with
of_init_opp_table()helper function. This overrides the default OMAP34xx CPU OPP table definition.Not sure I following the last sentence. The tables are in a different dtsi file and only the relevant file should be included, right?
omap3630.dsi includes
omap3.dtsi(which is meant for OMAP34xx). The opp tables introduced by this patch inomap36xx.dtsiwill override the ones defined onomap3.dtsi. Will the following rephrase help clarify this?Quoted 5 lines
Original:
This overrides the default OMAP34xx CPU OPP table definition. Suggested;
This overrides the default OMAP34xx CPU OPP table definition inomap3.dtsi.Quoted 5 lines
Sorry, I just missed that the omap3430 opps were in
omap3.dtsiand notomap34xx.dtsi. I guess I am not familiar with how the DTC overrides nodes, however, at least from a readability standpoint it would seem nice to have the omap3430 opps in a omap3430 specific dtsi and notomap3.dtsi. However, thats just my opinion.
Quoted 5 lines
most of omap3630 is based off omap3430. I know from an readability point of view, it might have been good to split that to
omap3-common.dtsi,omap34xx.dtsi,omap36xx.dtsietc.. But there is no real need at this point in time to do that. Unless, ofcourse, we'd like to set that up as an standard for all OMAP SoCs...
How would omap3-common.dtsi be any different from omap3.dtsi? I don't wish us to go nuts with creating dtsi files either, but having an omap3430.dtsi does not seem unreasonable to me, but that is just my opinion.
Jon
Re: [PATCH 2/8] ARM: dts: OMAP36xx: move CPU OPP tables to device tree
Quoted 36 lines · Jon Hunter
Quoted 28 lines · Nishanth Menon
Quoted 22 lines · Jon Hunter
Quoted 14 lines · Nishanth Menon
Quoted 8 lines · Jon Hunter
Quoted 3 lines · Nishanth Menon
Add DT OPP table for OMAP36xx family of devices. This data is decoded by OF with
of_init_opp_table()helper function. This overrides the default OMAP34xx CPU OPP table definition.Not sure I following the last sentence. The tables are in a different dtsi file and only the relevant file should be included, right?
omap3630.dsi includes
omap3.dtsi(which is meant for OMAP34xx). The opp tables introduced by this patch inomap36xx.dtsiwill override the ones defined onomap3.dtsi. Will the following rephrase help clarify this?Quoted 5 lines
Original:
This overrides the default OMAP34xx CPU OPP table definition. Suggested;
This overrides the default OMAP34xx CPU OPP table definition inomap3.dtsi.Quoted 5 lines
Sorry, I just missed that the omap3430 opps were in
omap3.dtsiand notomap34xx.dtsi. I guess I am not familiar with how the DTC overrides nodes, however, at least from a readability standpoint it would seem nice to have the omap3430 opps in a omap3430 specific dtsi and notomap3.dtsi. However, thats just my opinion.Quoted 5 lines
most of omap3630 is based off omap3430. I know from an readability point of view, it might have been good to split that to
omap3-common.dtsi,omap34xx.dtsi,omap36xx.dtsietc.. But there is no real need at this point in time to do that. Unless, ofcourse, we'd like to set that up as an standard for all OMAP SoCs...
Quoted 3 lines
How would
omap3-common.dtsibe any different fromomap3.dtsi? I don't wish us to go nuts with creating dtsi files either, but having anomap3430.dtsidoes not seem unreasonable to me, but that is just my opinion.
considering omap34xx variants, omap343x.dtsi ;). Will do in v2.
Signature · 2 lines
Regards, Nishanth Menon
PATCH 3/8 ARM: dts: OMAP3: use twl4030 vdd1 regulator for CPU
In reply to Nishanth MenonDefine VDD1 regulator in twl4030 DT and mark it as the supply for the various OMAP3 platforms.
--- arch/arm/boot/dts/omap3-beagle-xm.dts | 6 ++++++ arch/arm/boot/dts/omap3-beagle.dts | 6 ++++++ arch/arm/boot/dts/omap3-evm.dts | 6 ++++++ arch/arm/boot/dts/twl4030.dtsi | 6 ++++++ 4 files changed, 24 insertions(+)
arch/arm/boot/dts/omap3-beagle-xm.dts +6 -0
@@ -13,6 +13,12 @@ model = "TI OMAP3 BeagleBoard xM"; compatible = "ti,omap3-beagle-xm, ti,omap3-beagle", "ti,omap3"; + cpus { + cpu@0 { + cpu0-supply = <&vcc>; + }; + }; + memory { device_type = "memory"; reg = <0x80000000 0x20000000>; /* 512 MB */
arch/arm/boot/dts/omap3-beagle.dts +6 -0
@@ -13,6 +13,12 @@ model = "TI OMAP3 BeagleBoard"; compatible = "ti,omap3-beagle", "ti,omap3"; + cpus { + cpu@0 { + cpu0-supply = <&vcc>; + }; + }; + memory { device_type = "memory"; reg = <0x80000000 0x10000000>; /* 256 MB */
arch/arm/boot/dts/omap3-evm.dts +6 -0
@@ -13,6 +13,12 @@ model = "TI OMAP3 EVM (OMAP3530, AM/DM37x)"; compatible = "ti,omap3-evm", "ti,omap3"; + cpus { + cpu@0 { + cpu0-supply = <&vcc>; + }; + }; + memory { device_type = "memory"; reg = <0x80000000 0x10000000>; /* 256 MB */
arch/arm/boot/dts/twl4030.dtsi +6 -0
@@ -23,6 +23,12 @@ compatible = "ti,twl4030-wdt"; }; + vcc: regulator-vdd1 { + compatible = "ti,twl4030-vdd1"; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <1450000>; + }; + vdac: regulator-vdac { compatible = "ti,twl4030-vdac"; regulator-min-microvolt = <1800000>;
Signature · 1 line
1.7.9.5
PATCH 4/8 ARM: dts: OMAP443x: move CPU OPP tables to device tree
In reply to Nishanth MenonAdd DT OPP table for OMAP443x family of devices. This data is decoded by OF with of_init_opp_table() helper function.
This is in preparation to use generic cpu0-cpufreq driver.
--- arch/arm/boot/dts/omap4.dtsi | 10 ++++++++++ arch/arm/mach-omap2/opp4xxx_data.c | 8 -------- 2 files changed, 10 insertions(+), 8 deletions(-)
arch/arm/boot/dts/omap4.dtsi +10 -0
@@ -31,6 +31,16 @@ cpu@0 { compatible = "arm,cortex-a9"; next-level-cache = <&L2>; + /* OMAP4430 variants OPP50-OPPNT */ + operating-points = < + /* kHz uV */ + 300000 1025000 + 600000 1200000 + 800000 1313000 + 1008000 1375000 + >; + clock-latency = <300000>; /* From omap-cpufreq driver */ + voltage-tolerance = <2>; /* 2 % */ }; cpu@1 { compatible = "arm,cortex-a9";
arch/arm/mach-omap2/opp4xxx_data.c +0 -8
@@ -65,14 +65,6 @@ struct omap_volt_data omap443x_vdd_core_volt_data[] = {static struct omap_opp_def __initdata omap443x_opp_def_list[] = { -/* MPU OPP1 - OPP50 */ -OPP_INITIALIZER ("mpu" , true,300000000 ,OMAP4430_VDD_MPU_OPP50_UV ), -/* MPU OPP2 - OPP100 */ -OPP_INITIALIZER ("mpu" , true,600000000 ,OMAP4430_VDD_MPU_OPP100_UV ), -/* MPU OPP3 - OPP-Turbo */ -OPP_INITIALIZER ("mpu" , true,800000000 ,OMAP4430_VDD_MPU_OPPTURBO_UV ), -/* MPU OPP4 - OPP-SB */ -OPP_INITIALIZER ("mpu" , true,1008000000 ,OMAP4430_VDD_MPU_OPPNITRO_UV ),/* L3 OPP1 - OPP50 */ OPP_INITIALIZER ("l3_main_1" , true,100000000 ,OMAP4430_VDD_CORE_OPP50_UV ),/* L3 OPP2 - OPP100, OPP-Turbo, OPP-SB */
Signature · 1 line
1.7.9.5
PATCH 5/8 ARM: dts: omap4-panda: move generic sections to panda-common
In reply to Nishanth MenonPandaBoard, PandaBoard-A4 revisions use OMAP4430.
PandaBoard-ES version of the board uses OMAP4460.
Move the original panda dts file into a common dtsi used by all panda variants. This allows us to introduce SoC variation for PandaBoard ES without impacting other PandaBoard versions that are supported.
---
NOTE: even though this patch was generated with -M, the diff might be a bit confusing.
arch/arm/boot/dts/omap4-panda-a4.dts | 5 +- arch/arm/boot/dts/omap4-panda-common.dtsi | 205 +++++++++++++++++++++++++++++ arch/arm/boot/dts/omap4-panda-es.dts | 5 +- arch/arm/boot/dts/omap4-panda.dts | 200 +--------------------------- 4 files changed, 215 insertions(+), 200 deletions(-) create mode 100644 arch/arm/boot/dts/omap4-panda-common.dtsi
arch/arm/boot/dts/omap4-panda-a4.dts +4 -1
@@ -5,7 +5,10 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ -/include/ "omap4-panda.dts" +/dts-v1/; + +/include/ "omap4.dtsi" +/include/ "omap4-panda-common.dtsi" /* Pandaboard Rev A4+ have external pullups on SCL & SDA */ &dss_hdmi_pins {
arch/arm/boot/dts/omap4-panda-common.dtsi new file +205 -0
205 lines not on this page · raw message
arch/arm/boot/dts/omap4-panda-es.dts +4 -1
@@ -5,7 +5,10 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ -/include/ "omap4-panda.dts" +/dts-v1/; + +/include/ "omap4.dtsi" +/include/ "omap4-panda-common.dtsi" /* Audio routing is differnet between PandaBoard4430 and PandaBoardES */ &sound {
arch/arm/boot/dts/omap4-panda.dts +2 -198
208 lines not on this page · raw message
Signature · 6 lines
1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 6/8 ARM: dts: OMAP446x: move CPU OPP tables to device tree
In reply to Nishanth MenonOMAP4430 and 4460 have different OPP definitions. So, create an SoC variant dtsi file for 4460 and move the OPP definitions to it. Add DT OPP table for OMAP446x family of devices. This data is decoded by OF with of_init_opp_table() helper function.
This is in preparation to use generic cpu0-cpufreq driver.
--- arch/arm/boot/dts/omap4-panda-es.dts | 2 +- arch/arm/boot/dts/omap446x.dtsi | 27 +++++++++++++++++++++++++++ arch/arm/mach-omap2/opp4xxx_data.c | 15 --------------- 3 files changed, 28 insertions(+), 16 deletions(-) create mode 100644 arch/arm/boot/dts/omap446x.dtsi
arch/arm/boot/dts/omap4-panda-es.dts +1 -1
@@ -7,7 +7,7 @@ */ /dts-v1/; -/include/ "omap4.dtsi" +/include/ "omap446x.dtsi" /include/ "omap4-panda-common.dtsi" /* Audio routing is differnet between PandaBoard4430 and PandaBoardES */
arch/arm/boot/dts/omap446x.dtsi new file +27 -0
@@ -0,0 +1,27 @@ +/* + * Device Tree Source for OMAP446x SoC + * + * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/ + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/include/ "omap4.dtsi" + +/ { + cpus { + /* OMAP446x 'standard device' variants OPP50 to OPPTurbo */ + cpu@0 { + operating-points = < + /* kHz uV */ + 350000 975000 + 700000 1075000 + 920000 1200000 + >; + clock-latency = <300000>; /* From omap-cpufreq driver */ + voltage-tolerance = <2>; /* 2 % */ + }; + }; +};
arch/arm/mach-omap2/opp4xxx_data.c +0 -15
@@ -116,21 +116,6 @@ struct omap_volt_data omap446x_vdd_core_volt_data[] = { };static struct omap_opp_def __initdata omap446x_opp_def_list[] = { -/* MPU OPP1 - OPP50 */ -OPP_INITIALIZER ("mpu" , true,350000000 ,OMAP4460_VDD_MPU_OPP50_UV ), -/* MPU OPP2 - OPP100 */ -OPP_INITIALIZER ("mpu" , true,700000000 ,OMAP4460_VDD_MPU_OPP100_UV ), -/* MPU OPP3 - OPP-Turbo */ -OPP_INITIALIZER ("mpu" , true,920000000 ,OMAP4460_VDD_MPU_OPPTURBO_UV ), -/* -* MPU OPP4 - OPP-Nitro + Disabled as the reference schematics -* recommends TPS623631 - confirm and enable the opp in board file -* XXX: May be we should enable these based on mpu capability and -* Exception board files disable it... -*/ -OPP_INITIALIZER ("mpu" , false,1200000000 ,OMAP4460_VDD_MPU_OPPNITRO_UV ), -/* MPU OPP4 - OPP-Nitro SpeedBin */ -OPP_INITIALIZER ("mpu" , false,1500000000 ,OMAP4460_VDD_MPU_OPPNITRO_UV ),/* L3 OPP1 - OPP50 */ OPP_INITIALIZER ("l3_main_1" , true,100000000 ,OMAP4460_VDD_CORE_OPP50_UV ),/* L3 OPP2 - OPP100 */
Signature · 6 lines
1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] ARM: dts: OMAP446x: move CPU OPP tables to device tree
Quoted 2 lines · Nishanth Menon
OMAP4430 and 4460 have different OPP definitions. So, create an SoC variant dtsi file for 4460 and move the OPP definitions to it.
FYI, I had to create a similar file for PMU [1]. However, I called it omap4460.dtsi and not omap446x.dtsi as there is only one omap446x device. That should go into to v3.10 and so may be worth basing this on top. I do like your omap4-panda-common.dtsi that is a nice clean-up.
Cheers
Jon
Re: [PATCH 6/8] ARM: dts: OMAP446x: move CPU OPP tables to device tree
Quoted 7 lines · Jon Hunter
Quoted 2 lines · Nishanth Menon
OMAP4430 and 4460 have different OPP definitions. So, create an SoC variant dtsi file for 4460 and move the OPP definitions to it.
FYI, I had to create a similar file for PMU [1]. However, I called it
omap4460.dtsiand notomap446x.dtsias there is only one omap446x
Hmm, guess I was paranoid about marketing folks spinning off another omap446x variant out into the market. Since it is not yet done, nor known if they will ever do it, am OK with 4460 convention.
Quoted 2 lines
device. That should go into to v3.10 and so may be worth basing this on top. I do like your
omap4-panda-common.dtsithat is a nice clean-up.
Thanks on the tip - Sounds good, since this series is based on DT, I will base my changes on top of for_3.10 branch.
Quoted 6 lines
Cheers
Jon
Signature · 2 lines
Regards, Nishanth Menon
PATCH 7/8 ARM: OMAP3+: use cpu0-cpufreq driver
In reply to Nishanth MenonWith OMAP3+ and AM33xx supported SoC having defined CPU DT entries with operating-points defined, we can now use the SoC generic cpu0-cpufreq driver to start using it, lets now switch to the generic driver.
As part of this change, switch the dummy clock node to use cpufreq-cpu0. This is an suggested solution till we have OMAP clock nodes in DT. Once the DT conversion is complete, we can then do: clocks = <&dpll_mpu_ck>; or the SoC specific equivalent.
Inspired by patch: https://patchwork.kernel.org/patch/2067841/
now made generic.
--- arch/arm/mach-omap2/board-generic.c | 4 ++++ arch/arm/mach-omap2/cclock33xx_data.c | 2 +- arch/arm/mach-omap2/cclock3xxx_data.c | 2 +- arch/arm/mach-omap2/cclock44xx_data.c | 2 +- 4 files changed, 7 insertions(+), 3 deletions(-)
arch/arm/mach-omap2/board-generic.c +4 -0
@@ -49,6 +49,10 @@ static void __init omap_generic_init(void)omap4_panda_display_init_of (); else if (of_machine_is_compatible("ti,omap4-sdp"))omap_4430sdp_display_init_of (); +if (IS_ENABLED (CONFIG_GENERIC_CPUFREQ_CPU0 )) { +struct platform_device_info devinfo = { .name ="cpufreq-cpu0" , }; +platform_device_register_full (&devinfo); + } }#ifdef CONFIG_SOC_OMAP2420
arch/arm/mach-omap2/cclock33xx_data.c +1 -1
@@ -852,7 +852,7 @@ static struct omap_clk am33xx_clks[] = {CLK (NULL ,"dpll_core_m5_ck" , &dpll_core_m5_ck,CK_AM33XX ),CLK (NULL ,"dpll_core_m6_ck" , &dpll_core_m6_ck,CK_AM33XX ),CLK (NULL ,"dpll_mpu_ck" , &dpll_mpu_ck,CK_AM33XX ), -CLK ("cpu0" ,NULL , &dpll_mpu_ck,CK_AM33XX ), +CLK ("cpufreq-cpu0.0" ,NULL , &dpll_mpu_ck,CK_AM33XX ),CLK (NULL ,"dpll_mpu_m2_ck" , &dpll_mpu_m2_ck,CK_AM33XX ),CLK (NULL ,"dpll_ddr_ck" , &dpll_ddr_ck,CK_AM33XX ), CLK(NULL, "dpll_ddr_m2_ck", &dpll_ddr_m2_ck, CK_AM33XX),
arch/arm/mach-omap2/cclock3xxx_data.c +1 -1
@@ -3501,7 +3501,7 @@ static struct omap_clk omap3xxx_clks[] = {CLK (NULL ,"uart4_ick" , &uart4_ick_am35xx,CK_AM35XX ),CLK (NULL ,"timer_32k_ck" , &omap_32k_fck,CK_3XXX ),CLK (NULL ,"timer_sys_ck" , &sys_ck,CK_3XXX ), - CLK(NULL, "cpufreq_ck", &dpll1_ck, CK_3XXX), + CLK("cpufreq-cpu0.0", NULL, &dpll1_ck, CK_3XXX), }; static const char *enable_init_clks[] = {
arch/arm/mach-omap2/cclock44xx_data.c +1 -1
@@ -1660,7 +1660,7 @@ static struct omap_clk omap44xx_clks[] = {CLK ("4013a000.timer" ,"timer_sys_ck" , &syc_clk_div_ck,CK_443X ),CLK ("4013c000.timer" ,"timer_sys_ck" , &syc_clk_div_ck,CK_443X ),CLK ("4013e000.timer" ,"timer_sys_ck" , &syc_clk_div_ck,CK_443X ), - CLK(NULL, "cpufreq_ck", &dpll_mpu_ck, CK_443X), + CLK("cpufreq-cpu0.0", NULL, &dpll_mpu_ck, CK_443X), };int __init omap4xxx_clk_init (void )
Signature · 1 line
1.7.9.5
PATCH 8/8 cpufreq: omap: remove omap-cpufreq
In reply to Nishanth MenonWe can now use cpufreq-cpu0 driver using DT entries. remove the redundant omap-cpufreq driver from the tree. Remove MAINTAINERS file entry for the same as well.
--- MAINTAINERS | 1 - drivers/cpufreq/Kconfig.arm | 6 - drivers/cpufreq/Makefile | 1 - drivers/cpufreq/omap-cpufreq.c | 291 ---------------------------------------- 4 files changed, 299 deletions(-) delete mode 100644 drivers/cpufreq/omap-cpufreq.c
MAINTAINERS +0 -1
@@ -5654,7 +5654,6 @@ M: Kevin Hilman <[email protected]> L: [email protected] S: Maintained F: arch/arm/*omap*/*pm* -F: drivers/cpufreq/omap-cpufreq.c OMAP POWERDOMAIN/CLOCKDOMAIN SOC ADAPTATION LAYER SUPPORT M: Rajendra Nayak <[email protected]>
drivers/cpufreq/Kconfig.arm +0 -6
@@ -2,12 +2,6 @@ # ARM CPU Frequency scaling drivers # -config ARM_OMAP2PLUS_CPUFREQ - bool "TI OMAP2+" - depends on ARCH_OMAP2PLUS - default ARCH_OMAP2PLUS - select CPU_FREQ_TABLE - config ARM_S3C2416_CPUFREQ bool "S3C2416 CPU Frequency scaling support" depends on CPU_S3C2416
drivers/cpufreq/Makefile +0 -1
@@ -53,7 +53,6 @@ obj-$(CONFIG_ARM_EXYNOS4210_CPUFREQ) += exynos4210-cpufreq.o obj-$(CONFIG_ARM_EXYNOS4X12_CPUFREQ) += exynos4x12-cpufreq.o obj-$(CONFIG_ARM_EXYNOS5250_CPUFREQ) += exynos5250-cpufreq.o obj-$(CONFIG_ARM_KIRKWOOD_CPUFREQ) += kirkwood-cpufreq.o -obj-$(CONFIG_ARM_OMAP2PLUS_CPUFREQ) += omap-cpufreq.o obj-$(CONFIG_ARM_SPEAR_CPUFREQ) += spear-cpufreq.o obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o obj-$(CONFIG_ARM_IMX6Q_CPUFREQ) += imx6q-cpufreq.o
drivers/cpufreq/omap-cpufreq.c deleted +0 -291
291 lines not on this page · raw message
Signature · 6 lines
1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 8/8] cpufreq: omap: remove omap-cpufreq
Quoted 15 lines · Nishanth Menon
We can now use cpufreq-cpu0 driver using DT entries. remove the redundant omap-cpufreq driver from the tree. Remove
MAINTAINERSfile entry for the same as well.Cc Kevin Hilman <[email protected]>Cc "Benoît Cousson" <[email protected]>Cc Santosh Shilimkar <[email protected]>Cc Shawn Guo <[email protected]>Cc Keerthy <[email protected]>
Quoted 8 lines
Signed-off-by Nishanth Menon <[email protected]>--- MAINTAINERS | 1 - drivers/cpufreq/Kconfig.arm | 6 - drivers/cpufreq/Makefile | 1 - drivers/cpufreq/omap-cpufreq.c | 291 ---------------------------------------- 4 files changed, 299 deletions(-) delete mode 100644 drivers/cpufreq/omap-cpufreq.c
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 8/8] cpufreq: omap: remove omap-cpufreq
Quoted 25 lines · Viresh Kumar
Quoted 15 lines · Nishanth Menon
We can now use cpufreq-cpu0 driver using DT entries. remove the redundant omap-cpufreq driver from the tree. Remove
MAINTAINERSfile entry for the same as well.Cc Kevin Hilman <[email protected]>Cc "Benoīt Cousson" <[email protected]>Cc Santosh Shilimkar <[email protected]>Cc Shawn Guo <[email protected]>Cc Keerthy <[email protected]>Quoted 8 lines
Signed-off-by Nishanth Menon <[email protected]>--- MAINTAINERS | 1 - drivers/cpufreq/Kconfig.arm | 6 - drivers/cpufreq/Makefile | 1 - drivers/cpufreq/omap-cpufreq.c | 291 ---------------------------------------- 4 files changed, 299 deletions(-) delete mode 100644 drivers/cpufreq/omap-cpufreq.c
Quoted 1 line
Acked-by Viresh Kumar <[email protected]>
Thanks Viresh, but based on the direction of the discussion going on (keeping this driver active for non-DT configuration),
I will have to drop this patch in it's entirety.
---
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 23 lines · Nishanth Menon
The following series arose from trying to use BeagleBoard-XM (OMAP3 variant) for doing CPU DVFS using cpufreq-cpu0. This series will eventually result in migrating the cpufreq support only through device tree (part of the effort to migrate away from non-DT configurations for OMAP). Unfortunately, as already known, we have a bunch of legacy code and mutually dependent device tree conversion that is pending.
Key features pending:
A) clock framework transition to DT - this should happen soon, so this series hacks the clock node for the time being as suggested in review of original series
B) on processors that use voltage controller, voltage processor (VC/VP hardware loop usingI2C_SRpath) - we have started work on transitioning them to regulator framework driven by DT.
C) Adaptive Body Bias and SmartReflex AVS conversion to DT.As a result of these pending features:
- OMAP4 TWL6030 and TPS62361 which set voltage ONLY overI2C_SRhave no regulators associated at the moment - fortunately, we boot at highest voltage, so things still work.
- Missing ABB and AVS implies that for few of the SoCs (3630, OMAP4), I have not added those OPPs in DT yet - this also needs alignment with iMX, AM series like pending work, where certain OPPs need enabling based on efuse programmed bit sequences - since it is an add-on work, it is not addressed here.
Quoted 2 lines
Note: Somewhere in the future, when we have regulators driven off CCF and OMAP converted to CCF, we could remove the DT regulator requirements there as well.
OMAP has been converted to the common clock framework (CCF). Are you referring to clock framework transition to DT or something else?
Jon
Quoted 25 lines · Jon Hunter
Quoted 23 lines · Nishanth Menon
The following series arose from trying to use BeagleBoard-XM (OMAP3 variant) for doing CPU DVFS using cpufreq-cpu0. This series will eventually result in migrating the cpufreq support only through device tree (part of the effort to migrate away from non-DT configurations for OMAP). Unfortunately, as already known, we have a bunch of legacy code and mutually dependent device tree conversion that is pending.
Key features pending:
A) clock framework transition to DT - this should happen soon, so this series hacks the clock node for the time being as suggested in review of original series
B) on processors that use voltage controller, voltage processor (VC/VP hardware loop usingI2C_SRpath) - we have started work on transitioning them to regulator framework driven by DT.
C) Adaptive Body Bias and SmartReflex AVS conversion to DT.As a result of these pending features:
- OMAP4 TWL6030 and TPS62361 which set voltage ONLY overI2C_SRhave no regulators associated at the moment - fortunately, we boot at highest voltage, so things still work.
- Missing ABB and AVS implies that for few of the SoCs (3630, OMAP4), I have not added those OPPs in DT yet - this also needs alignment with iMX, AM series like pending work, where certain OPPs need enabling based on efuse programmed bit sequences - since it is an add-on work, it is not addressed here.
Quoted 5 lines
Quoted 2 lines
Note: Somewhere in the future, when we have regulators driven off CCF and OMAP converted to CCF, we could remove the DT regulator requirements there as well.
OMAP has been converted to the common clock framework (CCF). Are you referring to clock framework transition to DT or something else?
I should have been explicit here - we do not have DT entries for clock nodes for OMAP. For example, compare:
git grep clocks arch/arm/boot/dts/omap*.dts*
Vs
git grep clocks arch/arm/boot/dts/imx*.dts*
The specific comment above was intended to see the following series equivalent in upstream:
https://patchwork.kernel.org/patch/2195431/
https://patchwork.kernel.org/patch/2195421/
https://patchwork.kernel.org/patch/2195451/
https://patchwork.kernel.org/patch/2195441/
https://patchwork.kernel.org/patch/2195461/
Signature · 2 lines
Regards, Nishanth Menon
Quoted 14 lines · Nishanth Menon
The following series arose from trying to use BeagleBoard-XM (OMAP3 variant) for doing CPU DVFS using cpufreq-cpu0. This series will eventually result in migrating the cpufreq support only through device tree (part of the effort to migrate away from non-DT configurations for OMAP). Unfortunately, as already known, we have a bunch of legacy code and mutually dependent device tree conversion that is pending.
Key features pending:
A) clock framework transition to DT - this should happen soon, so this series hacks the clock node for the time being as suggested in review of original series
B) on processors that use voltage controller, voltage processor (VC/VP hardware loop usingI2C_SRpath) - we have started work on transitioning them to regulator framework driven by DT.
C) Adaptive Body Bias and SmartReflex AVS conversion to DT.
Quoted 9 lines
As a result of these pending features:
- OMAP4 TWL6030 and TPS62361 which set voltage ONLY overI2C_SRhave no regulators associated at the moment - fortunately, we boot at highest voltage, so things still work.
- Missing ABB and AVS implies that for few of the SoCs (3630, OMAP4), I have not added those OPPs in DT yet - this also needs alignment with iMX, AM series like pending work, where certain OPPs need enabling based on efuse programmed bit sequences - since it is an add-on work, it is not addressed here.
Thanks for looking into it.
Quoted 8 lines
Note: Somewhere in the future, when we have regulators driven off CCF and OMAP converted to CCF, we could remove the DT regulator requirements there as well.
Key benefit of the series is to allow all relevant TI platforms now to use a single cpufreq driver and equivalent frameworks in addition be part of the transition to DT. As a result of this series, CPUFreq feature will not be available for non-DT boot systems.
As commented by Jon on internal thread, I am also against the idea of dropping non-DT support now. Till we migrate to 100 % DT, it is best to keep support alive. Especial OMAP3 based devices.
Why don't you take phased approach and have both supported for time being. Then once we move to DT only, we just drop the non-DT support as we plan to do for many more stuff.
BTW, we are using only CPUFreq driver before this series as well. I guess you mean the common CPUFReq drivers used by other ARM SOCs.
Regards,
Santosh
Quoted 24 lines · Santosh Shilimkar
Quoted 14 lines · Nishanth Menon
The following series arose from trying to use BeagleBoard-XM (OMAP3 variant) for doing CPU DVFS using cpufreq-cpu0. This series will eventually result in migrating the cpufreq support only through device tree (part of the effort to migrate away from non-DT configurations for OMAP). Unfortunately, as already known, we have a bunch of legacy code and mutually dependent device tree conversion that is pending.
Key features pending:
A) clock framework transition to DT - this should happen soon, so this series hacks the clock node for the time being as suggested in review of original series
B) on processors that use voltage controller, voltage processor (VC/VP hardware loop usingI2C_SRpath) - we have started work on transitioning them to regulator framework driven by DT.
C) Adaptive Body Bias and SmartReflex AVS conversion to DT.Quoted 9 lines
As a result of these pending features:
- OMAP4 TWL6030 and TPS62361 which set voltage ONLY overI2C_SRhave no regulators associated at the moment - fortunately, we boot at highest voltage, so things still work.
- Missing ABB and AVS implies that for few of the SoCs (3630, OMAP4), I have not added those OPPs in DT yet - this also needs alignment with iMX, AM series like pending work, where certain OPPs need enabling based on efuse programmed bit sequences - since it is an add-on work, it is not addressed here.
Quoted 1 line
Thanks for looking into it.
Yes, this should be the next stage to solve.
Quoted 13 lines
Quoted 9 lines
Note: Somewhere in the future, when we have regulators driven off CCF and OMAP converted to CCF, we could remove the DT regulator requirements there as well.
Key benefit of the series is to allow all relevant TI platforms now to use a single cpufreq driver and equivalent frameworks in addition be part of the transition to DT. As a result of this series, CPUFreq feature will not be available for non-DT boot systems.
As commented by Jon on internal thread, I am also against the idea of dropping non-DT support now. Till we migrate to 100 % DT, it is best to keep support alive. Especial OMAP3 based devices.
Quoted 6 lines
Why don't you take phased approach and have both supported for time being. Then once we move to DT only, we just drop the non-DT support as we plan to do for many more stuff.
BTW, we are using only CPUFreq driver before this series as well. I guess you mean the common CPUFReq drivers used by other ARM SOCs.
I had removed the entries for OPPs and clock nodes used by omap-cpufreq.c and deleted the omap-cpufreq.c as well - so the statement "CPUFreq wont work in non-DT" configuration was accurate.
My intent was as follows:
- This series is driven mainly from maintenance angle - having to maintain two different drivers (legacy omap-cpufreq.c and cpufreq-cpu0.c), ensuring the data is proper in both OPP tables in kernel and DT entries is sure to cause mayhem sometime. This is not just an pain for OMAP community, but for cpufreq community as well (since there is absolutely no reason other than OMAP legacy burden for making cpu0-cpufreq work in non-DT world).
- as long as non-DT supported boot provides all features, there is no real feature incentive to move to DT.
But, that said, there is one path I see possible:
- keep omap-cpufreq alive (BUT I will add a patch that will not let it init when in DT entries are present)
- add DT entries for all relevant OMAPs - in DT mode, we will *only* support cpufreq-cpu0
- All future SoCs will continue to use cpufreq-cpu0 using DT, as was the alignment I believe.
Signature · 2 lines
Regards, Nishanth Menon
Quoted 50 lines · Nishanth Menon
Quoted 24 lines · Santosh Shilimkar
Quoted 14 lines · Nishanth Menon
The following series arose from trying to use BeagleBoard-XM (OMAP3 variant) for doing CPU DVFS using cpufreq-cpu0. This series will eventually result in migrating the cpufreq support only through device tree (part of the effort to migrate away from non-DT configurations for OMAP). Unfortunately, as already known, we have a bunch of legacy code and mutually dependent device tree conversion that is pending.
Key features pending:
A) clock framework transition to DT - this should happen soon, so this series hacks the clock node for the time being as suggested in review of original series
B) on processors that use voltage controller, voltage processor (VC/VP hardware loop usingI2C_SRpath) - we have started work on transitioning them to regulator framework driven by DT.
C) Adaptive Body Bias and SmartReflex AVS conversion to DT.Quoted 9 lines
As a result of these pending features:
- OMAP4 TWL6030 and TPS62361 which set voltage ONLY overI2C_SRhave no regulators associated at the moment - fortunately, we boot at highest voltage, so things still work.
- Missing ABB and AVS implies that for few of the SoCs (3630, OMAP4), I have not added those OPPs in DT yet - this also needs alignment with iMX, AM series like pending work, where certain OPPs need enabling based on efuse programmed bit sequences - since it is an add-on work, it is not addressed here.Quoted 1 line
Thanks for looking into it.
Yes, this should be the next stage to solve.
Quoted 13 lines
Quoted 9 lines
Note: Somewhere in the future, when we have regulators driven off CCF and OMAP converted to CCF, we could remove the DT regulator requirements there as well.
Key benefit of the series is to allow all relevant TI platforms now to use a single cpufreq driver and equivalent frameworks in addition be part of the transition to DT. As a result of this series, CPUFreq feature will not be available for non-DT boot systems.
As commented by Jon on internal thread, I am also against the idea of dropping non-DT support now. Till we migrate to 100 % DT, it is best to keep support alive. Especial OMAP3 based devices.
Quoted 6 lines
Why don't you take phased approach and have both supported for time being. Then once we move to DT only, we just drop the non-DT support as we plan to do for many more stuff.
BTW, we are using only CPUFreq driver before this series as well. I guess you mean the common CPUFReq drivers used by other ARM SOCs.
I had removed the entries for OPPs and clock nodes used by
omap-cpufreq.cand deleted theomap-cpufreq.cas well - so the statement "CPUFreq wont work in non-DT" configuration was accurate.
Quoted 10 lines
My intent was as follows:
- This series is driven mainly from maintenance angle - having to maintain two different drivers (legacyomap-cpufreq.candcpufreq-cpu0.c), ensuring the data is proper in both OPP tables in kernel and DT entries is sure to cause mayhem sometime. This is not just an pain for OMAP community, but for cpufreq community as well (since there is absolutely no reason other than OMAP legacy burden for making cpu0-cpufreq work in non-DT world).
- as long as non-DT supported boot provides all features, there is no real feature incentive to move to DT.
You are missing the point. Before you can migrate people over to DT, you need to be ready. IMO OMAP is still not quite ready unfortunately.
Quoted 7 lines
But, that said, there is one path I see possible:
- keep omap-cpufreq alive (BUT I will add a patch that will not let it init when in DT entries are present)
- add DT entries for all relevant OMAPs - in DT mode, we will *only* support cpufreq-cpu0
- All future SoCs will continue to use cpufreq-cpu0 using DT, as was the alignment I believe.
Yes that is what we are doing for other drivers and should be done here.
Jon
On 09:56-20130315, Jon Hunter wrote:
[..]
Quoted 9 lines
Quoted 7 lines
But, that said, there is one path I see possible:
- keep omap-cpufreq alive (BUT I will add a patch that will not let it init when in DT entries are present)
- add DT entries for all relevant OMAPs - in DT mode, we will *only* support cpufreq-cpu0
- All future SoCs will continue to use cpufreq-cpu0 using DT, as was the alignment I believe.Yes that is what we are doing for other drivers and should be done here.
OK. I guess we have not much of a choice with the legacy baggage we carry around :(. Will redo the series for the same.
Signature · 2 lines
Regards, Nishanth Menon