Skip to contentSkip to conversation

rtlwifi: usb: add missing freeing of skbuff

PATCH In review Jussi Kivilinna 2 participants 2 messages Mar 17, 2013 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtlwifi: usb: add missing freeing of skbuff

---
 drivers/net/wireless/rtlwifi/usb.c |    1 +
 1 file changed, 1 insertion(+)
drivers/net/wireless/rtlwifi/usb.c +1 -0
index b5c80b5..41dce83 100644
@@ -850,6 +850,7 @@ static void _rtl_usb_transmit(struct ieee80211_hw *hw, struct sk_buff *skb,
 	if (unlikely(!_urb)) {
 		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
 			 "Can't allocate urb. Drop skb!\n");
+		kfree_skb(skb);
 		return;
 	}
 	_rtl_submit_tx_urb(hw, _urb);
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Jussi Kivilinna
---
  drivers/net/wireless/rtlwifi/usb.c |    1 +
  1 file changed, 1 insertion(+)
drivers/net/wireless/rtlwifi/usb.c +0 -0
index b5c80b5..41dce83 100644

drivers/net/wireless/rtlwifi/usb.c static void _rtl_usb_transmit(struct ieee80211_hw *hw, struct sk_buff *skb, · line 856

Quoted 7 lines
drivers/net/wireless/rtlwifi/usb.c +1 -0
@@ -850,6 +850,7 @@ static void _rtl_usb_transmit(struct ieee80211_hw *hw, struct sk_buff *skb,
  	if (unlikely(!_urb)) {
  		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
  			 "Can't allocate urb. Drop skb!\n");
+		kfree_skb(skb);
  		return;
  	}
  	_rtl_submit_tx_urb(hw, _urb);

John - Add Stable as Cc.

Good catch. Thanks,

Larry