: PVH xen: Introduce PVH guest type
PATCH v2 6/18 : PVH xen: Introduce PVH guest type
This patch introduces the concept of pvh guest. There also other basic changes like creating macros to check for pvh vcpu/domain, and creating new macros to see if it's pvh/hvm domain/vcpu. Also, modify copy macros to test for pvh. Lastly, we introduce that PVH uses HVM style event delivery.
Chagnes in V2:
- make is_pvh/is_hvm enum instead of adding is_pvh as a new flag.
- fix indentation and spacing in guest_kernel_mode macro.
- add debug only BUG() in GUEST_KERNEL_RPL macro as it should no longer be called in any PVH paths.
--- xen/arch/x86/debug.c | 2 +- xen/arch/x86/domain.c | 7 +++++++ xen/common/domain.c | 2 +- xen/include/asm-x86/desc.h | 5 +++++ xen/include/asm-x86/domain.h | 9 ++++----- xen/include/asm-x86/event.h | 2 +- xen/include/asm-x86/guest_access.h | 12 ++++++------ xen/include/asm-x86/x86_64/regs.h | 9 +++++---- xen/include/xen/sched.h | 17 ++++++++++++++--- 9 files changed, 44 insertions(+), 21 deletions(-)
xen/arch/x86/debug.c +1 -1
@@ -158,7 +158,7 @@ dbg_rw_guest_mem(dbgva_t addr, dbgbyte_t *buf, int len, struct domain *dp, pagecnt =min_t (long,PAGE_SIZE - (addr & ~PAGE_MASK ), len); - mfn = (dp->is_hvm + mfn = (is_hvm_domain (dp) ?dbg_hvm_va2mfn (addr, dp, toaddr, &gfn) :dbg_pv_va2mfn (addr, dp, pgd3));if ( mfn ==INVALID_MFN )
xen/arch/x86/domain.c +7 -0
@@ -649,6 +649,13 @@ int arch_set_info_guest(unsigned int i;int rc =0 , compat; +/* This removed when all patches are checked in */ +if (is_pvh_vcpu (v) ) + { +printk ("PVH: You don't have the correct xen version for PVH\n" ); +return -EINVAL ; + } +/* The context is a compat-mode one if the target domain is compat-mode; * we expect the tools to DTRT even in compat-mode callers. */ compat =is_pv_32on64_domain (d);
xen/common/domain.c +1 -1
@@ -231,7 +231,7 @@ struct domain *domain_create( goto fail;if ( domcr_flags & DOMCRF_hvm ) - d->is_hvm =1 ; + d->guest_type = hvm_guest;if ( domid ==0 ) {
xen/include/asm-x86/desc.h +5 -0
@@ -38,7 +38,12 @@#ifndef __ASSEMBLY__ +#ifndef NDEBUG +#define GUEST_KERNEL_RPL (d) (is_pvh_domain(d) ? ({ BUG(); 0; }) : \ + is_pv_32bit_domain(d) ? 1 : 3) +#else #define GUEST_KERNEL_RPL (d) (is_pv_32bit_domain(d) ? 1 : 3) +#endif /* Fix up the RPL of a guest segment selector. */ #define __fixup_guest_selector (d, sel) \
xen/include/asm-x86/domain.h +4 -5
@@ -16,7 +16,7 @@#define is_pv_32on64_domain (d) (is_pv_32bit_domain(d))#define is_pv_32on64_vcpu (v) (is_pv_32on64_domain((v)->domain)) -#define is_hvm_pv_evtchn_domain (d) (is_hvm_domain(d) && \ +#define is_hvm_pv_evtchn_domain (d) (is_hvm_or_pvh_domain(d) && \ d->arch.hvm_domain.irq.callback_via_type == HVMIRQ_callback_vector)#define is_hvm_pv_evtchn_vcpu (v) (is_hvm_pv_evtchn_domain(v->domain))
@@ -254,10 +254,9 @@ struct arch_domainstruct list_head pdev_list; -union { -struct pv_domain pv_domain; -struct hvm_domain hvm_domain; - }; +/* PVH : pvh uses fields from both pv and hvm, so separate the union */ +struct pv_domain pv_domain; +struct hvm_domain hvm_domain;struct paging_domain paging;struct p2m_domain *p2m;
xen/include/asm-x86/event.h +1 -1
@@ -18,7 +18,7 @@ int hvm_local_events_need_delivery(struct vcpu *v);static inline int local_events_need_delivery (void ) {struct vcpu *v = current; -return (is_hvm_vcpu (v) ?hvm_local_events_need_delivery (v) : +return (is_hvm_or_pvh_vcpu (v) ?hvm_local_events_need_delivery (v) : (vcpu_info (v, evtchn_upcall_pending) && !vcpu_info (v, evtchn_upcall_mask))); }
xen/include/asm-x86/guest_access.h +6 -6
@@ -14,27 +14,27 @@/* Raw access functions: no type checking. */ #define raw_copy_to_guest (dst, src, len) \ - (is_hvm_vcpu(current) ? \ + (is_hvm_or_pvh_vcpu(current) ? \ copy_to_user_hvm((dst), (src), (len)) : \ copy_to_user((dst), (src), (len)))#define raw_copy_from_guest (dst, src, len) \ - (is_hvm_vcpu(current) ? \ + (is_hvm_or_pvh_vcpu(current) ? \ copy_from_user_hvm((dst), (src), (len)) : \ copy_from_user((dst), (src), (len)))#define raw_clear_guest (dst, len) \ - (is_hvm_vcpu(current) ? \ + (is_hvm_or_pvh_vcpu(current) ? \ clear_user_hvm((dst), (len)) : \ clear_user((dst), (len)))#define __raw_copy_to_guest (dst, src, len) \ - (is_hvm_vcpu(current) ? \ + (is_hvm_or_pvh_vcpu(current) ? \ copy_to_user_hvm((dst), (src), (len)) : \ __copy_to_user((dst), (src), (len)))#define __raw_copy_from_guest (dst, src, len) \ - (is_hvm_vcpu(current) ? \ + (is_hvm_or_pvh_vcpu(current) ? \ copy_from_user_hvm((dst), (src), (len)) : \ __copy_from_user((dst), (src), (len)))#define __raw_clear_guest (dst, len) \ - (is_hvm_vcpu(current) ? \ + (is_hvm_or_pvh_vcpu(current) ? \ clear_user_hvm((dst), (len)) : \ clear_user((dst), (len)))
xen/include/asm-x86/x86_64/regs.h +5 -4
@@ -10,10 +10,11 @@#define ring_2 (r) (((r)->cs & 3) == 2)#define ring_3 (r) (((r)->cs & 3) == 3) -#define guest_kernel_mode (v, r) \ - (!is_pv_32bit_vcpu(v) ? \ - (ring_3(r) && ((v)->arch.flags & TF_kernel_mode)) : \ - (ring_1(r))) +#define guest_kernel_mode (v, r) \ + (is_pvh_vcpu(v) ? ({ ASSERT(v == current); ring_0(r); }) : \ + (!is_pv_32bit_vcpu(v) ? \ + (ring_3(r) && ((v)->arch.flags & TF_kernel_mode)) : \ + (ring_1(r))))#define permit_softint (dpl, v, r) \ ((dpl) >= (guest_kernel_mode(v, r) ? 1 : 3))
xen/include/xen/sched.h +14 -3
@@ -230,6 +230,9 @@ struct mem_event_per_domainstruct mem_event_domain access; }; +/* PVH is a PV guest running in HVM container. While is_hvm is false for it, +* it uses many of the HVM data structs. +*/ struct domain {domid_t domain_id;
@@ -277,8 +280,8 @@ struct domainstruct rangeset *iomem_caps;struct rangeset *irq_caps; -/* Is this an HVM guest? */ -bool_t is_hvm; +/* !is_pvh && !is_hvm ==> PV, else PVH or HVM */ +enum {hvm_guest=1 , pvh_guest} guest_type;#ifdef HAS_PASSTHROUGH /* Does this guest need iommu mappings? */ bool_t need_iommu;
@@ -450,6 +453,10 @@ struct domain *domain_create(/* DOMCRF_oos_off: dont use out-of-sync optimization for shadow page tables */ #define _DOMCRF_oos_off 4#define DOMCRF_oos_off (1U<<_DOMCRF_oos_off) +/* DOMCRF_pvh: Create PV domain in HVM container */ +#define _DOMCRF_pvh 5 +#define DOMCRF_pvh (1U<<_DOMCRF_pvh) +/* * rcu_lock_domain_by_id() is more efficient than get_domain_by_id().
@@ -718,10 +725,14 @@ void watchdog_domain_destroy(struct domain *d);#define VM_ASSIST (_d,_t) (test_bit((_t), &(_d)->vm_assist)) -#define is_hvm_domain (d) ((d)->is_hvm) +#define is_hvm_domain (d) ((d)->guest_type == hvm_guest)#define is_hvm_vcpu (v) (is_hvm_domain(v->domain)) +#define is_pvh_domain (d) ((d)->guest_type == pvh_guest) +#define is_pvh_vcpu (v) (is_pvh_domain(v->domain))#define is_pinned_vcpu (v) ((v)->domain->is_pinned || \ cpumask_weight((v)->cpu_affinity) == 1) +#define is_hvm_or_pvh_domain (d) (is_hvm_domain(d) || is_pvh_domain(d)) +#define is_hvm_or_pvh_vcpu (v) (is_hvm_or_pvh_domain(v->domain))#ifdef HAS_PASSTHROUGH #define need_iommu (d) ((d)->need_iommu)#else
Signature · 1 line
1.7.2.3
xen/include/xen/sched.h struct domain · line 284
Quoted 9 lines
Quoted 1 line
Quoted 1 line · Mukesh Rathor
xen/include/xen/sched.h +2
-2@@ -277,8 +280,8 @@ struct domainstruct rangeset *iomem_caps;struct rangeset *irq_caps; -/* Is this an HVM guest? */ -bool_t is_hvm; +/* !is_pvh && !is_hvm ==> PV, else PVH or HVM */ +enum {hvm_guest=1 , pvh_guest} guest_type;
Even if not used explicitly anywhere right now, please make the PV guest case explicit here too (at once avoiding the =1).
Quite likely we'll want to also have the enum have a tag, so we can eventually pass value from this enumeration to functions.
I'm also mildly puzzled by you using "_guest" suffixes here rather than, as usual, a common prefix.
And of course, please properly format this.
xen/include/xen/sched.h void watchdog_domain_destroy(struct domain *d); · line 735
Quoted 13 lines
xen/include/xen/sched.h +5
-1@@ -718,10 +725,14 @@ void watchdog_domain_destroy(struct domain *d);#define VM_ASSIST (_d,_t) (test_bit((_t), &(_d)->vm_assist)) -#define is_hvm_domain (d) ((d)->is_hvm) +#define is_hvm_domain (d) ((d)->guest_type == hvm_guest)#define is_hvm_vcpu (v) (is_hvm_domain(v->domain)) +#define is_pvh_domain (d) ((d)->guest_type == pvh_guest) +#define is_pvh_vcpu (v) (is_pvh_domain(v->domain))#define is_pinned_vcpu (v) ((v)->domain->is_pinned || \ cpumask_weight((v)->cpu_affinity) == 1) +#define is_hvm_or_pvh_domain (d) (is_hvm_domain(d) || is_pvh_domain(d)) +#define is_hvm_or_pvh_vcpu (v) (is_hvm_or_pvh_domain(v->domain))
These surely can have better names, if they're needed at all:
Wouldn't !is_pv_domain() do what you need?
Jan
Quoted 6 lines · On Mon, 18 Mar 2013 11:54:29 +0000 "Jan Beulich" <[email protected]> wrote:
Quoted 6 lines
Quoted 2 lines
Quoted 2 lines
On 16.03.13 at 01:32, Mukesh Rathor <[email protected]> wrote:
xen/include/xen/sched.h +0
-0@@ -277,8 +280,8 @@ struct domainstruct rangeset *iomem_caps;struct rangeset *irq_caps;
Quoted 7 lines
xen/include/xen/sched.h struct domain · line 284
Quoted 4 lines
xen/include/xen/sched.h +2
-2-/* Is this an HVM guest? */ -bool_t is_hvm; +/* !is_pvh && !is_hvm ==> PV, else PVH or HVM */ +enum {hvm_guest=1 , pvh_guest} guest_type;Even if not used explicitly anywhere right now, please make the PV guest case explicit here too (at once avoiding the =1).
Ok.
Quoted 2 lines
Quite likely we'll want to also have the enum have a tag, so we can eventually pass value from this enumeration to functions.
Ok.
Quoted 4 lines
I'm also mildly puzzled by you using "
_guest" suffixes here rather than, as usual, a common prefix.And of course, please properly format this.
Not sure I follow what needs formatting?
Quoted 4 lines
Quoted 4 lines
xen/include/xen/sched.h +0
-0@@ -718,10 +725,14 @@ void watchdog_domain_destroy(struct domain *d);#define VM_ASSIST (_d,_t) (test_bit((_t), &(_d)->vm_assist))
Quoted 13 lines
xen/include/xen/sched.h void watchdog_domain_destroy(struct domain *d);
Quoted 10 lines
xen/include/xen/sched.h +4
-1-#define is_hvm_domain (d) ((d)->is_hvm) +#define is_hvm_domain (d) ((d)->guest_type == hvm_guest)#define is_hvm_vcpu (v) (is_hvm_domain(v->domain)) +#define is_pvh_domain (d) ((d)->guest_type == pvh_guest) +#define is_pvh_vcpu (v) (is_pvh_domain(v->domain))#define is_pinned_vcpu (v) ((v)->domain->is_pinned || \ cpumask_weight((v)->cpu_affinity) == 1) +#define is_hvm_or_pvh_domain (d) (is_hvm_domain(d) || is_pvh_domain(d)) +#define is_hvm_or_pvh_vcpu(v) (is_hvm_or_pvh_domain (v->domain))These surely can have better names, if they're needed at all:
Wouldn't !is_pv_domain() do what you need?
Nop, that's more confusing, since PVH is a PV domain. So, I suggest we leave it as is. is_hvm_or_pvh_domain is nicely readable, what name do you suggest?
Thanks,
Mukesh
Quoted 10 lines
Quoted 1 line
Quoted 1 line · Mukesh Rathor
Quoted 6 lines · On Mon, 18 Mar 2013 11:54:29 +0000 "Jan Beulich" <[email protected]> wrote:
Quoted 6 lines
Quoted 2 lines
Quoted 2 lines
On 16.03.13 at 01:32, Mukesh Rathor <[email protected]> wrote:
xen/include/xen/sched.h +0
-0@@ -277,8 +280,8 @@ struct domainstruct rangeset *iomem_caps;struct rangeset *irq_caps;
Quoted 8 lines
Quoted 6 lines
xen/include/xen/sched.h struct domain · line 284
Quoted 4 lines
xen/include/xen/sched.h +2
-2-/* Is this an HVM guest? */ -bool_t is_hvm; +/* !is_pvh && !is_hvm ==> PV, else PVH or HVM */ +enum {hvm_guest=1 , pvh_guest} guest_type;And of course, please properly format this.
Not sure I follow what needs formatting?
A number of blanks need to be inserted. And the whole enum declaration probably doesn't belong on a single line anyway.
And as pointed out elsewhere - your whole series is in need of making it conform to coding conventions.
Quoted 18 lines
Quoted 4 lines
Quoted 4 lines
xen/include/xen/sched.h +0
-0@@ -718,10 +725,14 @@ void watchdog_domain_destroy(struct domain *d);#define VM_ASSIST (_d,_t) (test_bit((_t), &(_d)->vm_assist))Quoted 13 lines
xen/include/xen/sched.h void watchdog_domain_destroy(struct domain *d);
Quoted 10 lines
xen/include/xen/sched.h +4
-1-#define is_hvm_domain (d) ((d)->is_hvm) +#define is_hvm_domain (d) ((d)->guest_type == hvm_guest)#define is_hvm_vcpu (v) (is_hvm_domain(v->domain)) +#define is_pvh_domain (d) ((d)->guest_type == pvh_guest) +#define is_pvh_vcpu (v) (is_pvh_domain(v->domain))#define is_pinned_vcpu (v) ((v)->domain->is_pinned || \ cpumask_weight((v)->cpu_affinity) == 1) +#define is_hvm_or_pvh_domain (d) (is_hvm_domain(d) || is_pvh_domain(d)) +#define is_hvm_or_pvh_vcpu(v) (is_hvm_or_pvh_domain (v->domain))These surely can have better names, if they're needed at all:
Wouldn't !is_pv_domain() do what you need?
Quoted 3 lines
Nop, that's more confusing, since PVH is a PV domain. So, I suggest we leave it as is.
is_hvm_or_pvh_domainis nicely readable, what name do you suggest?
No. The three kinds should be fully distinct, such that when meaning one you can use is_xyz_domain() and when meaning two, you can use !is_abc_domain().
is_hvm_or_pvh_domain() isn't nicely readable to me, in particular because this kind of naming doesn't scale. And it's certainly more typing than !is_pv_domain().
Jan
Quoted 17 lines · Jan Beulich
Quoted 17 lines
Quoted 1 line
Quoted 1 line · Mukesh Rathor
Quoted 12 lines · On Mon, 18 Mar 2013 11:54:29 +0000 "Jan Beulich" <[email protected]> wrote:
xen/include/xen/sched.h struct domain · line 284
Quoted 10 lines
Quoted 2 lines
Quoted 2 lines
On 16.03.13 at 01:32, Mukesh Rathor <[email protected]> wrote:
xen/include/xen/sched.h +2
-2@@ -277,8 +280,8 @@ struct domainstruct rangeset *iomem_caps;struct rangeset *irq_caps; -/* Is this an HVM guest? */ -bool_t is_hvm; +/* !is_pvh && !is_hvm ==> PV, else PVH or HVM */ +enum {hvm_guest=1 , pvh_guest} guest_type;And of course, please properly format this.
Quoted 4 lines
Quoted 1 line
Not sure I follow what needs formatting?
A number of blanks need to be inserted. And the whole enum declaration probably doesn't belong on a single line anyway.
The single line looks to be already there:
enum { DOMDYING_alive, DOMDYING_dying, DOMDYING_dead } is_dying;
So I think Mukesh is just following the same convention in that file. Should he depart from it?
Quoted 24 lines
Quoted 1 line
Quoted 1 line · Konrad Rzeszutek Wilk
Quoted 17 lines · Jan Beulich
Quoted 17 lines
Quoted 1 line
Quoted 1 line · Mukesh Rathor
Quoted 12 lines · On Mon, 18 Mar 2013 11:54:29 +0000 "Jan Beulich" <[email protected]> wrote:
xen/include/xen/sched.h struct domain · line 284
Quoted 10 lines
Quoted 2 lines
Quoted 2 lines
On 16.03.13 at 01:32, Mukesh Rathor <[email protected]> wrote:
xen/include/xen/sched.h +2
-2@@ -277,8 +280,8 @@ struct domainstruct rangeset *iomem_caps;struct rangeset *irq_caps; -/* Is this an HVM guest? */ -bool_t is_hvm; +/* !is_pvh && !is_hvm ==> PV, else PVH or HVM */ +enum {hvm_guest=1 , pvh_guest} guest_type;And of course, please properly format this.
Quoted 4 lines
Quoted 1 line
Not sure I follow what needs formatting?
A number of blanks need to be inserted. And the whole enum declaration probably doesn't belong on a single line anyway.
Quoted 6 lines
The single line looks to be already there:
enum {
DOMDYING_alive,DOMDYING_dying,DOMDYING_dead}is_dying;So I think Mukesh is just following the same convention in that file. Should he depart from it?
Not necessarily, provided the line isn't getting overly long.
Jan
Quoted 7 lines · On Tue, 19 Mar 2013 08:48:53 +0000 "Jan Beulich" <[email protected]> wrote:
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
On 19.03.13 at 01:21, Mukesh Rathor <[email protected]> wrote:
On Mon, 18 Mar 2013 11:54:29 +0000
"Jan Beulich" <[email protected]> wrote:And as pointed out elsewhere - your whole series is in need of making it conform to coding conventions.
For the most part I looked at existing code in the same or different module for coding conventions.
Quoted 20 lines
Quoted 16 lines
Quoted 15 lines
Quoted 9 lines
#define
VM_ASSIST(_d,_t)(test_bit((_t), &(_d)->vm_assist))xen/include/xen/sched.h +3
-1-#define is_hvm_domain (d) ((d)->is_hvm) +#define is_hvm_domain (d) ((d)->guest_type == hvm_guest)#define is_hvm_vcpu (v) (is_hvm_domain(v->domain)) +#define is_pvh_domain (d) ((d)->guest_type == pvh_guest) +#define is_pvh_vcpu (v) (is_pvh_domain(v->domain))#define is_pinned_vcpu (v) ((v)->domain->is_pinned || \ cpumask_weight((v)->cpu_affinity) ==Quoted 3 lines
1) +#define
is_hvm_or_pvh_domain(d)(is_hvm_domain(d)||is_pvh_domain(d)) +#defineis_hvm_or_pvh_vcpu(v)(is_hvm_or_pvh_domain(v->domain))These surely can have better names, if they're needed at all:
Wouldn't !is_pv_domain() do what you need?Quoted 3 lines
Nop, that's more confusing, since PVH is a PV domain. So, I suggest we leave it as is.
is_hvm_or_pvh_domainis nicely readable, what name do you suggest?
Quoted 7 lines
No. The three kinds should be fully distinct, such that when meaning one you can use
is_xyz_domain()and when meaning two, you can use !is_abc_domain().
is_hvm_or_pvh_domain()isn't nicely readable to me, in particular because this kind of naming doesn't scale. And it's certainly more typing than !is_pv_domain().
Since, pvh is a pv domain, I don't like using pv_guest for non PVH PV. But perhaps I could use the name pv_mmu and have something like following:
enum guest_type { is_mmu_pv, is_pvh_pv, is_hvm } guest_type;
Then: is_hvm_or_pvh_domain() becomes: !is_mmu_pv().
Alternative to is_mmu_pv: is_pure_pv, is_orig_pv, ....
Let me know what you think.
thanks,
m-
Quoted 6 lines
Quoted 1 line
Quoted 1 line · Mukesh Rathor
Quoted 2 lines · On Tue, 19 Mar 2013 08:48:53 +0000 "Jan Beulich" <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
On 19.03.13 at 01:21, Mukesh Rathor <[email protected]> wrote:
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
On Mon, 18 Mar 2013 11:54:29 +0000
"Jan Beulich" <[email protected]> wrote:And as pointed out elsewhere - your whole series is in need of making it conform to coding conventions.
For the most part I looked at existing code in the same or different module for coding conventions.
Which is the right approach, except that you should ignore bad examples (namely "real" Xen sources not conforming to the conventions, where "real" means not cloned from another source, which most frequently would have been Linux).
Quoted 32 lines
Quoted 20 lines
Quoted 16 lines
Quoted 15 lines
Quoted 9 lines
#define
VM_ASSIST(_d,_t)(test_bit((_t), &(_d)->vm_assist))xen/include/xen/sched.h +3
-1-#define is_hvm_domain (d) ((d)->is_hvm) +#define is_hvm_domain (d) ((d)->guest_type == hvm_guest)#define is_hvm_vcpu (v) (is_hvm_domain(v->domain)) +#define is_pvh_domain (d) ((d)->guest_type == pvh_guest) +#define is_pvh_vcpu (v) (is_pvh_domain(v->domain))#define is_pinned_vcpu (v) ((v)->domain->is_pinned || \ cpumask_weight((v)->cpu_affinity) ==Quoted 3 lines
1) +#define
is_hvm_or_pvh_domain(d)(is_hvm_domain(d)||is_pvh_domain(d)) +#defineis_hvm_or_pvh_vcpu(v)(is_hvm_or_pvh_domain(v->domain))These surely can have better names, if they're needed at all:
Wouldn't !is_pv_domain() do what you need?Quoted 3 lines
Nop, that's more confusing, since PVH is a PV domain. So, I suggest we leave it as is.
is_hvm_or_pvh_domainis nicely readable, what name do you suggest?Quoted 7 lines
No. The three kinds should be fully distinct, such that when meaning one you can use
is_xyz_domain()and when meaning two, you can use !is_abc_domain().
is_hvm_or_pvh_domain()isn't nicely readable to me, in particular because this kind of naming doesn't scale. And it's certainly more typing than !is_pv_domain().Since, pvh is a pv domain, I don't like using
pv_guestfor non PVH PV. But perhaps I could use the namepv_mmuand have something like following:
Quoted 5 lines
enum
guest_type{is_mmu_pv,is_pvh_pv,is_hvm}guest_type;Then:
is_hvm_or_pvh_domain()becomes: !is_mmu_pv().Alternative to
is_mmu_pv:is_pure_pv,is_orig_pv, ....
These are all ugly, and I don't see why the triplet I suggested (is_pv, is_pvh, and is_hvm), including their intended use, wouldn't be acceptable.
Jan
Quoted 22 lines · On Mon, 25 Mar 2013 09:26:51 +0000 "Jan Beulich" <[email protected]> wrote:
Quoted 22 lines
Quoted 2 lines
Quoted 2 lines
On 23.03.13 at 02:13, Mukesh Rathor <[email protected]> wrote:
Quoted 10 lines · On Tue, 19 Mar 2013 08:48:53 +0000 "Jan Beulich" <[email protected]> wrote:
Quoted 2 lines
suggest we leave it as is.
is_hvm_or_pvh_domainis nicely readable, what name do you suggest?No. The three kinds should be fully distinct, such that when meaning one you can use
is_xyz_domain()and when meaning two, you can use !is_abc_domain().
is_hvm_or_pvh_domain()isn't nicely readable to me, in particular because this kind of naming doesn't scale. And it's certainly more typing than !is_pv_domain().Since, pvh is a pv domain, I don't like using
pv_guestfor non PVH PV. But perhaps I could use the namepv_mmuand have something like following:enum
guest_type{is_mmu_pv,is_pvh_pv,is_hvm}guest_type;
Quoted 7 lines
Quoted 3 lines
Then:
is_hvm_or_pvh_domain()becomes: !is_mmu_pv().Alternative to
is_mmu_pv:is_pure_pv,is_orig_pv, ....These are all ugly, and I don't see why the triplet I suggested (
is_pv,is_pvh, andis_hvm), including their intended use, wouldn't be acceptable.
Because this implies pvh is a new type, whereas like I said before, PVH is a PV guest. Ok, lets go with your suggestion above, and if people find it confusing, we can change in future.
Thanks,
Mukesh
Quoted 7 lines · Mukesh Rathor
Quoted 3 lines
These are all ugly, and I don't see why the triplet I suggested (
is_pv,is_pvh, andis_hvm), including their intended use, wouldn't be acceptable.Because this implies pvh is a new type, whereas like I said before, PVH is a PV guest. Ok, lets go with your suggestion above, and if people find it confusing, we can change in future.
It's not really PV -- the interfaces and execution environment are somewhat different, evidence being that a legacy PV guest will not boot in PVH mode! There are certainly similarities, but then there are between HVM and PV too (e.g., many hypercalls), so at the end of the day a guest is one of PV/PVH/HVM. So I have to agree with Jan.
-- Keir
Quoted 10 lines · On Mon, 25 Mar 2013 20:07:10 +0000 Keir Fraser <[email protected]> wrote:
Quoted 7 lines · Mukesh Rathor
Quoted 3 lines
These are all ugly, and I don't see why the triplet I suggested (
is_pv,is_pvh, andis_hvm), including their intended use, wouldn't be acceptable.Because this implies pvh is a new type, whereas like I said before, PVH is a PV guest. Ok, lets go with your suggestion above, and if people find it confusing, we can change in future.
Quoted 5 lines
It's not really PV -- the interfaces and execution environment are somewhat different, evidence being that a legacy PV guest will not boot in PVH mode! There are certainly similarities, but then there are between HVM and PV too (e.g., many hypercalls), so at the end of the day a guest is one of PV/PVH/HVM. So I have to agree with Jan.
LOL... which is why originally I had called it hybrid (neither PV nor HVM), but then many here convinced me it should be called a PV something because it was a PV. Anyways, no more on this.
{ is_pv, is_pvh, is_hvm }it is.
Thanks,
Mukesh