Skip to contentSkip to conversation

clk: mxs: Fix sparse warnings

PATCH In review Fabio Estevam 3 participants 3 messages Feb 11, 2013 – Mar 19, 2013

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 clk: mxs: Fix sparse warnings

From: Fabio Estevam <[email protected]>

Fix the following sparse warnings:

drivers/clk/mxs/clk.c:17:1: warning: symbol 'mxs_lock' was not declared. Should it be static? drivers/clk/mxs/clk.c:19:5: warning: symbol 'mxs_clk_wait' was not declared. Should it be static?

---
 drivers/clk/mxs/clk.c |    1 +
 1 file changed, 1 insertion(+)
drivers/clk/mxs/clk.c +1 -0
index b24d560..5301bce 100644
@@ -13,6 +13,7 @@
 #include <linux/io.h>
 #include <linux/jiffies.h>
 #include <linux/spinlock.h>
+#include "clk.h"
 
 DEFINE_SPINLOCK(mxs_lock);
 
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Fix the following sparse warnings:

drivers/clk/mxs/clk.c:17:1: warning: symbol 'mxs_lock' was not declared. Should it be static? drivers/clk/mxs/clk.c:19:5: warning: symbol 'mxs_clk_wait' was not declared. Should it be static?

Quoted 19 lines
---
 drivers/clk/mxs/clk.c |    1 +
 1 file changed, 1 insertion(+)
drivers/clk/mxs/clk.c +1 -0
index b24d560..5301bce 100644
@@ -13,6 +13,7 @@
 #include <linux/io.h>
 #include <linux/jiffies.h>
 #include <linux/spinlock.h>
+#include "clk.h"
 
 DEFINE_SPINLOCK(mxs_lock);
 
Signature · 1 line
1.7.9.5
#2 lore raw

Quoting Shawn Guo (2013-02-17 00:02:20)

Quoted 12 lines · Fabio Estevam
Quoted 8 lines

From: Fabio Estevam <[email protected]>

Fix the following sparse warnings:

drivers/clk/mxs/clk.c:17:1: warning: symbol 'mxs_lock' was not declared. Should it be static? drivers/clk/mxs/clk.c:19:5: warning: symbol 'mxs_clk_wait' was not declared. Should it be static?

Taken into clk-next.

Thanks,
Mike

Quoted 19 lines
Quoted 19 lines
---
 drivers/clk/mxs/clk.c |    1 +
 1 file changed, 1 insertion(+)
drivers/clk/mxs/clk.c +1 -0
index b24d560..5301bce 100644
@@ -13,6 +13,7 @@
 #include <linux/io.h>
 #include <linux/jiffies.h>
 #include <linux/spinlock.h>
+#include "clk.h"
 
 DEFINE_SPINLOCK(mxs_lock);
 
Signature · 1 line
1.7.9.5