Skip to contentSkip to conversation

net/irda: add missing error path release_sock call

PATCH Applied Kees Cook 2 participants 2 messages Mar 20, 2013

Subsystems (2)
lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 net/irda: add missing error path release_sock call

This makes sure that release_sock is called for all error conditions in irda_getsockopt.

---
 net/irda/af_irda.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
net/irda/af_irda.c +4 -2
index d07e3a6..d28e7f0 100644
@@ -2583,8 +2583,10 @@ bed:
 				    NULL, NULL, NULL);
 
 		/* Check if the we got some results */
-		if (!self->cachedaddr)
-			return -EAGAIN;		/* Didn't find any devices */
+		if (!self->cachedaddr) {
+			err = -EAGAIN;		/* Didn't find any devices */
+			goto out;
+		}
 		daddr = self->cachedaddr;
 		/* Cleanup */
 		self->cachedaddr = 0;
Signature · 6 lines
1.7.9.5


-- 
Kees Cook
Chrome OS Security