net/irda: add missing error path release_sock call
Subsystems (2)
PATCH 1/1 net/irda: add missing error path release_sock call
This makes sure that release_sock is called for all error conditions in irda_getsockopt.
Signed-off-by Kees Cook <[email protected]>
Reported-by Brad Spengler <[email protected]>
--- net/irda/af_irda.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
net/irda/af_irda.c +4 -2
@@ -2583,8 +2583,10 @@ bed: NULL, NULL, NULL);/* Check if the we got some results */ -if (!self->cachedaddr) -return -EAGAIN ;/* Didn't find any devices */ +if (!self->cachedaddr) { + err = -EAGAIN ;/* Didn't find any devices */ + goto out; + } daddr = self->cachedaddr;/* Cleanup */ self->cachedaddr =0 ;
Signature · 6 lines
1.7.9.5 -- Kees Cook Chrome OS Security
From: Kees Cook <[email protected]>
Date: Wed, 20 Mar 2013 08:19:24 -0700
Quoted 5 lines
This makes sure that
release_sockis called for all error conditions inirda_getsockopt.Signed-off-by Kees Cook <[email protected]>Reported-by Brad Spengler <[email protected]>
Applied, thanks.