fec: Fix the build as module
Subsystems (3)
PATCH 1/1 fec: Fix the build as module
From: Fabio Estevam <[email protected]>
Since commit ff43da86c69 (NET: FEC: dynamtic check DMA desc buff type) the following build error happens when CONFIG_FEC=m
ERROR: "fec_ptp_init" [drivers/net/ethernet/freescale/fec.ko] undefined!
ERROR: "fec_ptp_ioctl" [drivers/net/ethernet/freescale/fec.ko] undefined!
ERROR: "fec_ptp_start_cyclecounter" [drivers/net/ethernet/freescale/fec.ko] undefined!
Fix it by exporting the required fec_ptp symbols.
--- drivers/net/ethernet/freescale/fec_ptp.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/ethernet/freescale/fec_ptp.c +3 -0
@@ -128,6 +128,7 @@ void fec_ptp_start_cyclecounter(struct net_device *ndev)spin_unlock_irqrestore (&fep->tmreg_lock, flags); } +EXPORT_SYMBOL (fec_ptp_start_cyclecounter);/** * fec_ptp_adjfreq - adjust ptp cycle frequency
@@ -318,6 +319,7 @@ int fec_ptp_ioctl(struct net_device *ndev, struct ifreq *ifr, int cmd)return copy_to_user (ifr->ifr_data, &config,sizeof (config)) ? -EFAULT :0 ; } +EXPORT_SYMBOL (fec_ptp_ioctl);/** * fec_time_keep - call timecounter_read every second to avoid timer overrun
@@ -383,3 +385,4 @@ void fec_ptp_init(struct net_device *ndev, struct platform_device *pdev)pr_info ("registered PHC device on %s\n" , ndev->name); } } +EXPORT_SYMBOL (fec_ptp_init);
Signature · 1 line
1.7.9.5
David Miller
maintainerFrom: Fabio Estevam <[email protected]>
Date: Wed, 20 Mar 2013 15:19:32 -0300
Quoted 5 lines
From: Fabio Estevam <[email protected]>
Since commit
ff43da86c69(NET: FEC: dynamtic check DMA desc buff type) the following build error happens whenCONFIG_FEC=m
Quoted 8 lines
ERROR: "
fec_ptp_init" [drivers/net/ethernet/freescale/fec.ko] undefined!
ERROR: "fec_ptp_ioctl" [drivers/net/ethernet/freescale/fec.ko] undefined!
ERROR: "fec_ptp_start_cyclecounter" [drivers/net/ethernet/freescale/fec.ko] undefined!Fix it by exporting the required
fec_ptpsymbols.Reported-by Uwe Kleine-Koenig <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Applied and queued up for -stable.
Hello,
Quoted 10 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Since commit
ff43da86c69(NET: FEC: dynamtic check DMA desc buff type) the following build error happens whenCONFIG_FEC=mERROR: "
fec_ptp_init" [drivers/net/ethernet/freescale/fec.ko] undefined!
ERROR: "fec_ptp_ioctl" [drivers/net/ethernet/freescale/fec.ko] undefined!
ERROR: "fec_ptp_start_cyclecounter" [drivers/net/ethernet/freescale/fec.ko] undefined!Fix it by exporting the required
fec_ptpsymbols.
IMHO this is not sensible. There is no need to make the fec driver 2 modules. Just loading one is impossible (fec.ko) or useless (fec_ptp.ko). That's why I suggested to make them a single module.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
Quoted 8 lines · Uwe Kleine-König
Hello,
Quoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Since commit
ff43da86c69(NET: FEC: dynamtic check DMA desc buff type) the following build error happens whenCONFIG_FEC=m
Quoted 8 lines
Quoted 5 lines
ERROR: "
fec_ptp_init" [drivers/net/ethernet/freescale/fec.ko] undefined!
ERROR: "fec_ptp_ioctl" [drivers/net/ethernet/freescale/fec.ko] undefined!
ERROR: "fec_ptp_start_cyclecounter" [drivers/net/ethernet/freescale/fec.ko] undefined!Fix it by exporting the required
fec_ptpsymbols.IMHO this is not sensible. There is no need to make the fec driver 2 modules. Just loading one is impossible (fec.ko) or useless (fec_ptp.ko). That's why I suggested to make them a single module.
Ok, I wil do as you suggested on a subsequent patch.
Regards,
Fabio Estevam