Linux 3.4.37
Greg KH
maintainerI'm announcing the release of the 3.4.37 kernel.
All users of the 3.4 kernel series must upgrade.
The updated 3.4.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-3.4.y
and can be browsed at the normal kernel.org git web browser:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary
thanks,
greg k-h
------------
Makefile | 2 arch/powerpc/kernel/cputable.c | 2 arch/powerpc/mm/hash_utils_64.c | 2 arch/s390/include/asm/tlbflush.h | 2 arch/s390/kernel/entry.S | 3 arch/s390/kernel/entry64.S | 5 arch/x86/kernel/cpu/perf_event_intel_ds.c | 10 arch/x86/power/cpu.c | 2 drivers/block/loop.c | 24 +- drivers/char/hw_random/virtio-rng.c | 13 + drivers/gpu/drm/i915/i915_gem.c | 5 drivers/gpu/drm/i915/intel_display.c | 2 drivers/hwmon/lineage-pem.c | 2 drivers/hwmon/pmbus/ltc2978.c | 14 - drivers/hwmon/sht15.c | 2 drivers/net/macvlan.c | 1 drivers/net/tun.c | 2 drivers/staging/vt6656/main_usb.c | 4 drivers/tty/pty.c | 1 drivers/tty/serial/8250/8250_pci.c | 4 drivers/tty/serial/Kconfig | 2 drivers/usb/class/cdc-wdm.c | 23 +- drivers/usb/host/ehci-q.c | 18 + drivers/usb/serial/cp210x.c | 20 + drivers/usb/serial/option.c | 5 drivers/usb/serial/qcaux.c | 1 drivers/usb/storage/initializers.c | 76 ------ drivers/usb/storage/initializers.h | 4 drivers/usb/storage/unusual_devs.h | 329 +++++++++++++++++++++++++++++- drivers/video/atmel_lcdfb.c | 22 +- drivers/w1/w1.c | 3 drivers/xen/xen-pciback/pciback_ops.c | 3 fs/block_dev.c | 4 fs/btrfs/volumes.c | 6 fs/ext3/super.c | 4 include/linux/perf_event.h | 6 include/video/atmel_lcdc.h | 1 kernel/signal.c | 3 net/core/dev.c | 1 net/core/rtnetlink.c | 1 net/dcb/dcbnl.c | 7 net/ieee802154/6lowpan.h | 2 net/ipv4/tcp_input.c | 6 net/ipv6/ip6_input.c | 3 net/ipv6/route.c | 3 net/l2tp/l2tp_ppp.c | 1 net/netlabel/netlabel_unlabeled.c | 27 +- net/rds/message.c | 3 security/selinux/xfrm.c | 2 sound/core/seq/seq_timer.c | 8 50 files changed, 540 insertions(+), 156 deletions(-)
Alan Stern (1):
USB: EHCI: don't check DMA values in QH overlays
Amit Shah (1):
virtio: rng: disallow multiple device registrations, fixes crashes
Axel Lin (1):
hwmon: (lineage-pem) Add missing terminating entry for pem_[input|fan]_attributes
Ben Hutchings (1):
hwmon: (sht15) Fix memory leak if regulator_enable() fails
Benjamin Herrenschmidt (2):
powerpc: Fix STAB initialization
powerpc: Fix cputable entry for 970MP rev 1.0
Bjørn Mork (2):
USB: option: add Huawei E5331
USB: storage: fix Huawei mode switching regression
Christian Schmiedl (1):
USB: added support for Cinterion's products AH6 and PLS8
Cong Wang (1):
rds: limit the size allocated by rds_message_alloc()
Cristian Bercaru (1):
bridging: fix rx_handlers return code
Dan Carpenter (1):
selinux: use GFP_ATOMIC under spin_lock
Dan Williams (1):
qcaux: add Franklin U600
David Rientjes (1):
perf,x86: fix link failure for non-Intel configs
Dmitry Rogozhkin (1):
drm/i915: EBUSY status handling added to i915_gem_fault().
Eric Dumazet (1):
tun: add a missing nf_reset() in tun_net_xmit()
Eric Sandeen (1):
btrfs: use rcu_barrier() to wait for bdev puts at unmount
Greg Kroah-Hartman (1):
Linux 3.4.37
Guenter Roeck (1):
hwmon: (pmbus/ltc2978) Fix temperature reporting
Guillaume Nault (1):
l2tp: Restore socket refcount when sendmsg succeeds
Guo Chao (3):
block: use i_size_write() in bd_set_size()
loopdev: fix a deadlock
loopdev: remove an user triggerable oops
Hannes Frederic Sowa (1):
ipv6: stop multicast forwarding to process interface scoped addresses
Heiko Carstens (1):
s390/mm: fix flush_tlb_kernel_range()
Jiri Slaby (1):
TTY: do not reset master's packet mode
Johan Hovold (1):
atmel_lcdfb: fix 16-bpp modes on older SOCs
Kees Cook (1):
signal: always clear sa_restorer on execve
Konrad Rzeszutek Wilk (1):
xen/pciback: Don't disable a PCI device that is already disabled.
Lars-Peter Clausen (1):
ext3: Fix format string issues
Linus Torvalds (1):
perf,x86: fix wrmsr_on_cpu() warning on suspend/resume
Lorenzo Colitti (1):
net: ipv6: Don't purge default router if accept_ra=2
Malcolm Priestley (1):
staging: vt6656: Fix oops on resume from suspend.
Marcin Jurkowski (1):
w1: fix oops when w1_search is called from netlink connector
Martin Schwidefsky (1):
s390: critical section cleanup vs. machine checks
Mathias Krause (2):
rtnl: fix info leak on RTM_GETLINK request for VF devices
dcbnl: fix various netlink info leaks
Matwey V. Kornilov (1):
usb: cp210x new Vendor/Device IDs
Neal Cardwell (1):
tcp: fix double-counted receiver RTT when leaving receiver fast path
Oliver Neukum (1):
USB: cdc-wdm: fix buffer overflow
Paul Bolle (1):
tty: serial: fix typo "ARCH_S5P6450"
Paul Moore (1):
netlabel: correctly list all the static label mappings
Stephane Eranian (1):
perf,x86: fix kernel crash with PEBS/BTS after suspend/resume
Steve Conklin (1):
usb: serial: Add Rigblaster Advantage to device table
Stéphane Marchesin (1):
drm/i915: Increase the RC6p threshold.
Takashi Iwai (1):
ALSA: seq: Fix missing error handling in snd_seq_timer_open()
Vlad Yasevich (1):
macvlan: Set IFF_UNICAST_FLT flag to prevent unnecessary promisc mode.
Wang YanQing (1):
serial: 8250_pci: add support for another kind of NetMos Technology PCI 9835 Multi-I/O Controller
YOSHIFUJI Hideaki (1):
6lowpan: Fix endianness issue in is_addr_link_local().
Greg KH
maintainerMakefile +1 -1
@@ -1,6 +1,6 @@ VERSION = 3 PATCHLEVEL = 4 -SUBLEVEL = 36 +SUBLEVEL = 37 EXTRAVERSION = NAME = Saber-toothed Squirrel
arch/powerpc/kernel/cputable.c +1 -1
@@ -269,7 +269,7 @@ static struct cpu_spec __initdata cpu_specs[] = { .cpu_features = CPU_FTRS_PPC970, .cpu_user_features =COMMON_USER_POWER4 | PPC_FEATURE_HAS_ALTIVEC_COMP, - .mmu_features = MMU_FTR_HPTE_TABLE, + .mmu_features = MMU_FTRS_PPC970, .icache_bsize = 128, .dcache_bsize = 128, .num_pmcs = 8,
arch/powerpc/mm/hash_utils_64.c +2 -0
@@ -759,6 +759,8 @@ void __init early_init_mmu(void)/* Initialize stab / SLB management */ if (mmu_has_feature (MMU_FTR_SLB ))slb_initialize (); +else +stab_initialize (get_paca ()->stab_real); }#ifdef CONFIG_SMP
arch/s390/include/asm/tlbflush.h +0 -2
@@ -74,8 +74,6 @@ static inline void __tlb_flush_idte(unsigned long asce)static inline void __tlb_flush_mm (struct mm_struct * mm) { -if (unlikely (cpumask_empty (mm_cpumask (mm)))) -return ;/* * If the machine has IDTE we prefer to do a per mm flush * on all cpus instead of doing a local flush if the mm
arch/s390/kernel/entry.S +2 -1
@@ -669,7 +669,8 @@ ENTRY(mcck_int_handler) UPDATE_VTIME %r14,%r15,__LC_MCCK_ENTER_TIMER mcck_skip: SWITCH_ASYNC __LC_GPREGS_SAVE_AREA+32,__LC_PANIC_STACK,PAGE_SHIFT - mvc __PT_R0(64,%r11),__LC_GPREGS_SAVE_AREA + stm %r0,%r7,__PT_R0(%r11) + mvc __PT_R8(32,%r11),__LC_GPREGS_SAVE_AREA+32 stm %r8,%r9,__PT_PSW(%r11) xc __SF_BACKCHAIN(4,%r15),__SF_BACKCHAIN(%r15) l %r1,BASED(.Ldo_machine_check)
arch/s390/kernel/entry64.S +3 -2
@@ -689,8 +689,9 @@ ENTRY(mcck_int_handler) UPDATE_VTIME %r14,__LC_MCCK_ENTER_TIMER LAST_BREAK %r14 mcck_skip: - lghi %r14,__LC_GPREGS_SAVE_AREA - mvc __PT_R0(128,%r11),0(%r14) + lghi %r14,__LC_GPREGS_SAVE_AREA+64 + stmg %r0,%r7,__PT_R0(%r11) + mvc __PT_R8(64,%r11),0(%r14) stmg %r8,%r9,__PT_PSW(%r11) xc __SF_BACKCHAIN(8,%r15),__SF_BACKCHAIN(%r15) lgr %r2,%r11 # pass pointer to pt_regs
arch/x86/kernel/cpu/perf_event_intel_ds.c +10 -0
@@ -723,3 +723,13 @@ void intel_ds_init(void) } } } + +void perf_restore_debug_store (void ) +{ +struct debug_store *ds =__this_cpu_read (cpu_hw_events.ds); + +if (!x86_pmu.bts && !x86_pmu.pebs) +return ; + +wrmsrl (MSR_IA32_DS_AREA , (unsigned long )ds); +}
arch/x86/power/cpu.c +2 -0
@@ -11,6 +11,7 @@#include <linux/suspend.h> #include <linux/export.h> #include <linux/smp.h> +#include <linux/perf_event.h> #include <asm/pgtable.h> #include <asm/proto.h>
@@ -227,6 +228,7 @@ static void __restore_processor_state(struct saved_context *ctxt)do_fpu_end (); x86_platform.restore_sched_clock_state ();mtrr_bp_restore (); +perf_restore_debug_store (); }/* Needed by apm.c */
drivers/block/loop.c +16 -8
@@ -1263,11 +1263,9 @@ static int loop_set_capacity(struct loop_device *lo, struct block_device *bdev)/* the width of sector_t may be narrow for bit-shift */ sz = sec; sz <<=9 ; -mutex_lock (&bdev->bd_mutex);bd_set_size (bdev, sz);/* let user-space know about the new size */ kobject_uevent (&disk_to_dev (bdev->bd_disk)->kobj,KOBJ_CHANGE ); -mutex_unlock (&bdev->bd_mutex); out:return err;
@@ -1837,11 +1835,15 @@ static int __init loop_init(void) max_part = (1UL << part_shift) -1 ; } -if ((1UL << part_shift) >DISK_MAX_PARTS ) -return -EINVAL ; +if ((1UL << part_shift) >DISK_MAX_PARTS ) { + err = -EINVAL ; + goto misc_out; + } -if (max_loop >1UL << (MINORBITS - part_shift)) -return -EINVAL ; +if (max_loop >1UL << (MINORBITS - part_shift)) { + err = -EINVAL ; + goto misc_out; + }/* * If max_loop is specified, create that many devices upfront.
@@ -1859,8 +1861,10 @@ static int __init loop_init(void) range =1UL <<MINORBITS ; } -if (register_blkdev (LOOP_MAJOR ,"loop" )) -return -EIO ; +if (register_blkdev (LOOP_MAJOR ,"loop" )) { + err = -EIO ; + goto misc_out; + }blk_register_region (MKDEV (LOOP_MAJOR ,0 ), range,THIS_MODULE , loop_probe,NULL ,NULL );
@@ -1873,6 +1877,10 @@ static int __init loop_init(void)printk (KERN_INFO "loop: module loaded\n" );return 0 ; + +misc_out: +misc_deregister (&loop_misc); +return err; }static int loop_exit_cb (int id,void *ptr,void *data)
drivers/char/hw_random/virtio-rng.c +11 -2
@@ -89,14 +89,22 @@ static int virtrng_probe(struct virtio_device *vdev) {int err; +if (vq) { +/* We only support one device for now */ +return -EBUSY ; + }/* We expect a single virtqueue. */ vq =virtio_find_single_vq (vdev, random_recv_done,"input" ); -if (IS_ERR (vq)) -return PTR_ERR (vq); +if (IS_ERR (vq)) { + err =PTR_ERR (vq); + vq =NULL ; +return err; + } err =hwrng_register (&virtio_hwrng);if (err) { vdev->config->del_vqs (vdev); + vq =NULL ;return err; }
@@ -108,6 +116,7 @@ static void __devexit virtrng_remove(struct virtio_device *vdev) vdev->config->reset (vdev);hwrng_unregister (&virtio_hwrng); vdev->config->del_vqs (vdev); + vq =NULL ; }static struct virtio_device_id id_table[] = {
drivers/gpu/drm/i915/i915_gem.c +5 -0
@@ -1186,6 +1186,11 @@ out:case 0 :case -ERESTARTSYS :case -EINTR : +case -EBUSY : +/* +* EBUSY is ok: this just means that another thread +* already did the job. +*/ return VM_FAULT_NOPAGE ;case -ENOMEM :return VM_FAULT_OOM ;
drivers/gpu/drm/i915/intel_display.c +1 -1
@@ -8364,7 +8364,7 @@ void gen6_enable_rps(struct drm_i915_private *dev_priv)I915_WRITE (GEN6_RC_SLEEP ,0 );I915_WRITE (GEN6_RC1e_THRESHOLD,1000 );I915_WRITE (GEN6_RC6_THRESHOLD ,50000 ); -I915_WRITE (GEN6_RC6p_THRESHOLD,100000 ); +I915_WRITE (GEN6_RC6p_THRESHOLD,150000 );I915_WRITE (GEN6_RC6pp_THRESHOLD,64000 );/* unused */ rc6_mode =intel_enable_rc6 (dev_priv->dev);
drivers/hwmon/lineage-pem.c +2 -0
@@ -421,6 +421,7 @@ static struct attribute *pem_input_attributes[] = { &sensor_dev_attr_in2_input.dev_attr.attr, &sensor_dev_attr_curr1_input.dev_attr.attr, &sensor_dev_attr_power1_input.dev_attr.attr, +NULL }; static const struct attribute_group pem_input_group = {
@@ -431,6 +432,7 @@ static struct attribute *pem_fan_attributes[] = { &sensor_dev_attr_fan1_input.dev_attr.attr, &sensor_dev_attr_fan2_input.dev_attr.attr, &sensor_dev_attr_fan3_input.dev_attr.attr, +NULL }; static const struct attribute_group pem_fan_group = {
drivers/hwmon/pmbus/ltc2978.c +8 -6
@@ -59,7 +59,7 @@ enum chips { ltc2978, ltc3880 };struct ltc2978_data {enum chips id;int vin_min, vin_max; -int temp_min, temp_max; +int temp_min, temp_max[2 ];int vout_min[8 ], vout_max[8 ];int iout_max[2 ];int temp2_max;
@@ -113,9 +113,10 @@ static int ltc2978_read_word_data_common(struct i2c_client *client, int page, ret =pmbus_read_word_data (client, page,LTC2978_MFR_TEMPERATURE_PEAK );if (ret >=0 ) { -if (lin11_to_val (ret) >lin11_to_val (data->temp_max)) - data->temp_max = ret; - ret = data->temp_max; +if (lin11_to_val (ret) + >lin11_to_val (data->temp_max[page])) + data->temp_max[page] = ret; + ret = data->temp_max[page]; }break ;case PMBUS_VIRT_RESET_VOUT_HISTORY :
@@ -266,7 +267,7 @@ static int ltc2978_write_word_data(struct i2c_client *client, int page,break ;case PMBUS_VIRT_RESET_TEMP_HISTORY : data->temp_min =0x7bff ; - data->temp_max =0x7c00 ; + data->temp_max[page] =0x7c00 ; ret =ltc2978_clear_peaks (client, page, data->id);break ;default :
@@ -323,7 +324,8 @@ static int ltc2978_probe(struct i2c_client *client, data->vin_min =0x7bff ; data->vin_max =0x7c00 ; data->temp_min =0x7bff ; - data->temp_max =0x7c00 ; +for (i =0 ; i <ARRAY_SIZE (data->temp_max); i++) + data->temp_max[i] =0x7c00 ; data->temp2_max =0x7c00 ;switch (data->id) {
drivers/hwmon/sht15.c +1 -1
@@ -930,7 +930,7 @@ static int __devinit sht15_probe(struct platform_device *pdev)if (ret !=0 ) {dev_err (&pdev->dev,"failed to enable regulator: %d\n" , ret); -return ret; + goto err_free_data; }/*
drivers/net/macvlan.c +1 -0
@@ -584,6 +584,7 @@ void macvlan_common_setup(struct net_device *dev)ether_setup (dev); dev->priv_flags &= ~(IFF_XMIT_DST_RELEASE |IFF_TX_SKB_SHARING ); + dev->priv_flags |=IFF_UNICAST_FLT ; dev->netdev_ops = &macvlan_netdev_ops; dev->destructor = free_netdev; dev->header_ops = &macvlan_hard_header_ops,
drivers/net/tun.c +2 -0
@@ -417,6 +417,8 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, struct net_device *dev)* for indefinite time. */ skb_orphan (skb); +nf_reset (skb); +/* Enqueue packet */ skb_queue_tail (&tun->socket.sk->sk_receive_queue, skb);
drivers/staging/vt6656/main_usb.c +0 -4
@@ -718,8 +718,6 @@ static int vt6656_suspend(struct usb_interface *intf, pm_message_t message)if (device->flags &DEVICE_FLAGS_OPENED )device_close (device->dev); -usb_put_dev (interface_to_usbdev (intf)); -return 0 ; }
@@ -730,8 +728,6 @@ static int vt6656_resume(struct usb_interface *intf)if (!device || !device->dev)return -ENODEV ; -usb_get_dev (interface_to_usbdev (intf)); -if (!(device->flags &DEVICE_FLAGS_OPENED ))device_open (device->dev);
drivers/tty/pty.c +0 -1
@@ -47,7 +47,6 @@ static void pty_close(struct tty_struct *tty, struct file *filp) tty->packet =0 ;if (!tty->link)return ; - tty->link->packet =0 ;set_bit (TTY_OTHER_CLOSED , &tty->link->flags);wake_up_interruptible (&tty->link->read_wait);wake_up_interruptible (&tty->link->write_wait);
drivers/tty/serial/8250/8250_pci.c +4 -0
@@ -4086,6 +4086,10 @@ static struct pci_device_id serial_pci_tbl[] = {PCI_VENDOR_ID_IBM ,0x0299 , 0, 0, pbn_b0_bt_2_115200 }, + { PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9835, +0x1000 ,0x0012 , + 0, 0, pbn_b0_bt_2_115200 }, + { PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9901,0xA000 ,0x1000 , 0, 0, pbn_b0_1_115200 },
drivers/tty/serial/Kconfig +1 -1
@@ -197,7 +197,7 @@ config SERIAL_SAMSUNG_UARTS_4 config SERIAL_SAMSUNG_UARTS int depends on ARM && PLAT_SAMSUNG - default 6 if ARCH_S5P6450 + default 6 if CPU_S5P6450 default 4 if SERIAL_SAMSUNG_UARTS_4 || CPU_S3C2416 default 3 help
drivers/usb/class/cdc-wdm.c +20 -3
@@ -81,6 +81,7 @@ MODULE_DEVICE_TABLE (usb, wdm_ids);#define WDM_RESPONDING 7#define WDM_SUSPENDING 8#define WDM_RESETTING 9 +#define WDM_OVERFLOW 10#define WDM_MAX 16
@@ -180,6 +181,7 @@ static void wdm_in_callback(struct urb *urb) {struct wdm_device *desc = urb->context;int status = urb->status; +int length = urb->actual_length;spin_lock (&desc->iuspin);clear_bit (WDM_RESPONDING , &desc->flags);
@@ -210,9 +212,17 @@ static void wdm_in_callback(struct urb *urb) } desc->rerr = status; - desc->reslength = urb->actual_length; -memmove (desc->ubuf + desc->length, desc->inbuf, desc->reslength); - desc->length += desc->reslength; +if (length + desc->length > desc->wMaxCommand) { +/* The buffer would overflow */ +set_bit (WDM_OVERFLOW , &desc->flags); + }else { +/* we may already be in overflow */ +if (!test_bit (WDM_OVERFLOW , &desc->flags)) { +memmove (desc->ubuf + desc->length, desc->inbuf, length); + desc->length += length; + desc->reslength = length; + } + } skip_error:wake_up (&desc->wait);
@@ -457,6 +467,11 @@ retry: rv = -ENODEV ; goto err; } +if (test_bit (WDM_OVERFLOW , &desc->flags)) { +clear_bit (WDM_OVERFLOW , &desc->flags); + rv = -ENOBUFS ; + goto err; + } i++;if (file->f_flags &O_NONBLOCK ) {if (!test_bit (WDM_READ , &desc->flags)) {
@@ -500,6 +515,7 @@ retry:spin_unlock_irq (&desc->iuspin); goto retry; } +if (!desc->reslength) {/* zero length read */ dev_dbg (&desc->intf->dev,"%s: zero length - clearing WDM_READ\n" , __func__);clear_bit (WDM_READ , &desc->flags);
@@ -1023,6 +1039,7 @@ static int wdm_post_reset(struct usb_interface *intf)struct wdm_device *desc =wdm_find_device (intf);int rv; +clear_bit (WDM_OVERFLOW , &desc->flags);clear_bit (WDM_RESETTING , &desc->flags); rv =recover_from_urb_loss (desc);mutex_unlock (&desc->wlock);
drivers/usb/host/ehci-q.c +13 -5
@@ -135,7 +135,7 @@ qh_refresh (struct ehci_hcd *ehci, struct ehci_qh *qh)* qtd is updated in qh_completions(). Update the QH * overlay here. */ -if (cpu_to_hc32 (ehci, qtd->qtd_dma) == qh->hw->hw_current) { +if (qh->hw->hw_token &ACTIVE_BIT (ehci)) { qh->hw->hw_qtd_next = qtd->hw_next; qtd =NULL ; }
@@ -459,11 +459,19 @@ qh_completions (struct ehci_hcd *ehci, struct ehci_qh *qh)else if (last_status == -EINPROGRESS && !urb->unlinked)continue ; -/* qh unlinked; token in overlay may be most current */ -if (state ==QH_STATE_IDLE - &&cpu_to_hc32 (ehci, qtd->qtd_dma) - == hw->hw_current) { +/* +* If this was the active qtd when the qh was unlinked +* and the overlay's token is active, then the overlay +* hasn't been written back to the qtd yet so use its +* token instead of the qtd's. After the qtd is +* processed and removed, the overlay won't be valid +* any more. +*/ +if (state ==QH_STATE_IDLE && + qh->qtd_list.next == &qtd->qtd_list && + (hw->hw_token &ACTIVE_BIT (ehci))) { token =hc32_to_cpu (ehci, hw->hw_token); + hw->hw_token &= ~ACTIVE_BIT (ehci);/* An unlink may leave an incomplete * async transaction in the TT buffer.
drivers/usb/serial/cp210x.c +20 -0
@@ -91,6 +91,7 @@ static const struct usb_device_id id_table[] = { { USB_DEVICE(0x10C4, 0x813F) }, /* Tams Master Easy Control */ { USB_DEVICE(0x10C4, 0x814A) }, /* West Mountain Radio RIGblaster P&P */ { USB_DEVICE(0x10C4, 0x814B) }, /* West Mountain Radio RIGtalk */ + { USB_DEVICE(0x2405, 0x0003) }, /* West Mountain Radio RIGblaster Advantage */ { USB_DEVICE(0x10C4, 0x8156) }, /* B&G H3000 link cable */ { USB_DEVICE(0x10C4, 0x815E) }, /* Helicomm IP-Link 1220-DVM */ { USB_DEVICE(0x10C4, 0x815F) }, /* Timewave HamLinkUSB */
@@ -156,6 +157,25 @@ static const struct usb_device_id id_table[] = { { USB_DEVICE(0x1BE3, 0x07A6) }, /* WAGO 750-923 USB Service Cable */ { USB_DEVICE(0x1E29, 0x0102) }, /* Festo CPX-USB */ { USB_DEVICE(0x1E29, 0x0501) }, /* Festo CMSP */ + { USB_DEVICE(0x1FB9, 0x0100) }, /* Lake Shore Model 121 Current Source */ + { USB_DEVICE(0x1FB9, 0x0200) }, /* Lake Shore Model 218A Temperature Monitor */ + { USB_DEVICE(0x1FB9, 0x0201) }, /* Lake Shore Model 219 Temperature Monitor */ + { USB_DEVICE(0x1FB9, 0x0202) }, /* Lake Shore Model 233 Temperature Transmitter */ + { USB_DEVICE(0x1FB9, 0x0203) }, /* Lake Shore Model 235 Temperature Transmitter */ + { USB_DEVICE(0x1FB9, 0x0300) }, /* Lake Shore Model 335 Temperature Controller */ + { USB_DEVICE(0x1FB9, 0x0301) }, /* Lake Shore Model 336 Temperature Controller */ + { USB_DEVICE(0x1FB9, 0x0302) }, /* Lake Shore Model 350 Temperature Controller */ + { USB_DEVICE(0x1FB9, 0x0303) }, /* Lake Shore Model 371 AC Bridge */ + { USB_DEVICE(0x1FB9, 0x0400) }, /* Lake Shore Model 411 Handheld Gaussmeter */ + { USB_DEVICE(0x1FB9, 0x0401) }, /* Lake Shore Model 425 Gaussmeter */ + { USB_DEVICE(0x1FB9, 0x0402) }, /* Lake Shore Model 455A Gaussmeter */ + { USB_DEVICE(0x1FB9, 0x0403) }, /* Lake Shore Model 475A Gaussmeter */ + { USB_DEVICE(0x1FB9, 0x0404) }, /* Lake Shore Model 465 Three Axis Gaussmeter */ + { USB_DEVICE(0x1FB9, 0x0600) }, /* Lake Shore Model 625A Superconducting MPS */ + { USB_DEVICE(0x1FB9, 0x0601) }, /* Lake Shore Model 642A Magnet Power Supply */ + { USB_DEVICE(0x1FB9, 0x0602) }, /* Lake Shore Model 648 Magnet Power Supply */ + { USB_DEVICE(0x1FB9, 0x0700) }, /* Lake Shore Model 737 VSM Controller */ + { USB_DEVICE(0x1FB9, 0x0701) }, /* Lake Shore Model 776 Hall Matrix */ { USB_DEVICE(0x3195, 0xF190) }, /* Link Instruments MSO-19 */ { USB_DEVICE(0x3195, 0xF280) }, /* Link Instruments MSO-28 */ { USB_DEVICE(0x3195, 0xF281) }, /* Link Instruments MSO-28 */
drivers/usb/serial/option.c +5 -0
@@ -341,6 +341,8 @@ static void option_instat_callback(struct urb *urb);#define CINTERION_PRODUCT_EU3_E 0x0051#define CINTERION_PRODUCT_EU3_P 0x0052#define CINTERION_PRODUCT_PH8 0x0053 +#define CINTERION_PRODUCT_AH6 0x0055 +#define CINTERION_PRODUCT_PLS8 0x0060/* Olivetti products */ #define OLIVETTI_VENDOR_ID 0x0b3c
@@ -579,6 +581,7 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE(QUANTA_VENDOR_ID, 0xea42), .driver_info = (kernel_ulong_t)&net_intf4_blacklist }, { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0x1c05, USB_CLASS_COMM, 0x02, 0xff) }, + { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0x1c1f, USB_CLASS_COMM, 0x02, 0xff) }, { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0x1c23, USB_CLASS_COMM, 0x02, 0xff) }, { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E173, 0xff, 0xff, 0xff), .driver_info = (kernel_ulong_t) &net_intf1_blacklist },
@@ -1260,6 +1263,8 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_EU3_E) }, { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_EU3_P) }, { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_PH8) }, + { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_AH6) }, + { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_PLS8) }, { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_HC28_MDM) }, { USB_DEVICE(CINTERION_VENDOR_ID, CINTERION_PRODUCT_HC28_MDMNET) }, { USB_DEVICE(SIEMENS_VENDOR_ID, CINTERION_PRODUCT_HC25_MDM) },
drivers/usb/serial/qcaux.c +1 -0
@@ -69,6 +69,7 @@ static struct usb_device_id id_table[] = { { USB_VENDOR_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID, 0xff, 0xfd, 0xff) }, /* NMEA */ { USB_VENDOR_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID, 0xff, 0xfe, 0xff) }, /* WMC */ { USB_VENDOR_AND_INTERFACE_INFO(UTSTARCOM_VENDOR_ID, 0xff, 0xff, 0xff) }, /* DIAG */ + { USB_DEVICE_AND_INTERFACE_INFO(0x1fac, 0x0151, 0xff, 0xff, 0xff) }, { }, };MODULE_DEVICE_TABLE (usb, id_table);
drivers/usb/storage/initializers.c +2 -74
85 lines not on this page · raw message
drivers/usb/storage/initializers.h +2 -2
@@ -46,5 +46,5 @@ int usb_stor_euscsi_init(struct us_data *us);* flash reader */ int usb_stor_ucr61s2b_init (struct us_data *us); -/* This places the HUAWEI usb dongles in multi-port mode */ -int usb_stor_huawei_init (struct us_data *us); +/* This places the HUAWEI E220 devices in multi-port mode */ +int usb_stor_huawei_e220_init (struct us_data *us);
drivers/usb/storage/unusual_devs.h +327 -2
337 lines not on this page · raw message
drivers/video/atmel_lcdfb.c +15 -7
@@ -422,17 +422,22 @@ static int atmel_lcdfb_check_var(struct fb_var_screeninfo *var, = var->bits_per_pixel;break ;case 16 : +/* Older SOCs use IBGR:555 rather than BGR:565. */ +if (sinfo->have_intensity_bit) + var->green.length =5 ; +else + var->green.length =6 ; +if (sinfo->lcd_wiring_mode ==ATMEL_LCDC_WIRING_RGB ) { -/* RGB:565 mode */ - var->red.offset =11 ; +/* RGB:5X5 mode */ + var->red.offset = var->green.length +5 ; var->blue.offset =0 ; }else { -/* BGR:565 mode */ +/* BGR:5X5 mode */ var->red.offset =0 ; - var->blue.offset =11 ; + var->blue.offset = var->green.length +5 ; } var->green.offset =5 ; - var->green.length =6 ; var->red.length = var->blue.length =5 ;break ;case 32 :
@@ -679,8 +684,7 @@ static int atmel_lcdfb_setcolreg(unsigned int regno, unsigned int red,case FB_VISUAL_PSEUDOCOLOR :if (regno <256 ) { -if (cpu_is_at91sam9261 () ||cpu_is_at91sam9263 () - ||cpu_is_at91sam9rl ()) { +if (sinfo->have_intensity_bit) {/* old style I+BGR:555 */ val = ((red >>11 ) &0x001f ); val |= ((green >>6 ) &0x03e0 );
@@ -870,6 +874,10 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev) } sinfo->info = info; sinfo->pdev = pdev; +if (cpu_is_at91sam9261 () ||cpu_is_at91sam9263 () || +cpu_is_at91sam9rl ()) { + sinfo->have_intensity_bit = true; + }strcpy (info->fix.id, sinfo->pdev->name); info->flags =ATMEL_LCDFB_FBINFO_DEFAULT ;
drivers/w1/w1.c +2 -1
@@ -928,7 +928,8 @@ void w1_search(struct w1_master *dev, u8 search_type, w1_slave_found_callback cb tmp64 = (triplet_ret >>2 ); rn |= (tmp64 << i); -if (kthread_should_stop ()) { +/* ensure we're called from kthread and not by netlink callback */ +if (!dev->priv &&kthread_should_stop ()) {dev_dbg (&dev->dev,"Abort w1_search\n" );return ; }
drivers/xen/xen-pciback/pciback_ops.c +2 -1
@@ -113,7 +113,8 @@ void xen_pcibk_reset_device(struct pci_dev *dev)if (dev->msi_enabled)pci_disable_msi (dev);#endif -pci_disable_device (dev); +if (pci_is_enabled (dev)) +pci_disable_device (dev);pci_write_config_word (dev,PCI_COMMAND ,0 );
fs/block_dev.c +3 -1
@@ -1086,7 +1086,9 @@ void bd_set_size(struct block_device *bdev, loff_t size) {unsigned bsize =bdev_logical_block_size (bdev); - bdev->bd_inode->i_size = size; +mutex_lock (&bdev->bd_inode->i_mutex); +i_size_write (bdev->bd_inode, size); +mutex_unlock (&bdev->bd_inode->i_mutex);while (bsize <PAGE_CACHE_SIZE ) {if (size & bsize)break ;
fs/btrfs/volumes.c +6 -0
@@ -591,6 +591,12 @@ int btrfs_close_devices(struct btrfs_fs_devices *fs_devices)__btrfs_close_devices (fs_devices);free_fs_devices (fs_devices); } +/* +* Wait for rcu kworkers under __btrfs_close_devices +* to finish all blkdev_puts so device is really +* free when umount is done. +*/ +rcu_barrier ();return ret; }
fs/ext3/super.c +2 -2
@@ -364,7 +364,7 @@ static struct block_device *ext3_blkdev_get(dev_t dev, struct super_block *sb)return bdev; fail: -ext3_msg (sb,"error: failed to open journal device %s: %ld" , +ext3_msg (sb,KERN_ERR ,"error: failed to open journal device %s: %ld" ,__bdevname (dev, b),PTR_ERR (bdev));return NULL ;
@@ -891,7 +891,7 @@ static ext3_fsblk_t get_sb_block(void **data, struct super_block *sb)/*todo: use simple_strtoll with >32bit ext3 */ sb_block =simple_strtoul (options, &options,0 );if (*options && *options !=',' ) { -ext3_msg (sb,"error: invalid sb specification: %s" , +ext3_msg (sb,KERN_ERR ,"error: invalid sb specification: %s" , (char *) *data);return 1 ; }
include/linux/perf_event.h +6 -0
@@ -1330,6 +1330,12 @@ static inline void perf_event_disable(struct perf_event *event) { }static inline void perf_event_task_tick (void ) { }#endif +#if defined(CONFIG_PERF_EVENTS ) && defined(CONFIG_CPU_SUP_INTEL ) +extern void perf_restore_debug_store (void ); +#else +static inline void perf_restore_debug_store (void ) { } +#endif +#define perf_output_put (handle, x) perf_output_copy((handle), &(x), sizeof(x))/*
include/video/atmel_lcdc.h +1 -0
@@ -62,6 +62,7 @@ struct atmel_lcdfb_info {void (*atmel_lcdfb_power_control)(int on);struct fb_monspecs *default_monspecs;u32 pseudo_palette[16 ]; +bool have_intensity_bit; };#define ATMEL_LCDC_DMABADDR1 0x00
kernel/signal.c +3 -0
@@ -482,6 +482,9 @@ flush_signal_handlers(struct task_struct *t, int force_default)if (force_default || ka->sa.sa_handler !=SIG_IGN ) ka->sa.sa_handler =SIG_DFL ; ka->sa.sa_flags =0 ; +#ifdef SA_RESTORER + ka->sa.sa_restorer =NULL ; +#endif sigemptyset (&ka->sa.sa_mask); ka++; }
net/core/dev.c +1 -0
@@ -3230,6 +3230,7 @@ ncls: }switch (rx_handler (&skb)) {case RX_HANDLER_CONSUMED : + ret =NET_RX_SUCCESS ; goto out;case RX_HANDLER_ANOTHER : goto another_round;
net/core/rtnetlink.c +1 -0
@@ -975,6 +975,7 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb, struct net_device *dev,* report anything. */ ivi.spoofchk =-1 ; +memset (ivi.mac,0 ,sizeof (ivi.mac));if (dev->netdev_ops->ndo_get_vf_config (dev, i, &ivi))break ; vf_mac.vf =
net/dcb/dcbnl.c +7 -0
@@ -336,6 +336,7 @@ static int dcbnl_getperm_hwaddr(struct net_device *netdev, struct nlattr **tb, dcb->dcb_family =AF_UNSPEC ; dcb->cmd =DCB_CMD_GPERM_HWADDR ; +memset (perm_addr,0 ,sizeof (perm_addr)); netdev->dcbnl_ops->getpermhwaddr (netdev, perm_addr); ret = nla_put(dcbnl_skb, DCB_ATTR_PERM_HWADDR, sizeof(perm_addr),
@@ -1238,6 +1239,7 @@ static int dcbnl_ieee_fill(struct sk_buff *skb, struct net_device *netdev)if (ops->ieee_getets) {struct ieee_ets ets; +memset (&ets,0 ,sizeof (ets)); err = ops->ieee_getets (netdev, &ets);if (!err)NLA_PUT (skb,DCB_ATTR_IEEE_ETS ,sizeof (ets), &ets);
@@ -1245,6 +1247,7 @@ static int dcbnl_ieee_fill(struct sk_buff *skb, struct net_device *netdev)if (ops->ieee_getpfc) {struct ieee_pfc pfc; +memset (&pfc,0 ,sizeof (pfc)); err = ops->ieee_getpfc (netdev, &pfc);if (!err)NLA_PUT (skb,DCB_ATTR_IEEE_PFC ,sizeof (pfc), &pfc);
@@ -1277,6 +1280,7 @@ static int dcbnl_ieee_fill(struct sk_buff *skb, struct net_device *netdev)/* get peer info if available */ if (ops->ieee_peer_getets) {struct ieee_ets ets; +memset (&ets,0 ,sizeof (ets)); err = ops->ieee_peer_getets (netdev, &ets);if (!err)NLA_PUT (skb,DCB_ATTR_IEEE_PEER_ETS ,sizeof (ets), &ets);
@@ -1284,6 +1288,7 @@ static int dcbnl_ieee_fill(struct sk_buff *skb, struct net_device *netdev)if (ops->ieee_peer_getpfc) {struct ieee_pfc pfc; +memset (&pfc,0 ,sizeof (pfc)); err = ops->ieee_peer_getpfc (netdev, &pfc);if (!err)NLA_PUT (skb,DCB_ATTR_IEEE_PEER_PFC ,sizeof (pfc), &pfc);
@@ -1463,6 +1468,7 @@ static int dcbnl_cee_fill(struct sk_buff *skb, struct net_device *netdev)/* peer info if available */ if (ops->cee_peer_getpg) {struct cee_pg pg; +memset (&pg,0 ,sizeof (pg)); err = ops->cee_peer_getpg (netdev, &pg);if (!err)NLA_PUT (skb,DCB_ATTR_CEE_PEER_PG ,sizeof (pg), &pg);
@@ -1470,6 +1476,7 @@ static int dcbnl_cee_fill(struct sk_buff *skb, struct net_device *netdev)if (ops->cee_peer_getpfc) {struct cee_pfc pfc; +memset (&pfc,0 ,sizeof (pfc)); err = ops->cee_peer_getpfc (netdev, &pfc);if (!err)NLA_PUT (skb,DCB_ATTR_CEE_PEER_PFC ,sizeof (pfc), &pfc);
net/ieee802154/6lowpan.h +1 -1
@@ -87,7 +87,7 @@ (memcmp (addr1, addr2, length >>3 ) ==0 ) /* local link, i.e. FE80::/10 */ -#define is_addr_link_local (a) (((a)->s6_addr16[0]) == 0x80FE) +#define is_addr_link_local (a) (((a)->s6_addr16[0]) == htons(0xFE80))/* * check whether we can compress the IID to 16 bits,
net/ipv4/tcp_input.c +3 -3
@@ -5519,6 +5519,9 @@ int tcp_rcv_established(struct sock *sk, struct sk_buff *skb,if (tcp_checksum_complete_user (sk, skb)) goto csum_error; +if ((int )skb->truesize > sk->sk_forward_alloc) + goto step5; +/* Predicted packet is in window by definition. * seq == rcv_nxt and rcv_wup <= rcv_nxt. * Hence, check seq<=rcv_wup reduces to:
@@ -5530,9 +5533,6 @@ int tcp_rcv_established(struct sock *sk, struct sk_buff *skb,tcp_rcv_rtt_measure_ts (sk, skb); -if ((int )skb->truesize > sk->sk_forward_alloc) - goto step5; -NET_INC_STATS_BH (sock_net (sk),LINUX_MIB_TCPHPHITS );/* Bulk data transfer: receiver */
net/ipv6/ip6_input.c +2 -1
@@ -265,7 +265,8 @@ int ip6_mc_input(struct sk_buff *skb)* IPv6 multicast router mode is now supported ;) */ if (dev_net (skb->dev)->ipv6.devconf_all->mc_forwarding && - !(ipv6_addr_type (&hdr->daddr) &IPV6_ADDR_LINKLOCAL ) && + !(ipv6_addr_type (&hdr->daddr) & + (IPV6_ADDR_LOOPBACK |IPV6_ADDR_LINKLOCAL )) &&likely (!(IP6CB (skb)->flags &IP6SKB_FORWARDED ))) {/* * Okay, we try to forward - split and duplicate
net/ipv6/route.c +2 -1
@@ -1973,7 +1973,8 @@ void rt6_purge_dflt_routers(struct net *net) restart:read_lock_bh (&table->tb6_lock);for (rt = table->tb6_root.leaf; rt; rt = rt->dst.rt6_next) { -if (rt->rt6i_flags & (RTF_DEFAULT |RTF_ADDRCONF )) { +if (rt->rt6i_flags & (RTF_DEFAULT |RTF_ADDRCONF ) && + (!rt->rt6i_idev || rt->rt6i_idev->cnf.accept_ra !=2 )) {dst_hold (&rt->dst);read_unlock_bh (&table->tb6_lock);ip6_del_rt (rt);
net/l2tp/l2tp_ppp.c +1 -0
@@ -360,6 +360,7 @@ static int pppol2tp_sendmsg(struct kiocb *iocb, struct socket *sock, struct msghl2tp_xmit_skb (session, skb, session->hdr_len);sock_put (ps->tunnel_sock); +sock_put (sk);return error;
net/netlabel/netlabel_unlabeled.c +11 -16
@@ -1189,8 +1189,6 @@ static int netlbl_unlabel_staticlist(struct sk_buff *skb,struct netlbl_unlhsh_walk_arg cb_arg;u32 skip_bkt = cb->args[0 ];u32 skip_chain = cb->args[1 ]; -u32 skip_addr4 = cb->args[2 ]; -u32 skip_addr6 = cb->args[3 ];u32 iter_bkt;u32 iter_chain =0 , iter_addr4 =0 , iter_addr6 =0 ;struct netlbl_unlhsh_iface *iface;
@@ -1215,7 +1213,7 @@ static int netlbl_unlabel_staticlist(struct sk_buff *skb,continue ;netlbl_af4list_foreach_rcu (addr4, &iface->addr4_list) { -if (iter_addr4++ < skip_addr4) +if (iter_addr4++ < cb->args[2 ])continue ; if (netlbl_unlabel_staticlist_gen( NLBL_UNLABEL_C_STATICLIST,
@@ -1231,7 +1229,7 @@ static int netlbl_unlabel_staticlist(struct sk_buff *skb,#if IS_ENABLED (CONFIG_IPV6 )netlbl_af6list_foreach_rcu (addr6, &iface->addr6_list) { -if (iter_addr6++ < skip_addr6) +if (iter_addr6++ < cb->args[3 ])continue ; if (netlbl_unlabel_staticlist_gen( NLBL_UNLABEL_C_STATICLIST,
@@ -1250,10 +1248,10 @@ static int netlbl_unlabel_staticlist(struct sk_buff *skb, unlabel_staticlist_return:rcu_read_unlock (); - cb->args[0 ] = skip_bkt; - cb->args[1 ] = skip_chain; - cb->args[2 ] = skip_addr4; - cb->args[3 ] = skip_addr6; + cb->args[0 ] = iter_bkt; + cb->args[1 ] = iter_chain; + cb->args[2 ] = iter_addr4; + cb->args[3 ] = iter_addr6;return skb->len; }
@@ -1273,12 +1271,9 @@ static int netlbl_unlabel_staticlistdef(struct sk_buff *skb, {struct netlbl_unlhsh_walk_arg cb_arg;struct netlbl_unlhsh_iface *iface; -u32 skip_addr4 = cb->args[0 ]; -u32 skip_addr6 = cb->args[1 ]; -u32 iter_addr4 =0 ; +u32 iter_addr4 =0 , iter_addr6 =0 ;struct netlbl_af4list *addr4;#if IS_ENABLED (CONFIG_IPV6 ) -u32 iter_addr6 =0 ;struct netlbl_af6list *addr6;#endif
@@ -1292,7 +1287,7 @@ static int netlbl_unlabel_staticlistdef(struct sk_buff *skb, goto unlabel_staticlistdef_return; netlbl_af4list_foreach_rcu(addr4, &iface->addr4_list) { -if (iter_addr4++ < skip_addr4) +if (iter_addr4++ < cb->args[0 ])continue ; if (netlbl_unlabel_staticlist_gen(NLBL_UNLABEL_C_STATICLISTDEF, iface,
@@ -1305,7 +1300,7 @@ static int netlbl_unlabel_staticlistdef(struct sk_buff *skb, }#if IS_ENABLED (CONFIG_IPV6 ) netlbl_af6list_foreach_rcu(addr6, &iface->addr6_list) { -if (iter_addr6++ < skip_addr6) +if (iter_addr6++ < cb->args[1 ])continue ; if (netlbl_unlabel_staticlist_gen(NLBL_UNLABEL_C_STATICLISTDEF, iface,
@@ -1320,8 +1315,8 @@ static int netlbl_unlabel_staticlistdef(struct sk_buff *skb, unlabel_staticlistdef_return:rcu_read_unlock (); - cb->args[0 ] = skip_addr4; - cb->args[1 ] = skip_addr6; + cb->args[0 ] = iter_addr4; + cb->args[1 ] = iter_addr6;return skb->len; }
net/rds/message.c +3 -0
@@ -197,6 +197,9 @@ struct rds_message *rds_message_alloc(unsigned int extra_len, gfp_t gfp) {struct rds_message *rm; +if (extra_len >KMALLOC_MAX_SIZE -sizeof (struct rds_message )) +return NULL ; + rm =kzalloc (sizeof (struct rds_message ) + extra_len, gfp);if (!rm) goto out;
security/selinux/xfrm.c +1 -1
@@ -310,7 +310,7 @@ int selinux_xfrm_policy_clone(struct xfrm_sec_ctx *old_ctx,if (old_ctx) { new_ctx =kmalloc (sizeof (*old_ctx) + old_ctx->ctx_len, -GFP_KERNEL ); +GFP_ATOMIC );if (!new_ctx)return -ENOMEM ;
sound/core/seq/seq_timer.c +4 -4
@@ -290,10 +290,10 @@ int snd_seq_timer_open(struct snd_seq_queue *q) tid.device =SNDRV_TIMER_GLOBAL_SYSTEM ; err =snd_timer_open (&t, str, &tid, q->queue); } -if (err <0 ) { -snd_printk (KERN_ERR "seq fatal error: cannot create timer (%i)\n" , err); -return err; - } + } +if (err <0 ) { +snd_printk (KERN_ERR "seq fatal error: cannot create timer (%i)\n" , err); +return err; } t->callback = snd_seq_timer_interrupt; t->callback_data = q;