Skip to contentSkip to conversation

ARM: implement erratum 716044 workaround

PATCH New Stephen Warren 3 participants 11 messages Mar 4, 2013 – Mar 22, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: implement erratum 716044 workaround

From: Stephen Warren <[email protected]>

Add common code to enable the workaround for ARM erratum 716044. This will be enabled for Tegra.

---
This depends on my previous ARM errata series. I found out we needed another one after I wrote the first series.

 README                     |    1 +
 arch/arm/cpu/armv7/start.S |    6 ++++++
 2 files changed, 7 insertions(+)
README +1 -0
index f2b1c88..97ef9f0 100644
@@ -485,6 +485,7 @@ The following options need to be configured:
 		Thumb2 this flag will result in Thumb2 code generated by
 		GCC.
 
+		CONFIG_ARM_ERRATA_716044
 		CONFIG_ARM_ERRATA_742230
 		CONFIG_ARM_ERRATA_743622
 		CONFIG_ARM_ERRATA_751472
arch/arm/cpu/armv7/start.S +6 -0
index 30f02d3..6834ffe 100644
@@ -310,6 +310,12 @@ ENTRY(cpu_init_cp15)
 #endif
 	mcr	p15, 0, r0, c1, c0, 0
 
+#ifdef CONFIG_ARM_ERRATA_716044
+	mrc	p15, 0, r0, c1, c0, 0	@ read system control register
+	orr	r0, r0, #1 << 11	@ set bit #11
+	mcr	p15, 0, r0, c1, c0, 0	@ write system control register
+#endif
+
 #ifdef CONFIG_ARM_ERRATA_742230
 	mrc	p15, 0, r0, c15, c0, 1	@ read diagnostic register
 	orr	r0, r0, #1 << 4		@ set bit #4
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 2/2 ARM: tegra: enable workaround for ARM erratum 716044

From: Stephen Warren <[email protected]>

Tegra20 requires the workaround for this erratum. Enable it.

---
 include/configs/tegra20-common.h |    1 +
 1 file changed, 1 insertion(+)
include/configs/tegra20-common.h +1 -0
index e464e06..395a657 100644
@@ -28,6 +28,7 @@
 /*
  * Errata configuration
  */
+#define CONFIG_ARM_ERRATA_716044
 #define CONFIG_ARM_ERRATA_742230
 #define CONFIG_ARM_ERRATA_751472
 
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 2/2 ARM: tegra: enable workaround for ARM erratum 716044

Stephen/Albert,

Quoted 22 lines

-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Monday, March 04, 2013 4:30 PM
To: u-boot at lists.denx.de; Albert Aribaud
Cc: Simon Glass; Tom Warren; Stephen Warren
Subject: [PATCH 2/2] ARM: tegra: enable workaround for ARM erratum 716044

From: Stephen Warren <[email protected]>

Tegra20 requires the workaround for this erratum. Enable it.

---
 include/configs/tegra20-common.h |    1 +
 1 file changed, 1 insertion(+)
include/configs/tegra20- renamed from include/configs/tegra20-common.h +0 -0

common.h
index e464e06..395a657 100644

include/configs/tegra20-common.h line 33

Quoted 6 lines
include/configs/tegra20-common.h +1 -0
@@ -28,6 +28,7 @@
 /*
  * Errata configuration
  */
+#define CONFIG_ARM_ERRATA_716044
 #define CONFIG_ARM_ERRATA_742230
 #define CONFIG_ARM_ERRATA_751472

The two sets of ARM erratum patches are currently assigned to Albert. I can take just the Tegra patches, since adding these #defines won't affect anything w/o the corresponding ARM code. Let me know if you (Albert) want me to take the 2 ARM: tegra: errata patches in thru the Tegra tree, or if you'll take 'em whole hog in thru ARM.

Tom

Quoted 1 line

--
nvpublic

#3 lore raw

PATCH 1/2 ARM: implement erratum 716044 workaround

In reply to Stephen Warren

Albert,

Quoted 6 lines

-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Monday, March 04, 2013 4:30 PM
To: u-boot at lists.denx.de; Albert Aribaud
Cc: Simon Glass; Tom Warren; Stephen Warren
Subject: [PATCH 1/2] ARM: implement erratum 716044 workaround

This patchset from Stephen (includes "2/2 ARM: tegra: enable workaround for ARM erratum 716044") are both assigned to you in PatchWork, but haven't been applied yet to ARM/master AFAICT. I found them when I was searching for unapplied Tegra patches.

Could you please take this in thru the ARM tree ASAP?

Thanks,

Tom

Quoted 44 lines

From: Stephen Warren <[email protected]>

Add common code to enable the workaround for ARM erratum 716044. This will be enabled for Tegra.

---
This depends on my previous ARM errata series. I found out we needed another one after I wrote the first series.

 README                     |    1 +
 arch/arm/cpu/armv7/start.S |    6 ++++++
 2 files changed, 7 insertions(+)
README +1 -0
index f2b1c88..97ef9f0 100644
@@ -485,6 +485,7 @@ The following options need to be configured:
 		Thumb2 this flag will result in Thumb2 code generated by
 		GCC.
 
+		CONFIG_ARM_ERRATA_716044
 		CONFIG_ARM_ERRATA_742230
 		CONFIG_ARM_ERRATA_743622
 		CONFIG_ARM_ERRATA_751472
arch/arm/cpu/armv7/start.S index renamed from arch/arm/cpu/armv7/start.S +0 -0

30f02d3..6834ffe 100644

arch/arm/cpu/armv7/start.S +6 -1
@@ -310,6 +310,12 @@ ENTRY(cpu_init_cp15)  #endif
 	mcr	p15, 0, r0, c1, c0, 0
 
+#ifdef CONFIG_ARM_ERRATA_716044
+	mrc	p15, 0, r0, c1, c0, 0	@ read system control register
+	orr	r0, r0, #1 << 11	@ set bit #11
+	mcr	p15, 0, r0, c1, c0, 0	@ write system control register
+#endif
+
 #ifdef CONFIG_ARM_ERRATA_742230
 	mrc	p15, 0, r0, c15, c0, 1	@ read diagnostic register
 	orr	r0, r0, #1 << 4		@ set bit #4
--
Quoted 1 line

1.7.10.4

--
nvpublic

#4 lore raw

PATCH 1/2 ARM: implement erratum 716044 workaround

Hi Tom,

Quoted 9 lines · Tom Warren

Albert,

Quoted 6 lines

-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Monday, March 04, 2013 4:30 PM
To: u-boot at lists.denx.de; Albert Aribaud
Cc: Simon Glass; Tom Warren; Stephen Warren
Subject: [PATCH 1/2] ARM: implement erratum 716044 workaround

Quoted 3 lines

This patchset from Stephen (includes "2/2 ARM: tegra: enable workaround for ARM erratum 716044") are both assigned to you in PatchWork, but haven't been applied yet to ARM/master AFAICT. I found them when I was searching for unapplied Tegra patches.

Could you please take this in thru the ARM tree ASAP?

Will take them in later today. Want an ARM PR once done?

Quoted 3 lines

Thanks,

Tom

Amicalement,

Signature · 1 line
Albert.
#5 lore raw

PATCH 1/2 ARM: implement erratum 716044 workaround

Albert,

Quoted 22 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Thursday, March 21, 2013 10:56 AM
To: Tom Warren
Cc: u-boot at lists.denx.de; Simon Glass; Stephen Warren; Tom Warren; Stephen Warren
Subject: Re: [PATCH 1/2] ARM: implement erratum 716044 workaround

Hi Tom,

Quoted 9 lines · Tom Warren

Albert,

Quoted 6 lines

-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Monday, March 04, 2013 4:30 PM
To: u-boot at lists.denx.de; Albert Aribaud
Cc: Simon Glass; Tom Warren; Stephen Warren
Subject: [PATCH 1/2] ARM: implement erratum 716044 workaround

Quoted 8 lines
Quoted 1 line

This patchset from Stephen (includes "2/2 ARM: tegra: enable workaround

for ARM erratum 716044") are both assigned to you in PatchWork, but haven't been applied yet to ARM/master AFAICT. I found them when I was searching for unapplied Tegra patches.

Quoted 2 lines

Could you please take this in thru the ARM tree ASAP?

Will take them in later today. Want an ARM PR once done?

Just a notice that they're in TOT u-boot-arm/master, and I'll rebase u-boot-tegra/next against it.

Thanks,

Tom

Quoted 8 lines
Quoted 4 lines

Thanks,

Tom

Amicalement,
--
Albert.

--
nvpublic

#6 lore raw

PATCH 1/2 ARM: implement erratum 716044 workaround

Hi Tom,

Quoted 25 lines · Tom Warren

Albert,

Quoted 23 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Thursday, March 21, 2013 10:56 AM
To: Tom Warren
Cc: u-boot at lists.denx.de; Simon Glass; Stephen Warren; Tom Warren; Stephen Warren
Subject: Re: [PATCH 1/2] ARM: implement erratum 716044 workaround

Hi Tom,

Quoted 10 lines · Tom Warren

Albert,

Quoted 6 lines

-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Monday, March 04, 2013 4:30 PM
To: u-boot at lists.denx.de; Albert Aribaud
Cc: Simon Glass; Tom Warren; Stephen Warren
Subject: [PATCH 1/2] ARM: implement erratum 716044 workaround

This patchset from Stephen (includes "2/2 ARM: tegra: enable workaround

Quoted 8 lines
Quoted 7 lines

for ARM erratum 716044") are both assigned to you in PatchWork, but haven't been applied yet to ARM/master AFAICT. I found them when I was searching for unapplied Tegra patches.

Quoted 2 lines

Could you please take this in thru the ARM tree ASAP?

Will take them in later today. Want an ARM PR once done?

Just a notice that they're in TOT u-boot-arm/master, and I'll rebase u-boot-tegra/next against it.

Hmm... I don't see them in ARM ToT on my side. Can you point me to the commit ID?

Quoted 3 lines

Thanks,

Tom

Amicalement,

Signature · 1 line
Albert.
#7 lore raw

PATCH 1/2 ARM: implement erratum 716044 workaround

Albert,

Quoted 43 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Thursday, March 21, 2013 11:34 PM
To: Tom Warren
Cc: u-boot at lists.denx.de; Tom Warren; Stephen Warren
Subject: Re: [U-Boot] [PATCH 1/2] ARM: implement erratum 716044 workaround

Hi Tom,

Quoted 30 lines · Tom Warren

Albert,

Quoted 28 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Thursday, March 21, 2013 10:56 AM
To: Tom Warren
Cc: u-boot at lists.denx.de; Simon Glass; Stephen Warren; Tom Warren; Stephen Warren
Subject: Re: [PATCH 1/2] ARM: implement erratum 716044 workaround

Hi Tom,

Quoted 11 lines · Tom Warren

Albert,

Quoted 6 lines

-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Monday, March 04, 2013 4:30 PM
To: u-boot at lists.denx.de; Albert Aribaud
Cc: Simon Glass; Tom Warren; Stephen Warren
Subject: [PATCH 1/2] ARM: implement erratum 716044 workaround

This patchset from Stephen (includes "2/2 ARM: tegra: enable workaround

for ARM erratum 716044") are both assigned to you in PatchWork, but haven't been applied yet to ARM/master AFAICT. I found them when I was searching for unapplied Tegra patches.

Quoted 1 line
Quoted 8 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line

Could you please take this in thru the ARM tree ASAP?

Will take them in later today. Want an ARM PR once done?

Just a notice that they're in TOT u-boot-arm/master, and I'll rebase u-boot-

tegra/next against it.

Hmm... I don't see them in ARM ToT on my side. Can you point me to the commit ID?

I think there's some confusion here. You asked if I wanted an ARM PR - I assume you thought I was Tom Rini?

I'm Tom Warren, the Tegra custodian. I'd like to see this patchset (ARM errata 716044, 2 parts, from Stephen Warren, assigned to you in PatchWork) pulled into u-boot-arm/master. Once that happens, if you let me know it's done, I can rebase u-boot-tegra.git against u-boot-arm.git so that it's pulled into the Tegra repo.

Thanks,

Tom Warren

Quoted 8 lines
Quoted 4 lines

Thanks,

Tom

Amicalement,
--
Albert.

--
nvpublic

#8 lore raw

PATCH 1/2 ARM: implement erratum 716044 workaround

Hi Tom,

Quoted 48 lines · Tom Warren

Albert,

Quoted 46 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Thursday, March 21, 2013 11:34 PM
To: Tom Warren
Cc: u-boot at lists.denx.de; Tom Warren; Stephen Warren
Subject: Re: [U-Boot] [PATCH 1/2] ARM: implement erratum 716044 workaround

Hi Tom,

Quoted 33 lines · Tom Warren

Albert,

Quoted 31 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Thursday, March 21, 2013 10:56 AM
To: Tom Warren
Cc: u-boot at lists.denx.de; Simon Glass; Stephen Warren; Tom Warren; Stephen Warren
Subject: Re: [PATCH 1/2] ARM: implement erratum 716044 workaround

Hi Tom,

Quoted 11 lines · Tom Warren

Albert,

Quoted 6 lines

-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Monday, March 04, 2013 4:30 PM
To: u-boot at lists.denx.de; Albert Aribaud
Cc: Simon Glass; Tom Warren; Stephen Warren
Subject: [PATCH 1/2] ARM: implement erratum 716044 workaround

This patchset from Stephen (includes "2/2 ARM: tegra: enable workaround

for ARM erratum 716044") are both assigned to you in PatchWork, but haven't been applied yet to ARM/master AFAICT. I found them when I was searching for unapplied Tegra patches.

Quoted 2 lines

Could you please take this in thru the ARM tree ASAP?

Will take them in later today. Want an ARM PR once done?

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Just a notice that they're in TOT u-boot-arm/master, and I'll rebase u-boot-

tegra/next against it.

Hmm... I don't see them in ARM ToT on my side. Can you point me to the commit ID?

I think there's some confusion here. You asked if I wanted an ARM PR - I assume you thought I was Tom Rini?

I'm Tom Warren, the Tegra custodian. I'd like to see this patchset (ARM errata 716044, 2 parts, from Stephen Warren, assigned to you in PatchWork) pulled into u-boot-arm/master. Once that happens, if you let me know it's done, I can rebase u-boot-tegra.git against u-boot-arm.git so that it's pulled into the Tegra repo.

I had indeed ask if a PR was wanted, i.e. if you wanted the commits to also go to u-boot/master, as the request seemed urgent and some people prefer to use the mainline tree as their reference.

But I did mis-understand something: when you said "just a notice etc", I took this as meaning you were making the notice to me that the commits were actually there, while you were saying "no PR needed, a simple notice will do". Apologies for this msistake.

I am build-testing the two changes and will push them as soon as done.

Quoted 3 lines

Thanks,

Tom Warren

Amicalement,

Signature · 1 line
Albert.
#9 lore raw

PATCH 1/2 ARM: implement erratum 716044 workaround

In reply to Tom Warren

Hi Tom,

Quoted 25 lines · Tom Warren

Albert,

Quoted 23 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Thursday, March 21, 2013 10:56 AM
To: Tom Warren
Cc: u-boot at lists.denx.de; Simon Glass; Stephen Warren; Tom Warren; Stephen Warren
Subject: Re: [PATCH 1/2] ARM: implement erratum 716044 workaround

Hi Tom,

Quoted 10 lines · Tom Warren

Albert,

Quoted 6 lines

-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Monday, March 04, 2013 4:30 PM
To: u-boot at lists.denx.de; Albert Aribaud
Cc: Simon Glass; Tom Warren; Stephen Warren
Subject: [PATCH 1/2] ARM: implement erratum 716044 workaround

This patchset from Stephen (includes "2/2 ARM: tegra: enable workaround

Quoted 8 lines
Quoted 7 lines

for ARM erratum 716044") are both assigned to you in PatchWork, but haven't been applied yet to ARM/master AFAICT. I found them when I was searching for unapplied Tegra patches.

Quoted 2 lines

Could you please take this in thru the ARM tree ASAP?

Will take them in later today. Want an ARM PR once done?

Just a notice that they're in TOT u-boot-arm/master, and I'll rebase u-boot-tegra/next against it.

Here is said notice, with my apologies for the misunderstanding.

Amicalement,

Signature · 1 line
Albert.
#10 lore raw

PATCH 1/2 ARM: implement erratum 716044 workaround

Albert,

Quoted 43 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Friday, March 22, 2013 8:59 AM
To: Tom Warren
Cc: u-boot at lists.denx.de; Tom Warren; Stephen Warren
Subject: Re: [U-Boot] [PATCH 1/2] ARM: implement erratum 716044 workaround

Hi Tom,

Quoted 30 lines · Tom Warren

Albert,

Quoted 28 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Thursday, March 21, 2013 10:56 AM
To: Tom Warren
Cc: u-boot at lists.denx.de; Simon Glass; Stephen Warren; Tom Warren; Stephen Warren
Subject: Re: [PATCH 1/2] ARM: implement erratum 716044 workaround

Hi Tom,

Quoted 11 lines · Tom Warren

Albert,

Quoted 6 lines

-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Monday, March 04, 2013 4:30 PM
To: u-boot at lists.denx.de; Albert Aribaud
Cc: Simon Glass; Tom Warren; Stephen Warren
Subject: [PATCH 1/2] ARM: implement erratum 716044 workaround

This patchset from Stephen (includes "2/2 ARM: tegra: enable workaround

for ARM erratum 716044") are both assigned to you in PatchWork, but haven't been applied yet to ARM/master AFAICT. I found them when I was searching for unapplied Tegra patches.

Quoted 1 line
Quoted 7 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line

Could you please take this in thru the ARM tree ASAP?

Will take them in later today. Want an ARM PR once done?

Just a notice that they're in TOT u-boot-arm/master, and I'll rebase u-boot-

tegra/next against it.

Here is said notice, with my apologies for the misunderstanding.

No worries, and thanks for the quick work. I'll pull a new ARM FETCH_HEAD into u-boot-tegra/next today.

Tom

Quoted 4 lines

Amicalement,
--
Albert.

--
nvpublic