I2C: Fix i2c fail problem when a process is terminated by a signal on octeon in 3.8

PATCH 송은봉 2 participants 2 messages Feb 26, 2013 – Mar 22, 2013 I2C subsystem host drivers

Share & tools

송은봉

author

2013-02-26 21:08 UTC #0 lore raw

I've been debugging the abnormal operation of i2c on octeon. If a process is terminated by signal in the middle of i2c operation, next i2c read operation which is done by another process was failed. So i changed to ignore signal in the middle of i2c operation. After that the problem was not reproduced.

Signed-off-by EunBong Song <[email protected]>

i2c/busses/i2c-octeon.c 2013-02-21 08:09:38.344018898 -0800 renamed from i2c/busses/i2c-octeon.c.orig 2013-02-21 08:09:03.168018843 -0800 +2 -2

diff -up drivers/i2c/busses/i2c-octeon.c{.orig,}
@@ -183,7 +183,7 @@ static irqreturn_t octeon_i2c_isr(int ir
  struct octeon_i2c *i2c = dev_id;
 
  octeon_i2c_int_disable(i2c);
- wake_up_interruptible(&i2c->queue);
+ wake_up(&i2c->queue);
 
  return IRQ_HANDLED;
 }

@@ -206,7 +206,7 @@ static int octeon_i2c_wait(struct octeon
 
  octeon_i2c_int_enable(i2c);
 
- result = wait_event_interruptible_timeout(i2c->queue,
+ result = wait_event_timeout(i2c->queue,
         octeon_i2c_test_iflg(i2c),
         i2c->adap.timeout);

Wolfram Sang

2013-03-22 10:43 UTC #1 lore raw

Quoted 10 lines · 송은봉

I've been debugging the abnormal operation of i2c on octeon. If a process is terminated by signal in the middle of i2c operation, next i2c read operation which is done by another process was failed. So i changed to ignore signal in the middle of i2c operation. After that the problem was not reproduced.
Signed-off-by EunBong Song <[email protected]>

Basically OK, but you have lots of whitespace issues, so I can't apply your patch. Please resend and make sure it applies.

Thanks,

Wolfram