Drivers: hv: Add a new driver to support host initiated backup
PATCH v2 1/1 Drivers: hv: Add a new driver to support host initiated backup
This driver supports host initiated backup of the guest. On Windows guests, the host can generate application consistent backups using the Windows VSS framework. On Linux, we ensure that the backup will be file system consistent. This driver allows the host to initiate a "Freeze" operation on all the mounted file systems in the guest. Once the mounted file systems in the guest are frozen, the host snapshots the guest's file systems. Once this is done, the guest's file systems are "thawed".
This driver has a user-level component (daemon) that invokes the appropriate operation on all the mounted file systems in response to the requests from the host. The duration for which the guest is frozen is very short - a few seconds. During this interval, the diff disk is comitted.
In this version of the patch I have addressed the feedback from Olaf Herring. Also, some of the connector related issues have been fixed.
--- drivers/hv/Makefile | 2 +- drivers/hv/hv_snapshot.c | 287 ++++++++++++++++++++++++++++++++++++++++ drivers/hv/hv_util.c | 10 ++ include/linux/hyperv.h | 69 ++++++++++ include/uapi/linux/connector.h | 5 +- tools/hv/hv_vss_daemon.c | 220 ++++++++++++++++++++++++++++++ 6 files changed, 591 insertions(+), 2 deletions(-) create mode 100644 drivers/hv/hv_snapshot.c create mode 100644 tools/hv/hv_vss_daemon.c
drivers/hv/Makefile +1 -1
@@ -5,4 +5,4 @@ obj-$(CONFIG_HYPERV_BALLOON) += hv_balloon.o hv_vmbus-y := vmbus_drv.o \ hv.o connection.o channel.o \ channel_mgmt.o ring_buffer.o -hv_utils-y := hv_util.o hv_kvp.o +hv_utils-y := hv_util.o hv_kvp.o hv_snapshot.o
drivers/hv/hv_snapshot.c new file +287 -0
287 lines not on this page · raw message
drivers/hv/hv_util.c +10 -0
@@ -49,6 +49,12 @@ static struct hv_util_service util_kvp = { .util_deinit = hv_kvp_deinit, }; +static struct hv_util_service util_vss = { + .util_cb = hv_vss_onchannelcallback, + .util_init = hv_vss_init, + .util_deinit = hv_vss_deinit, +}; +static void perform_shutdown (struct work_struct *dummy) {orderly_poweroff (true);
@@ -339,6 +345,10 @@ static const struct hv_vmbus_device_id id_table[] = { { HV_KVP_GUID, .driver_data = (unsigned long )&util_kvp }, + /* VSS GUID */ + { HV_VSS_GUID, + .driver_data = (unsigned long )&util_vss + }, { }, };
include/linux/hyperv.h +69 -0
87 lines not on this page · raw message
include/uapi/linux/connector.h +4 -1
@@ -44,8 +44,11 @@#define CN_VAL_DRBD 0x1#define CN_KVP_IDX 0x9/* HyperV KVP */ #define CN_KVP_VAL 0x1/* queries from the kernel */ +#define CN_VSS_IDX 0xA/* HyperV VSS */ +#define CN_VSS_VAL 0x1/* queries from the kernel */ -#define CN_NETLINK_USERS 10/* Highest index + 1 */ + +#define CN_NETLINK_USERS 11/* Highest index + 1 */ /* * Maximum connector's message size.
tools/hv/hv_vss_daemon.c new file +220 -0
220 lines not on this page · raw message
Signature · 1 line
1.7.4.1
Quoted 1 line · K. Y. Srinivasan
This driver has a user-level component (daemon) that invokes the appropriate
This change fixes a few compile errors:
hv_vss_daemon.c:64:15: warning: unknown escape sequence '\/'
hv_vss_daemon.c:64:15: warning: unknown escape sequence '\/'hv_vss_daemon.c: In function 'vss_operate':
hv_vss_daemon.c:66: warning: 'return' with no value, in function returning non-void hv_vss_daemon.c: In function 'main':
hv_vss_daemon.c:130: warning: ignoring return value of 'daemon', declared with attribute warn_unused_result hv_vss_daemon.c: In function 'vss_operate':
hv_vss_daemon.c:47: warning: 'fs_op' may be used uninitialized in this function
tools/hv/hv_vss_daemon.c +9 -4
@@ -51,7 +51,7 @@ static int vss_operate(int operation)FILE *file;char *p;char *x; -int error; +int error =-1 ;switch (operation) {case VSS_OP_FREEZE :
@@ -60,11 +60,13 @@ static int vss_operate(int operation)case VSS_OP_THAW : fs_op ="-u " ;break ; +default : + goto out; } - file =popen ("mount | awk '/^\/dev\// { print $3}'" ,"r" ); + file =popen ("mount | awk '/^\\/dev\\// { print $3}'" ,"r" );if (file ==NULL ) -return ; + goto out;while ((p =fgets (buf,sizeof (buf), file)) !=NULL ) { x =strchr (p,'\n' );
@@ -82,6 +84,7 @@ static int vss_operate(int operation)syslog (LOG_INFO ,"VSS cmd is %s\n" , cmd); error =system (cmd); +out:return error; }
@@ -128,7 +131,9 @@ int main(void)int op;struct hv_vss_msg *vss_msg; -daemon (1 ,0 ); +if (daemon (1 ,0 )) +return 1 ; +openlog ("Hyper-V VSS" ,0 ,LOG_USER );syslog (LOG_INFO ,"VSS starting; pid is:%d" ,getpid ());
KY Srinivasan
Acked-byQuoted 29 lines
-----Original Message-----
From: Olaf Hering [mailto:[email protected]]
Sent: Friday, March 22, 2013 12:15 PM
To: KY Srinivasan
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Evgeniy Polyakov
Subject: Re: [PATCH V2 1/1] Drivers: hv: Add a new driver to support host initiated backupQuoted 1 line · K. Y. Srinivasan
This driver has a user-level component (daemon) that invokes the appropriate
This change fixes a few compile errors:
hv_vss_daemon.c:64:15: warning: unknown escape sequence '\/' hv_vss_daemon.c:64:15: warning: unknown escape sequence '\/'
hv_vss_daemon.c: In function 'vss_operate':
hv_vss_daemon.c:66: warning: 'return' with no value, in function returning non- voidhv_vss_daemon.c: In function 'main':
hv_vss_daemon.c:130: warning: ignoring return value of 'daemon', declared with attributewarn_unused_resulthv_vss_daemon.c: In function 'vss_operate':
hv_vss_daemon.c:47: warning: 'fs_op' may be used uninitialized in this function
Quoted 1 line
Signed-off-by Olaf Hering <[email protected]>
Quoted 38 lines
tools/hv/hv_vss_daemon.c +6
-3@@ -51,7 +51,7 @@ static int vss_operate(int operation)FILE *file;char *p;char *x; -int error; +int error =-1 ;switch (operation) {case VSS_OP_FREEZE :@@ -60,11 +60,13 @@ static int vss_operate(int operation)case VSS_OP_THAW : fs_op ="-u " ;break ; +default : + goto out; } - file =popen ("mount | awk '/^\/dev\// { print $3}'" ,"r" ); + file =popen ("mount | awk '/^\\/dev\\// { print $3}'" ,"r" );if (file ==NULL ) -return ; + goto out;while ((p =fgets (buf,sizeof (buf), file)) !=NULL ) { x =strchr (p,'\n' );@@ -82,6 +84,7 @@ static int vss_operate(int operation)syslog (LOG_INFO ,"VSS cmd is %s\n" , cmd); error =system (cmd); +out:return error; }
tools/hv/hv_vss_daemon.c int main(void) · line 139
Quoted 10 lines
tools/hv/hv_vss_daemon.c +3
-1@@ -128,7 +131,9 @@ int main(void)int op;struct hv_vss_msg *vss_msg; -daemon (1 ,0 ); +if (daemon (1 ,0 )) +return 1 ; +openlog ("Hyper-V VSS" ,0 ,LOG_USER );syslog (LOG_INFO ,"VSS starting; pid is:%d" ,getpid ());
���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m����������?�I�
Quoted 15 lines · Olaf Hering
Quoted 1 line · K. Y. Srinivasan
This driver has a user-level component (daemon) that invokes the appropriate
This change fixes a few compile errors:
hv_vss_daemon.c:64:15: warning: unknown escape sequence '\/'
hv_vss_daemon.c:64:15: warning: unknown escape sequence '\/'hv_vss_daemon.c: In function 'vss_operate':
hv_vss_daemon.c:66: warning: 'return' with no value, in function returning non-voidhv_vss_daemon.c: In function 'main':
hv_vss_daemon.c:130: warning: ignoring return value of 'daemon', declared with attributewarn_unused_resulthv_vss_daemon.c: In function 'vss_operate':
hv_vss_daemon.c:47: warning: 'fs_op' may be used uninitialized in this function
Quoted 1 line
Signed-off-by Olaf Hering <[email protected]>
Please resend with a proper subject: and changelog entry.
thanks,
greg k-h
Quoted 71 lines
tools/hv/hv_vss_daemon.c new file +65
-0@@ -0,0 +1,220 @@ +/* +* An implementation of the host initiated guest snapshot for Hyper-V. +* +* +* Copyright (C) 2013, Microsoft, Inc. +* Author : K. Y. Srinivasan <[email protected]> +* +* This program is free software; you can redistribute it and/or modify it +* under the terms of the GNU General Public License version 2 as published +* by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, but +* WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or +* NON INFRINGEMENT. See the GNU General Public License for more +* details. +* +*/ + + +#include <sys/types.h> +#include <sys/socket.h> +#include <sys/poll.h> +#include <linux/types.h> +#include <stdio.h> +#include <stdlib.h> +#include <unistd.h> +#include <string.h> +#include <ctype.h> +#include <errno.h> +#include <arpa/inet.h> +#include <linux/connector.h> +#include <linux/hyperv.h> +#include <linux/netlink.h> +#include <syslog.h> + +static char vss_recv_buffer[4096 ]; +static char vss_send_buffer[4096 ]; +static struct sockaddr_nl addr; + +#ifndef SOL_NETLINK +#define SOL_NETLINK 270 +#endif + + +static int vss_operate (int operation) +{ +char *fs_op; +char cmd[512 ]; +char buf[512 ]; +FILE *file; +char *p; +char *x; +int error; + +switch (operation) { +case VSS_OP_FREEZE : + fs_op ="-f " ; +break ; +case VSS_OP_THAW : + fs_op ="-u " ; +break ; + } + + file =popen ("mount | awk '/^\/dev\// { print $3}'" ,"r" );
tools/hv/hv_vss_daemon.c line 75
Quoted 10 lines
tools/hv/hv_vss_daemon.c new file +10
-0+if (file ==NULL ) +return ; + +while ((p =fgets (buf,sizeof (buf), file)) !=NULL ) { + x =strchr (p,'\n' ); + *x ='\0' ; +if (!strncmp (p,"/" ,sizeof ("/" ))) +continue ; + +sprintf (cmd,"%s %s %s" ,"fsfreeze " , fs_op, p);
Please use getmntent and FIFREEZE/FITHAW.
However, I wonder if a dedicated daemon is really the best mechanism. Perhaps you can use uevents instead, and trigger the freeze/thaw with udev rules?
Paolo
Quoted 146 lines
tools/hv/hv_vss_daemon.c new file +145
-0+syslog (LOG_INFO ,"VSS cmd is %s\n" , cmd); + error =system (cmd); + } +pclose (file); + +sprintf (cmd,"%s %s %s" ,"fsfreeze " , fs_op,"/" ); +syslog (LOG_INFO ,"VSS cmd is %s\n" , cmd); + error =system (cmd); + +return error; +} + +static int netlink_send (int fd,struct cn_msg *msg) +{ +struct nlmsghdr *nlh; +unsigned int size; +struct msghdr message; +char buffer[64 ]; +struct iovec iov[2 ]; + + size =NLMSG_SPACE (sizeof (struct cn_msg ) + msg->len); + + nlh = (struct nlmsghdr *)buffer; + nlh->nlmsg_seq =0 ; + nlh->nlmsg_pid =getpid (); + nlh->nlmsg_type =NLMSG_DONE ; + nlh->nlmsg_len =NLMSG_LENGTH (size -sizeof (*nlh)); + nlh->nlmsg_flags =0 ; + + iov[0 ].iov_base = nlh; + iov[0 ].iov_len =sizeof (*nlh); + + iov[1 ].iov_base = msg; + iov[1 ].iov_len = size; + +memset (&message,0 ,sizeof (message)); + message.msg_name = &addr; + message.msg_namelen =sizeof (addr); + message.msg_iov = iov; + message.msg_iovlen =2 ; + +return sendmsg (fd, &message,0 ); +} + +int main (void ) +{ +int fd, len, nl_group; +int error; +struct cn_msg *message; +struct pollfd pfd; +struct nlmsghdr *incoming_msg; +struct cn_msg *incoming_cn_msg; +int op; +struct hv_vss_msg *vss_msg; + +daemon (1 ,0 ); +openlog ("Hyper-V VSS" ,0 ,LOG_USER ); +syslog (LOG_INFO ,"VSS starting; pid is:%d" ,getpid ()); + + fd =socket (AF_NETLINK ,SOCK_DGRAM ,NETLINK_CONNECTOR ); +if (fd <0 ) { +syslog (LOG_ERR ,"netlink socket creation failed; error:%d" , fd); +exit (EXIT_FAILURE ); + } + addr.nl_family =AF_NETLINK ; + addr.nl_pad =0 ; + addr.nl_pid =0 ; + addr.nl_groups =0 ; + + + error =bind (fd, (struct sockaddr *)&addr,sizeof (addr)); +if (error <0 ) { +syslog (LOG_ERR ,"bind failed; error:%d" , error); +close (fd); +exit (EXIT_FAILURE ); + } + nl_group =CN_VSS_IDX ; +setsockopt (fd,SOL_NETLINK ,NETLINK_ADD_MEMBERSHIP , &nl_group,sizeof (nl_group)); +/* +* Register ourselves with the kernel. +*/ + message = (struct cn_msg *)vss_send_buffer; + message->id.idx =CN_VSS_IDX ; + message->id.val =CN_VSS_VAL ; + message->ack =0 ; + vss_msg = (struct hv_vss_msg *)message->data; + vss_msg->vss_hdr.operation =VSS_OP_REGISTER ; + + message->len =sizeof (struct hv_vss_msg ); + + len =netlink_send (fd, message); +if (len <0 ) { +syslog (LOG_ERR ,"netlink_send failed; error:%d" , len); +close (fd); +exit (EXIT_FAILURE ); + } + + pfd.fd = fd; + +while (1 ) { +struct sockaddr *addr_p = (struct sockaddr *) &addr; +socklen_t addr_l =sizeof (addr); + pfd.events =POLLIN ; + pfd.revents =0 ; +poll (&pfd,1 ,-1 ); + + len =recvfrom (fd, vss_recv_buffer,sizeof (vss_recv_buffer),0 , + addr_p, &addr_l); + +if (len <0 || addr.nl_pid) { +syslog (LOG_ERR ,"recvfrom failed; pid:%u error:%d %s" , + addr.nl_pid, errno,strerror (errno)); +close (fd); +return -1 ; + } + + incoming_msg = (struct nlmsghdr *)vss_recv_buffer; + +if (incoming_msg->nlmsg_type !=NLMSG_DONE ) +continue ; + + incoming_cn_msg = (struct cn_msg *)NLMSG_DATA (incoming_msg); + vss_msg = (struct hv_vss_msg *)incoming_cn_msg->data; + op = vss_msg->vss_hdr.operation; + error =HV_S_OK ; + +switch (op) { +case VSS_OP_FREEZE : +case VSS_OP_THAW : + error =vss_operate (op); +if (error) + error =HV_E_FAIL ; +break ; +default : +syslog (LOG_ERR ,"Illegal op:%d\n" , op); + } + vss_msg->error = error; + len =netlink_send (fd, incoming_cn_msg); +if (len <0 ) { +syslog (LOG_ERR ,"net_link send failed; error:%d" , len); +exit (EXIT_FAILURE ); + } + } + +}
Quoted 89 lines
-----Original Message-----
From: Paolo Bonzini [mailto:[email protected]] On Behalf Of Paolo Bonzini
Sent: Tuesday, March 26, 2013 5:02 AM
To: KY Srinivasan
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Evgeniy Polyakov
Subject: Re: [PATCH V2 1/1] Drivers: hv: Add a new driver to support host initiated backupQuoted 10 lines
tools/hv/hv_vss_daemon.c new file +4
-0@@ -0,0 +1,220 @@ +/* +* An implementation of the host initiated guest snapshot for Hyper-V. +* +* tools/hv/hv_vss_daemon.c line 14
Quoted 10 lines
tools/hv/hv_vss_daemon.c new file +10
-0+* Copyright (C) 2013, Microsoft, Inc. +* Author : K. Y. Srinivasan <[email protected]> +* +* This program is free software; you can redistribute it and/or modify it +* under the terms of the GNU General Public License version 2 as published +* by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, but +* WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
Quoted 55 lines
tools/hv/hv_vss_daemon.c new file +55
-0+* NON INFRINGEMENT. See the GNU General Public License for more +* details. +* +*/ + + +#include <sys/types.h> +#include <sys/socket.h> +#include <sys/poll.h> +#include <linux/types.h> +#include <stdio.h> +#include <stdlib.h> +#include <unistd.h> +#include <string.h> +#include <ctype.h> +#include <errno.h> +#include <arpa/inet.h> +#include <linux/connector.h> +#include <linux/hyperv.h> +#include <linux/netlink.h> +#include <syslog.h> + +static char vss_recv_buffer[4096 ]; +static char vss_send_buffer[4096 ]; +static struct sockaddr_nl addr; + +#ifndef SOL_NETLINK +#define SOL_NETLINK 270 +#endif + + +static int vss_operate (int operation) +{ +char *fs_op; +char cmd[512 ]; +char buf[512 ]; +FILE *file; +char *p; +char *x; +int error; + +switch (operation) { +case VSS_OP_FREEZE : + fs_op ="-f " ; +break ; +case VSS_OP_THAW : + fs_op ="-u " ; +break ; + } + + file =popen ("mount | awk '/^\/dev\// { print $3}'" ,"r" ); +if (file ==NULL ) +return ; + +while ((p =fgets (buf,sizeof (buf), file)) !=NULL ) {
Quoted 8 lines
tools/hv/hv_vss_daemon.c line 75
Quoted 6 lines
tools/hv/hv_vss_daemon.c new file +6
-0+ x =strchr (p,'\n' ); + *x ='\0' ; +if (!strncmp (p,"/" ,sizeof ("/" ))) +continue ; + +sprintf (cmd,"%s %s %s" ,"fsfreeze " , fs_op, p);Please use getmntent and FIFREEZE/FITHAW.
I think Olaf has already addressed this in the recent patches he has sent.
Quoted 4 lines
However, I wonder if a dedicated daemon is really the best mechanism. Perhaps you can use uevents instead, and trigger the freeze/thaw with udev rules?
I need to be able to return errors back from the freeze/thaw operations.
Regards,
K. Y