Skip to contentSkip to conversation

racy jump label users

DISCUSSION Andi Kleen 2 participants 2 messages Mar 22, 2013 – Apr 18, 2013

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

Jason,

I noticed that a lot of the jump label users are racy, because they implement something like this

static void sched_feat_disable(int i)

{
        if (static_key_enabled(&sched_feat_keys[i]))
                static_key_slow_dec(&sched_feat_keys[i]);
}

static void sched_feat_enable(int i)

{
        if (!static_key_enabled(&sched_feat_keys[i]))
                static_key_slow_inc(&sched_feat_keys[i]);
}

with no extra locking, controlled by sysfs. If two
CPUs do this in parallel the reference can be set multiple times, which gives very unexpected semantics for a sysfs boolean.

Most likely you need a static_key_slow_setstate() that does the check and set inside the jump label lock.

I understand that for inside kernel use reference counts are the right semantics, but they are not so good for sysfs interfaces.

-Andi

Signature · 1 line
[email protected] -- Speaking for myself only
#1 lore raw

Hi Andi,

Agreed. However, other users of 'static_key_enabled()', provide their own locking. For example, in kernel/tracepoint.c, 'static_key_enabled()', relies on
the tracepoints_mutex. Were there any other users that are problematic?

I agree a 'setstate' would be nice. Maybe something like:

static_key_slow_set_true();
static_key_slow_set_false();

Thanks,

-Jason

Quoted 30 lines · Andi Kleen

Jason,

I noticed that a lot of the jump label users are racy, because they implement something like this

static void sched_feat_disable(int i)

{
        if (static_key_enabled(&sched_feat_keys[i]))
                static_key_slow_dec(&sched_feat_keys[i]);
}

static void sched_feat_enable(int i)

{
        if (!static_key_enabled(&sched_feat_keys[i]))
                static_key_slow_inc(&sched_feat_keys[i]);
}

with no extra locking, controlled by sysfs. If two
CPUs do this in parallel the reference can be set multiple times, which gives very unexpected semantics for a sysfs boolean.

Most likely you need a static_key_slow_setstate() that does the check and set inside the jump label lock.

I understand that for inside kernel use reference counts are the right semantics, but they are not so good for sysfs interfaces.

-Andi